commit 4738d202663747876027339bac1aaab887172d5f 74.0.3729.37 author chrome-release-bot <chrome-release-bot@chromium.org> Tue Mar 26 00:42:05 2019 committer chrome-release-bot <chrome-release-bot@chromium.org> Tue Mar 26 00:42:05 2019 Publish DEPS for 74.0.3729.37 DEPS diff]

commit cb7e0a034927b09464caabd916de28c4156306d7 author chrome-release-bot <chrome-release-bot@chromium.org> Tue Mar 26 00:40:30 2019 committer chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Tue Mar 26 00:40:30 2019 Incrementing VERSION to 74.0.3729.37 TBR=cmasso@chromium.org Change-Id: Ia36d000936ed3c72897b51a43acab0f96caf9e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538602 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#441} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/VERSION diff]

commit a502fcf663e114b722e915eebcc9887a1019ff4f author Kristi Park <kristipark@chromium.org> Tue Mar 26 00:05:23 2019 committer Kristi Park <kristipark@chromium.org> Tue Mar 26 00:05:23 2019 [Merge M74] [NTP] Add feature to use a Google search style fakebox with(out) a search icon If enabled, this will change the fakebox to match the Google search style. Also add an additional search icon that can be enabled separately. Can only be applied if the Google search style is also applied. Screencasts: Light: https://drive.google.com/open?id=1_sqGeCdSZ6EUfVVRpxCFJoKLP0baAcdx Dark: https://drive.google.com/open?id=1w4arx2OCwjr3aE_47H0bZ9dCU6oTEbzc Vasco: https://drive.google.com/open?id=1WmZqEF81Et3Abu_NqhpuJ3jCH_K9r3BY Bug: 944624 Change-Id: I9eced8eb05ad9785e70e45cadf1dbda2fc57f5f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535181 Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by: Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#643654}(cherry picked from commit 996ce890dea06fd3611010595b8c974a31849ea9) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538900 Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#440} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/browser/resources/local_ntp/local_ntp.css diff]

chrome/browser/resources/local_ntp/local_ntp.html diff]

chrome/browser/resources/local_ntp/local_ntp.js diff]

chrome/browser/search/local_ntp_source.cc diff]

chrome/browser/search/ntp_features.cc diff]

chrome/browser/search/ntp_features.h diff]

commit 00eef78e9f3d2d21474046ff19b670c23812ca10 author Tim Zheng <timzheng@google.com> Mon Mar 25 23:51:14 2019 committer May Lippert <maybelle@chromium.org> Mon Mar 25 23:51:14 2019 Merge to release branch 3729 M74 Revert "Remove histograms from feedback reports" This reverts commit ffc0bb9b43023c171f5669aba5eb1c2911062f36. Reason for revert: crbug.com/942082 There's a project in process to make use of this data and it was removed just before that started, so we are putting this data back into the feedback reports. Original change's description: > Remove histograms from feedback reports > > Histograms data were added to the feedback reports long > time ago, but they're uncommonly checked and no good use > for them has been found, hence removed. > > BUG=915227 > TEST=File a feedback report and make sure it ends up with > no histogram data. > > Change-Id: Ie8e3540e7afa700ebf4b770c1cee7df729268081 > Reviewed-on: https://chromium-review.googlesource.com/c/1401563 > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#620988} (cherry picked from commit f7d95a16212d3c5752081f9b3a0fc88c5ebe25a9) Bug: 915227, 942082 Change-Id: I68d59b57cc2483430f39c53e92cf8253ba144956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532365 Reviewed-by: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Original-Commit-Position: refs/heads/master@{#642703} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538686 Reviewed-by: May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#439} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/app/generated_resources.grd diff]

chrome/app/generated_resources_grd/IDS_FEEDBACK_INCLUDE_SYSTEM_INFORMATION_AND_METRICS_CHKBOX.png.sha1 [Added - diff

chrome/app/generated_resources_grd/IDS_FEEDBACK_INCLUDE_SYSTEM_INFORMATION_AND_METRICS_CHKBOX_ARC.png.sha1 [Added - diff

chrome/app/generated_resources_grd/IDS_FEEDBACK_INCLUDE_SYSTEM_INFORMATION_CHKBOX.png.sha1 [Deleted - diff

chrome/app/generated_resources_grd/IDS_FEEDBACK_INCLUDE_SYSTEM_INFORMATION_CHKBOX_ARC.png.sha1 [Deleted - diff

chrome/browser/extensions/api/feedback_private/chrome_feedback_private_delegate.cc diff]

chrome/browser/resources/feedback/js/feedback.js diff]

components/feedback/feedback_data.cc diff]

components/feedback/feedback_data.h diff]

components/feedback/feedback_data_unittest.cc diff]

extensions/browser/api/feedback_private/feedback_private_api.cc diff]

extensions/browser/api/feedback_private/feedback_private_api.h diff]

extensions/common/api/feedback_private.idl diff]

commit 20b039f3673582f0cfdfc2afd30f9718fe9f0b33 author John Lee <johntlee@chromium.org> Mon Mar 25 23:29:37 2019 committer Rebekah Potter <rbpotter@chromium.org> Mon Mar 25 23:29:37 2019 Reland "Navi: Add check for Local NTP flag before testing experiment variations" Original CL: http://crrev.com/c/1529386 Revert CL: http://crrev.com/c/1530365 (cherry picked from commit 3fccf16e504630e714ebedb8b69241aedd673a6a) Bug: 938093 Change-Id: I652c26c885e2a9b101f6ed625df59be7eac93958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532663 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642762} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539007 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#438} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/browser/profiles/profile_manager.cc diff]

chrome/browser/ui/webui/welcome/nux/constants.cc diff]

chrome/browser/ui/webui/welcome/nux/constants.h diff]

chrome/browser/ui/webui/welcome/nux_helper.cc diff]

chrome/browser/ui/webui/welcome/nux_helper.h diff]

commit 60603eb05231fdbd8fa29fe4d99df47371ea32b9 author Matt Mueller <mattm@chromium.org> Mon Mar 25 23:19:49 2019 committer Matt Mueller <mattm@chromium.org> Mon Mar 25 23:19:49 2019 Use a weakptr on the URLRequestHttpJob::OnHeadersReceivedCallback callback. Although this doesn't protect the out-params passed to NotifyHeadersReceived, it does prevent a case where the URLRequestHttpJob tries to access a null transaction_ if the callback is called immediately after the job is killed but before it is destroyed. Bug: 934588 Change-Id: I6d92e30e311e820d99dac3b438274ecd43fe544b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520215 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#641297}(cherry picked from commit be9d8e81e8c3ac82d25597e653d929dfff2d8ec1) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539012 Reviewed-by: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#437} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} net/url_request/url_request_http_job.cc diff]

services/network/network_context_unittest.cc diff]

commit 59511044496cbdca6f2b3be74d2c3587c89d5660 author Andrey Kosyakov <caseq@chromium.org> Mon Mar 25 23:06:05 2019 committer Andrey Kosyakov <caseq@chromium.org> Mon Mar 25 23:06:05 2019 DevTools: fix LoadNetworkResource() for file:// URLs with NetworkService on Bug: 941697 Change-Id: Ia9de63f9a5cff1516962dff0ed785f5c26b6b833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525270 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#641959}(cherry picked from commit 2e6734404933d0bc9b56f2a9d64385a09dc9854b) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539010 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#436} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/browser/devtools/devtools_sanity_browsertest.cc diff]

chrome/browser/devtools/devtools_ui_bindings.cc diff]

third_party/blink/renderer/devtools/front_end/Tests.js diff]

commit 6bc25bb1326d07468578183f030828c700e05491 author Matt Wolenetz <wolenetz@chromium.org> Mon Mar 25 22:53:33 2019 committer Matthew Wolenetz <wolenetz@chromium.org> Mon Mar 25 22:53:33 2019 To M74: MSE - WebM: Fix default duration precision capping Sub-microsecond timescales previously could result in incorrect results that fail the assumption that the result must either be kNoTimestamp or at least 1 microsecond. BUG=937846 TEST=WebMTracksParserTest.PrecisionCapping (plus no local regression of existing media_unittests) Change-Id: I2519f23a730e5ddca4dca2a30d749e7484c3cb6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529699 Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642085}(cherry picked from commit efd59e71af1ebe732468d47a0c50b8fa18455d7b) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538785 Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#435} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} media/formats/webm/webm_cluster_parser.cc diff]

media/formats/webm/webm_cluster_parser.h diff]

media/formats/webm/webm_info_parser.cc diff]

media/formats/webm/webm_info_parser.h diff]

media/formats/webm/webm_stream_parser.cc diff]

media/formats/webm/webm_tracks_parser.cc diff]

media/formats/webm/webm_tracks_parser.h diff]

media/formats/webm/webm_tracks_parser_unittest.cc diff]

commit 9bcf7ecc179a1c7e7b78af9e2b2913b8abe2f440 author Yue Li <updowndota@chromium.org> Mon Mar 25 22:44:37 2019 committer Yue Li <updowndota@chromium.org> Mon Mar 25 22:44:37 2019 [M74 merge] Handle dialog close event for Assistant opt-in dialog When the dialog is closed abnormally (for example crash or signout), we need to update the hotword status if user have not complete the enrollment flow. Also set consent status when the flow finished early (for example due to network error). Bug: 942166, 941432 Test: Manual Test Change-Id: Ib57f5524fe91dd431e76eaac75e114e43c40a3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529474 Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#643520}(cherry picked from commit a2a377111581adfb88567648e5432873c55ba8ea) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538449 Reviewed-by: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#434} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/browser/ui/webui/chromeos/assistant_optin/assistant_optin_ui.cc diff]

chrome/browser/ui/webui/chromeos/assistant_optin/assistant_optin_ui.h diff]

chrome/browser/ui/webui/chromeos/login/assistant_optin_flow_screen_handler.cc diff]

chrome/browser/ui/webui/chromeos/login/assistant_optin_flow_screen_handler.h diff]

chromeos/services/assistant/assistant_settings_manager_impl.cc diff]

commit 22cd3a3f228690d1a26c399a084dc2adb1657a9e author Mitsuru Oshima <oshima@chromium.org> Mon Mar 25 22:11:59 2019 committer Mitsuru Oshima <oshima@chromium.org> Mon Mar 25 22:11:59 2019 Fix crash when entering overview from home launcher. The overview's shield widget can be created async, thus it can be null. Bug: 942622 Test: manual Change-Id: Ib39ccd4dff02b67ad08bb280e8a3dd803a478673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525166 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#641369}(cherry picked from commit 0814830e05ce942111d30e2f8f3fc82ecad19a9c) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539003 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#433} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} ash/wm/overview/overview_grid.cc diff]

commit 4644e88137aa0af538a5b2269d472adaea050a0b author Khushal <khushalsagar@chromium.org> Mon Mar 25 21:44:38 2019 committer Khushal <khushalsagar@chromium.org> Mon Mar 25 21:44:38 2019 [m74] ui/android: Missed adding observer in previous change. R=​ericrk@chromium.org Bug: 937031 Change-Id: I0413728e3b18a6e807050137ec2428b52efe644a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525451 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#641708}(cherry picked from commit 5e668fda5b7d036c28ef75fbaec110cd1fc672ee) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538813 Reviewed-by: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#432} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} ui/android/java/src/org/chromium/ui/base/WindowAndroid.java diff]

commit accd4f96113fdda2c890d438a4b73831d9cfe362 author Evan Stade <estade@chromium.org> Mon Mar 25 21:43:46 2019 committer Scott Violet <sky@chromium.org> Mon Mar 25 21:43:46 2019 [MERGE 74] Explicitly close app menu when entering immersive. Bug: 941959 Change-Id: I65211459919cd03c64a85ecb698da2b895e22c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534977 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#643352}(cherry picked from commit 6f9e2ac1dc4aa8c869216391e6318f0331a7f606) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538976 Cr-Commit-Position: refs/branch-heads/3729@{#431} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/browser/ui/views/frame/browser_view.cc diff]

commit e406194acad06deb0eff58a05f1630319c025fd4 author Khushal <khushalsagar@chromium.org> Mon Mar 25 21:42:43 2019 committer Khushal <khushalsagar@chromium.org> Mon Mar 25 21:42:43 2019 [m74] chrome/android: Update refresh rate on display changed. Currently the Vsync monitor, which decides the refresh rate for the display compositor, uses a constant refresh rate queried at initialization. Ensure that it is updated if the display refresh rate changed. TBR=boliu@chromium.org, khushalsagar@chromium.org (cherry picked from commit a04248122cce4d68f277c6c3e0c9c6612e0ce70b) Bug: 937031 Change-Id: I61a6d3bc06c5369732362671b97b967a40863296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513080 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Reviewed-by: Aldo Culquicondor <acondor@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#640271} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538568 Reviewed-by: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#430} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/android/features/vr/java/src/org/chromium/chrome/browser/vr/VrShell.java diff]

components/viz/common/frame_sinks/begin_frame_source.h diff]

components/viz/service/frame_sinks/external_begin_frame_source_android.cc diff]

components/viz/service/frame_sinks/external_begin_frame_source_android.h diff]

components/viz/service/frame_sinks/external_begin_frame_source_android_unittest.cc diff]

components/viz/service/frame_sinks/root_compositor_frame_sink_impl.cc diff]

components/viz/service/frame_sinks/root_compositor_frame_sink_impl.h diff]

components/viz/service/java/src/org/chromium/components/viz/service/frame_sinks/ExternalBeginFrameSourceAndroid.java diff]

content/browser/android/overscroll_controller_android_unittest.cc diff]

content/browser/renderer_host/compositor_impl_android.cc diff]

content/browser/renderer_host/compositor_impl_android.h diff]

services/viz/privileged/interfaces/compositing/display_private.mojom diff]

services/viz/privileged/interfaces/compositing/frame_sink_manager.mojom diff]

ui/android/delegated_frame_host_android_unittest.cc diff]

ui/android/java/src/org/chromium/ui/VSyncMonitor.java diff]

ui/android/java/src/org/chromium/ui/base/WindowAndroid.java diff]

ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java diff]

ui/android/java/src/org/chromium/ui/display/PhysicalDisplayAndroid.java diff]

ui/android/java/src/org/chromium/ui/display/VirtualDisplayAndroid.java diff]

ui/android/window_android.cc diff]

ui/android/window_android.h diff]

ui/android/window_android_compositor.h diff]

commit 413093b814e409ddf367f76f80d305e7baa521ca author Yusuf Ozuysal <yusufo@chromium.org> Mon Mar 25 21:39:42 2019 committer Yusuf Ozuysal <yusufo@chromium.org> Mon Mar 25 21:39:42 2019 Revert "Multi thumbnail support for GridTabSwitcher" This reverts commit c37cd8435033079cdec5c63dce9e972e402f8d3c. Reason for revert: <INSERT REASONING HERE> Original change's description: > Multi thumbnail support for GridTabSwitcher > > This pulls out the ThumbnailProvider so that individual parent > components can create more customized ones. Makes sure we don't update > thumbnails in the strip. > > Using the above plumbing adds a new MultiThumbnailCardProvider that > builds a Bitmap laying out all related tabs in a single card. > > Also adjusts tab_grid_card_item so that it avoids resizing the image > inside (which wouldn't work for these multi-thumbnail bitmaps). > > BUG=943876 > > Change-Id: Ifb42d9c48ed8fe5b8ff1d7f263a6b33461bfb392 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531651 > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#643193}(cherry picked from commit 9a06dca620672138e6ff33399730f121d86adf9c) > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536489 > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Cr-Commit-Position: refs/branch-heads/3729@{#426} > Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} TBR=yusufo@chromium.org Change-Id: Id80ba4e86558ebbb057a37a96df02407aa777f8b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 943876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538886 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#429} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/android/features/tab_ui/BUILD.gn diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/GridTabSwitcherCoordinator.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/MultiThumbnailCardProvider.java [Deleted - diff

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/SilenceLintErrors.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridSheetCoordinator.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiCoordinator.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabListCoordinator.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabListMediator.java diff]

chrome/android/features/tab_ui/junit/src/org/chromium/chrome/browser/tasks/tab_management/TabListMediatorUnitTest.java diff]

chrome/android/java/res/drawable/selected_tab_background.xml diff]

chrome/android/java/res/layout/tab_grid_card_item.xml diff]

chrome/android/java/res/values/dimens.xml diff]

commit 8d132e0debf1ffee4ef98c4d67dac8daba40d48e author Alex Newcomer <newcomer@chromium.org> Mon Mar 25 21:25:44 2019 committer Alex Newcomer <newcomer@chromium.org> Mon Mar 25 21:25:44 2019 cros: Record Apps.AppListSearchResultOpenTypeV2 Replace Apps.AppListSearchResultOpenType with Apps.AppListSearchResultOpenTypeV2 because enough buckets were added to the original histogram that it deserves to be a new histogram. Bug: 922626 Change-Id: Iba50662a7f69618576108c97fcaa3c3e9e1c6566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535216 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#643580}(cherry picked from commit fad75b289b4027170aa7332ce99cd44014b5fd29) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536810 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#428} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/browser/ui/app_list/search/search_util.cc diff]

tools/metrics/histograms/histograms.xml diff]

commit 0ded255e2dce7a0855c70c9979693acce8b83b81 author Alex Newcomer <newcomer@chromium.org> Mon Mar 25 20:50:34 2019 committer Alex Newcomer <newcomer@chromium.org> Mon Mar 25 20:50:34 2019 cros: Record search result launches with more detail Multiple small changes: - Expand Apps.AppListSearchResultOpenType to include all types of search results. - Enforce histogram logging by building it into OpenSearchResult. - This will fix cases below where not all code paths logged to histograms, and will reduce bugs in the future. - Add a new parameter to OpenSearchResult -- AppListLaunchType. - This parameter is either AppSearchResult or SearchResult. - This will help determine ZeroState apps from Suggested chips, and fixes a few cases where we were recording ZeroState apps as Suggested apps (instead of search results). TEST=manual TBR=xiyuan@chromium.org,jennyz@chromium.org,dominickn@chromium.org,nigeltao@chromium.org Bug: 922626 Change-Id: I3eecda5958c4a19f6d952facd243b59f9158955d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518920 Reviewed-by: Nigel Tao <nigeltao@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Jenny Zhang <jennyz@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642560}(cherry picked from commit 30527267dda7eae80b9b5dd49977f9786cc05c62) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537073 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#427} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} ash/app_list/app_list_controller_impl.cc diff]

ash/app_list/app_list_controller_impl.h diff]

ash/app_list/app_list_view_delegate.h diff]

ash/app_list/test/app_list_test_view_delegate.cc diff]

ash/app_list/test/app_list_test_view_delegate.h diff]

ash/app_list/test/test_app_list_client.h diff]

ash/app_list/views/search_result_answer_card_view.cc diff]

ash/app_list/views/search_result_list_view.cc diff]

ash/app_list/views/search_result_suggestion_chip_view.cc diff]

ash/app_list/views/search_result_tile_item_view.cc diff]

ash/app_list/views/search_result_tile_item_view.h diff]

ash/public/interfaces/app_list.mojom diff]

ash/shell/example_app_list_client.cc diff]

ash/shell/example_app_list_client.h diff]

chrome/browser/apps/app_service/built_in_chromeos_apps.cc diff]

chrome/browser/apps/app_service/extension_apps.cc diff]

chrome/browser/ui/app_list/app_list_client_impl.cc diff]

chrome/browser/ui/app_list/app_list_client_impl.h diff]

chrome/browser/ui/app_list/search/answer_card/answer_card_result.cc diff]

chrome/browser/ui/app_list/search/answer_card/answer_card_result.h diff]

chrome/browser/ui/app_list/search/app_result.cc diff]

chrome/browser/ui/app_list/search/app_result.h diff]

chrome/browser/ui/app_list/search/app_service_app_result.cc diff]

chrome/browser/ui/app_list/search/app_service_app_result.h diff]

chrome/browser/ui/app_list/search/arc/arc_app_data_search_result.cc diff]

chrome/browser/ui/app_list/search/arc/arc_app_data_search_result.h diff]

chrome/browser/ui/app_list/search/arc/arc_app_reinstall_app_result.cc diff]

chrome/browser/ui/app_list/search/arc/arc_app_reinstall_app_result.h diff]

chrome/browser/ui/app_list/search/arc/arc_app_reinstall_search_provider_unittest.cc diff]

chrome/browser/ui/app_list/search/arc/arc_app_shortcut_search_result.cc diff]

chrome/browser/ui/app_list/search/arc/arc_app_shortcut_search_result.h diff]

chrome/browser/ui/app_list/search/arc/arc_playstore_search_result.cc diff]

chrome/browser/ui/app_list/search/arc/arc_playstore_search_result.h diff]

chrome/browser/ui/app_list/search/arc_app_result.cc diff]

chrome/browser/ui/app_list/search/arc_app_result.h diff]

chrome/browser/ui/app_list/search/chrome_search_result.h diff]

chrome/browser/ui/app_list/search/crostini/crostini_repository_search_result.cc diff]

chrome/browser/ui/app_list/search/crostini/crostini_repository_search_result.h diff]

chrome/browser/ui/app_list/search/crostini_app_result.cc diff]

chrome/browser/ui/app_list/search/crostini_app_result.h diff]

chrome/browser/ui/app_list/search/extension_app_result.cc diff]

chrome/browser/ui/app_list/search/extension_app_result.h diff]

chrome/browser/ui/app_list/search/internal_app_result.cc diff]

chrome/browser/ui/app_list/search/internal_app_result.h diff]

chrome/browser/ui/app_list/search/launcher_search/launcher_search_result.cc diff]

chrome/browser/ui/app_list/search/launcher_search/launcher_search_result.h diff]

chrome/browser/ui/app_list/search/omnibox_result.cc diff]

chrome/browser/ui/app_list/search/omnibox_result.h diff]

chrome/browser/ui/app_list/search/search_result_ranker/ranking_item_util.cc diff]

chrome/browser/ui/app_list/search/search_util.cc diff]

chrome/browser/ui/app_list/search/search_util.h diff]

chrome/browser/ui/app_list/search/settings_shortcut/settings_shortcut_result.cc diff]

chrome/browser/ui/app_list/search/settings_shortcut/settings_shortcut_result.h diff]

chrome/browser/ui/app_list/search/tests/mixer_unittest.cc diff]

tools/metrics/histograms/enums.xml diff]

commit c37cd8435033079cdec5c63dce9e972e402f8d3c author Yusuf Ozuysal <yusufo@google.com> Mon Mar 25 20:41:33 2019 committer Yusuf Ozuysal <yusufo@chromium.org> Mon Mar 25 20:41:33 2019 Multi thumbnail support for GridTabSwitcher This pulls out the ThumbnailProvider so that individual parent components can create more customized ones. Makes sure we don't update thumbnails in the strip. Using the above plumbing adds a new MultiThumbnailCardProvider that builds a Bitmap laying out all related tabs in a single card. Also adjusts tab_grid_card_item so that it avoids resizing the image inside (which wouldn't work for these multi-thumbnail bitmaps). BUG=943876 Change-Id: Ifb42d9c48ed8fe5b8ff1d7f263a6b33461bfb392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531651 Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#643193}(cherry picked from commit 9a06dca620672138e6ff33399730f121d86adf9c) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536489 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#426} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/android/features/tab_ui/BUILD.gn diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/GridTabSwitcherCoordinator.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/MultiThumbnailCardProvider.java [Added - diff

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/SilenceLintErrors.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridSheetCoordinator.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiCoordinator.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabListCoordinator.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabListMediator.java diff]

chrome/android/features/tab_ui/junit/src/org/chromium/chrome/browser/tasks/tab_management/TabListMediatorUnitTest.java diff]

chrome/android/java/res/drawable/selected_tab_background.xml diff]

chrome/android/java/res/layout/tab_grid_card_item.xml diff]

chrome/android/java/res/values/dimens.xml diff]

commit e4303293d621221e7cbb5a52292ba21987328b84 author danakj <danakj@chromium.org> Mon Mar 25 20:29:32 2019 committer Albert J. Wong <ajwong@chromium.org> Mon Mar 25 20:29:32 2019 Delete the main provisional (speculative) frame during ~WebContentsImpl The FrameTreeNode destruction attempts to CleanUpNavigation() which should DeleteRenderFrame() but the ~WebContentsImpl destructor ruins that by calling SetRenderFrameCreated(false) earlier, in order to notify observers earlier. This then prevents DeleteRenderFrame() from doing its job, and the RenderFrame is left orphaned in the renderer process, with pointers to a RenderWidget that gets deleted shortly after, causing explosions. To avoid leaking the RenderFrame, have ~WebContentsImpl explicitly DeleteRenderFrame() since it is going to SetRenderFrameCreated(false) on the speculative RenderFrameHost. Then CleanUpNavigation() does not need to do anything for the renderer objects, but just cleans up the browser side. R=​avi@chromium.org, dcheng@chromium.org Bug: 939262 Change-Id: I55b302baee58d6d9912f18be331c38d248812eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534111 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#643054}(cherry picked from commit c29c10c7d8c6e96ef1e3cd006f614341253fbdd3) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538714 Reviewed-by: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#425} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} content/browser/renderer_host/render_process_host_impl.cc diff]

content/browser/renderer_host/render_process_host_impl.h diff]

content/browser/web_contents/web_contents_impl.cc diff]

content/browser/web_contents/web_contents_impl_browsertest.cc diff]

commit 2c455c5060a22771cd4ce232df7df5374fc1fb2d author CJ DiMeglio <lethalantidote@chromium.org> Mon Mar 25 20:04:37 2019 committer CJ DiMeglio <lethalantidote@chromium.org> Mon Mar 25 20:04:37 2019 Updates SupportsMouseFocus to respect SupportsFocus. Before we just checked if we were in fullscreen, but we should also check if we even support foucs in the first place. Bug: 943575 Change-Id: I0bd6d0c74c3b6178085aa2c4732f83f6891066d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532907 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642926}(cherry picked from commit 2a5e17dd85a4e49428db035bd85f1301a2aefe4f) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538800 Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#424} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} third_party/blink/renderer/core/html/media/html_media_element.cc diff]

third_party/blink/web_tests/media/video-without-controls-not-selected.html [Added - diff

commit 1d23ba34f8257bed7cb22fd4aa6e8ba17dd28459 author Scott Violet <sky@chromium.org> Mon Mar 25 19:59:41 2019 committer Scott Violet <sky@chromium.org> Mon Mar 25 19:59:41 2019 [MERGE 74] chromeos: updates content_browser manifest to include priviledged interface The browser is responsible for injecting events when using remote desktop. This means, it needs the priviledged interface from the window-service. BUG=944210 TEST=none Change-Id: I8fb9b43a8a446a54bd9c9112c4fbe5985770ebe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532246 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#643094}(cherry picked from commit 4da45adfa0b104402c12414a71eaabb2553848ed) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538798 Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#423} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/app/chrome_content_browser_overlay_manifest.cc diff]

commit d5de2be1b3876c8ee5711db535317492d7001a02 author Scott Violet <sky@chromium.org> Mon Mar 25 19:58:23 2019 committer Scott Violet <sky@chromium.org> Mon Mar 25 19:58:23 2019 [MERGE 74] chromeos: makes WindowTreeClient drop located events while in a drag loop Because the server does not wait for an ack from the client before sending an event it's entirely possible for a sequence like the following: 1 client: mouse event 2 client: start drag 3 client: mouse event 4 server: process start drag, and no longer send any mouse events to client It's 3 that is problematic, as it's entirely possible this could trigger starting *another* drag loop. This patch makes the client ignore located events when the client started a drag loop. A better fix may be to change the server to wait for acks before sending events. I'm going with this for now. This also adds a null check for current_drag_state_ in HandleDragEnterOrOver(). current_drag_state_ is only set if the client initiated the drag, which is not necessarily the case. BUG=944143, 944616 TEST=covered by test Change-Id: I926b6149cfa86c9db2ddcd16e77298ff89a11b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534927 Reviewed-by: Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#643532}(cherry picked from commit a18f6ac901f73cbfc679274269c5471bd6f61151) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538797 Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#422} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} ui/aura/mus/drag_drop_controller_mus.cc diff]

ui/aura/mus/drag_drop_controller_mus.h diff]

ui/aura/mus/drag_drop_controller_mus_unittest.cc diff]

ui/aura/mus/window_tree_client.cc diff]

ui/aura/test/mus/window_tree_client_test_api.cc diff]

ui/aura/test/mus/window_tree_client_test_api.h diff]

commit a9b566119a1beaeff0783fd0a0a1914d9eca0736 author Bo Liu <boliu@chromium.org> Mon Mar 25 19:15:59 2019 committer Bo <boliu@chromium.org> Mon Mar 25 19:15:59 2019 [Merge M74] Relax Display::DidReceivePresentationFeedback check Crash shows low rate of memory corruption crashes probalby due to Display::DidReceivePresentationFeedback being called when pending_presented_callbacks_ is empty. Change the precondition by turning the DCHECK into an early out instead. (cherry picked from commit 4be47bd3cf619365d438dbe08d0ab0030b6f149d) Bug: 943065 Change-Id: I4a8ba2fc26347a4f4f9d537d836077573203c124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529925 Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642809} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538699 Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#420} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} components/viz/service/display/display.cc diff]

commit 2e8ad217732533dc91b519ab91e7d8b05fb91ca1 author Lukasz Anforowicz <lukasza@chromium.org> Mon Mar 25 18:44:15 2019 committer Łukasz Anforowicz <lukasza@chromium.org> Mon Mar 25 18:44:15 2019 [m74] CORB allowlist additions - 2019-03-21. TBR=lukasza@chromium.org (cherry picked from commit f14299dbed3ca54a9079ee09538fa9af04e1b778) Bug: 937081 Change-Id: I172abc944f6c035bcaa3042c5752dcf58a6fbebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534277 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#643433} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538640 Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#419} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} extensions/browser/url_loader_factory_manager.cc diff]

commit 430ea98a40f3d647576dde775fc2e81012d1ce01 author siashah <siashah@chromium.org> Mon Mar 25 18:37:23 2019 committer Jared Saul <jsaul@google.com> Mon Mar 25 18:37:23 2019 Fix dialog dismissed metric count for fix flows. Make the dismissed event count only when the cause of dismissal is either the user clicked on cancel or pressed the back button. Bug: 941768 Change-Id: I5d533ff995d1cc44f032bf99c256ca4f604ebc68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521983 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Becky Zhou <huayinz@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642610}(cherry picked from commit 2d738e15dd9aa4af1799ba1e483ca231a566e489) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535129 Cr-Commit-Position: refs/branch-heads/3729@{#418} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillExpirationDateFixFlowPrompt.java diff]

chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillNameFixFlowPrompt.java diff]

commit 6872fa070e2729bced9d309ab781df0dc17e19a2 author siashah <siashah@chromium.org> Mon Mar 25 18:34:47 2019 committer Jared Saul <jsaul@google.com> Mon Mar 25 18:34:47 2019 Move focus from MM to YY even in error state For expiration date fix flow, do not perform validation onFocusChange, as this would move the focus even when the user is explicitly trying to change a valid date. Bug: 943679 Change-Id: Id5e412b0262827773a2137fbc26a80764b5607a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531118 Reviewed-by: Becky Zhou <huayinz@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642556}(cherry picked from commit a9a53534a9812550c40555ae775490ccfa6f79e2) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535128 Cr-Commit-Position: refs/branch-heads/3729@{#417} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillExpirationDateFixFlowPrompt.java diff]

commit a06a73e33dea9c602a084b11b6fc8a488fa1e259 author Nasko Oskov <nasko@chromium.org> Mon Mar 25 18:10:09 2019 committer Nasko Oskov <nasko@chromium.org> Mon Mar 25 18:10:09 2019 Revert "Add temporary simplified process lock check in the renderer process." This partially reverts https://chromium-review.googlesource.com/1507195 since we don't need the instrumentation anymore. The parts that are kept are plumbing of the network error code into Blink and some minor refactoring in RenderFrameImpl - both of these at the request of the reviewers of the CL as useful parts to stay. Bug: 931895 Change-Id: I71b7cdf82f76d4dfe7f9110f6bd077cc673e14c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524095 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#640896}(cherry picked from commit 1c2c049680ae9344a4f77c4ec95ecb0c17c5d879) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537075 Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#416} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} content/browser/renderer_host/render_process_host_impl.cc diff]

content/browser/service_worker/embedded_worker_test_helper.cc diff]

content/common/renderer.mojom diff]

content/renderer/render_frame_impl.cc diff]

content/renderer/render_thread_impl.cc diff]

content/renderer/render_thread_impl.h diff]

commit daa474daa82969836e24e286f6136c6c7d38a2f2 author Xiaohan Wang <xhwang@chromium.org> Mon Mar 25 17:38:04 2019 committer Xiaohan Wang <xhwang@chromium.org> Mon Mar 25 17:38:04 2019 [merge] media: Add kMediaDrmPreprovisioning feature This feature controls whether MediaDrmOriginIdManager should be used to provide preprovisioned origin IDs for MediaDrmBridge. If disabled, MediaDrmBridge will get unprovisioned origin IDs, which will trigger the provisioning process during MediaDrmBridge createSession(). When disabled, the existing kMediaDrmPreprovisioningAtStartup feature would also have no effect. In the current CL, the feature is disabled by default. Bug: 917527,944350 Test: Added a new test case that disables kMediaDrmPreprovisioning. Change-Id: I17215be2f15d81db72bb40b4160a55f0d92b8b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525154 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: John Rummell <jrummell@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642803}(cherry picked from commit e96fe07afa6d0f9999150e65826cf8ec49fd08c3) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536755 Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#415} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/browser/media/android/cdm/media_drm_origin_id_manager_factory.cc diff]

chrome/browser/media/android/cdm/media_drm_storage_factory.cc diff]

media/base/media_switches.cc diff]

media/base/media_switches.h diff]

commit 438a97a483c4fa7a4bbdaeb004903faf8320c7b6 author Yue Zhang <yuezhanggg@google.com> Mon Mar 25 17:30:00 2019 committer Yusuf Ozuysal <yusufo@chromium.org> Mon Mar 25 17:30:00 2019 Show correct favicons on Tab strip Changes to make sure the favicons on Tab strip show correctly. Show corresponding favicons for pages with icons and default globe icon (R.drawable.ic_globe_24dp) for unknown or loading pages. Show chrome icon (R.drawable.chromelogo16) for native pages. Bug: 937941, 941293 Change-Id: Iff0da86cc9eb33781aeacca4c22085ac5b060cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524912 Commit-Queue: Yue Zhang <yuezhanggg@google.com> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642690}(cherry picked from commit f8ec9c3918b2a8ab4e52afb358bfc9df2b2d9281) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538482 Cr-Commit-Position: refs/branch-heads/3729@{#414} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/android/features/tab_ui/BUILD.gn diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/SilenceLintErrors.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridViewBinder.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiMediator.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabListCoordinator.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabListFaviconProvider.java [Added - diff

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabListMediator.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabProperties.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabStripViewBinder.java diff]

chrome/android/features/tab_ui/junit/src/org/chromium/chrome/browser/tasks/tab_management/TabListMediatorUnitTest.java diff]

chrome/android/java/res/drawable/tabstrip_favicon_background.xml [Added - diff

commit e9721d07a767ab45a1cd5ac5e0982719e5d241bd author Yusuf Ozuysal <yusufo@google.com> Mon Mar 25 17:26:13 2019 committer Yusuf Ozuysal <yusufo@chromium.org> Mon Mar 25 17:26:13 2019 Add incognito and dark mode support to TabStrip and TabGridSheetToolbar This adds incognito and dark mode theming to all top level UI components except the individual cards inside the TabGridSheet and GridTabSwitcher. The theming of the cards will be handled in a separate CL. BUG=939915 Change-Id: I177e437b51719588a8d16059ca094326672bec87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526538 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Pedro Amaral <amaralp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642215}(cherry picked from commit 68c5326b0ed389a67e68a2a6ab659c03bc9f6a37) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536833 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#413} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridSheetCoordinator.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridSheetMediator.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridSheetProperties.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridSheetViewBinder.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiCoordinator.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiMediator.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiToolbarView.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUiToolbarViewBinder.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabManagementModule.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabManagementModuleImpl.java diff]

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabStripToolbarViewProperties.java diff]

chrome/android/java/res/layout/bottom_tab_grid_toolbar.xml diff]

chrome/android/java/res/layout/bottom_tab_strip_toolbar.xml diff]

chrome/android/java/res/layout/tab_list_recycler_view_layout.xml diff]

chrome/android/java/res/layout/tab_strip_item.xml diff]

chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/BottomControlsCoordinator.java diff]

chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java diff]

commit 68cf2477307104d839ab7b1e333ad16027611760 author Xiyuan Xia <xiyuan@chromium.org> Mon Mar 25 17:03:16 2019 committer Xiyuan Xia <xiyuan@chromium.org> Mon Mar 25 17:03:16 2019 Merge M74: Reland "WS: CrashInFlightChange dump window name and location" > This is a reland of fca3ec75eaa93b7d613618a6006f95168ee920f8 > > Original change's description: > > WS: CrashInFlightChange dump window name and location > > > > Dump window name and CrashInFlightChange creation site with > > the fatal log. > > > > Bug: 940620 > > Change-Id: I4645986a47a1c495b3279bc2fa07d24487ccda89 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529691 > > Commit-Queue: Scott Violet <sky@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#642114} > > Bug: 940620 > Change-Id: I78a6b307497eddc93facd917001dccb5664d0b46 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531171 > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Auto-Submit: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642181} (cherry picked from commit c4865b233dea0080b4b6b51d0bd479493ac08ecb) Bug: 940620 Change-Id: I0a3598496950daf7f860d9ef13b4ec20cfcfcf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538391 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#412} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} ui/aura/mus/in_flight_change.cc diff]

ui/aura/mus/in_flight_change.h diff]

ui/aura/mus/window_tree_client.cc diff]

ui/aura/mus/window_tree_client_unittest.cc diff]

commit cb78740800bfe645dbd5e4171824a0220f80fbc3 author Anthony Vallee-Dubois <anthonyvd@chromium.org> Mon Mar 25 15:39:02 2019 committer anthonyvd <anthonyvd@chromium.org> Mon Mar 25 15:39:02 2019 Change HrefAutoTranslate triggering from DSE to Google origins TBR=anthonyvd@chromium.org (cherry picked from commit db7273b791b655dc06546d4d961725cf9676233b) Bug: 900586 Change-Id: Ib0d37b1c6eaf22903dbe0a46603a7989cbb63e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530007 Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642923} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538013 Reviewed-by: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#411} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/browser/translate/chrome_translate_client.cc diff]

chrome/browser/translate/translate_manager_browsertest.cc diff]

components/translate/content/browser/DEPS diff]

components/translate/content/browser/content_translate_driver.cc diff]

components/translate/content/browser/content_translate_driver.h diff]

components/translate/core/browser/language_state.cc diff]

components/translate/core/browser/language_state.h diff]

components/translate/core/browser/translate_manager.cc diff]

commit 1801d7fa0a4742d6827eaedddd1857eb59ac8ff2 author Robbie Gibson <rkgibson@google.com> Mon Mar 25 10:31:04 2019 committer Gauthier Ambard <gambard@chromium.org> Mon Mar 25 10:31:04 2019 Fix Search-by-image crash when given a nil image/data My thought was that ResizedImageForSearchByImage should be fine with an empty image. If, on iOS, it's passed a non-empty image with no UIImage representation, that will still crash, but is probably ok (although if that's what DCHECK should be used for, let me know). Bug: 943145 Change-Id: If617822090273af64a757666a09afa8a4e4861d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530761 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Original-Commit-Position: refs/heads/master@{#641993}(cherry picked from commit 3aec8ba82a4859ba5a750888c21e045db5d55bd1) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535892 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#410} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} ios/chrome/browser/ui/browser_view_controller.mm diff]

ui/gfx/image/image_util_ios.mm diff]

commit 6f98ef482063c6c8834c62cf4ba03a7758f65059 author Jordan Demeulenaere <jdemeulenaere@google.com> Mon Mar 25 08:55:20 2019 committer Jordan Demeulenaere <jdemeulenaere@chromium.org> Mon Mar 25 08:55:20 2019 [Autofill Assistant] Introduce AnimatedPoodle. This CL introduces AnimatedPoodle to allow animating the poodle. This class will be overriden downstream and swapped in BUILD.gn in future CLs. This CL also makes the progress bar smaller and removed the previous pulsing behavior. Videos: - Before: go/aa-poodle-before - After: go/aa-poodle Change-Id: Iaac1279aae8e732a6c2158f17911cec9776f104e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520495 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642557}(cherry picked from commit 2f299874b05ea8ff7f99dc6625a7a7812f41373e) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535835 Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#409} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/android/features/autofill_assistant/BUILD.gn diff]

chrome/android/features/autofill_assistant/java/res/layout/autofill_assistant_header.xml diff]

chrome/android/features/autofill_assistant/java/res/values-v17/dimens.xml diff]

chrome/android/features/autofill_assistant/java/res_poodle/drawable/ic_autofill_assistant_24dp.xml [Renamed from chrome/android/features/autofill_assistant/java/res/drawable/ic_autofill_assistant_24dp.xml - diff

chrome/android/features/autofill_assistant/java/src/org/chromium/chrome/browser/autofill_assistant/header/AnimatedPoodle.java [Added - diff

chrome/android/features/autofill_assistant/java/src/org/chromium/chrome/browser/autofill_assistant/header/AnimatedProgressBar.java diff]

chrome/android/features/autofill_assistant/java/src/org/chromium/chrome/browser/autofill_assistant/header/AssistantHeaderCoordinator.java diff]

chrome/android/features/autofill_assistant/java/src/org/chromium/chrome/browser/autofill_assistant/header/AssistantHeaderModel.java diff]

chrome/android/features/autofill_assistant/java/src/org/chromium/chrome/browser/autofill_assistant/header/AssistantHeaderViewBinder.java diff]

chrome/browser/android/autofill_assistant/ui_controller_android.cc diff]

chrome/browser/android/autofill_assistant/ui_controller_android.h diff]

commit ddd37aac4a78f20325b38da8c50c940de16930b6 author Yi Su <mrsuyi@chromium.org> Mon Mar 25 08:26:16 2019 committer Yi Su <mrsuyi@chromium.org> Mon Mar 25 08:26:16 2019 Fix crash caused by dup-sections in Passwords VC. Currently, activating search bar in PasswordsTableViewController will remove the "save passwords" switch section, and deactivating the search bar will add it back. However, PasswordsTableViewController.loadModel doesn't check the status of search bar when adding switch section, so dup-sections will happen in this scenario: 1. PasswordsTableViewController is inited; 2. Switch section is added in |loadModel|; 3. User activates the search bar; 4. Switch section is removed in |willPresentSearchController|; 5. |onGetPasswordStoreResults| is called, which will call |loadModel|; 6. |loadModel| adds the switch section; 7. User deactivates the search bar; 8. Another switch section is added back in |willDismissSearchController|. And dup switch sections will cause a crash in following steps: 1. User taps "Edit"; 2. User selects the switch item in the second switch section; 3. User taps "Delete". The crash happens because the SettingsSwitchItem will be cast to Passwords SavedFormContentItem, which leads to corrupted memory. Bug: 943649 Change-Id: Ic486886cefb1aceda3a8a986502a8ffb1a34e019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533945 Commit-Queue: Yi Su <mrsuyi@chromium.org> Auto-Submit: Yi Su <mrsuyi@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#643106}(cherry picked from commit 56aa396c1e99ece23b711fb831c5505225b0b1b1) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538076 Reviewed-by: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#408} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} ios/chrome/browser/ui/settings/password/passwords_table_view_controller.mm diff]

commit eb1ecd199361309fa78e77deef0223676ad8425d author chrome-release-bot <chrome-release-bot@chromium.org> Mon Mar 25 06:10:28 2019 committer chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Mon Mar 25 06:10:28 2019 Incrementing VERSION to 74.0.3729.36 TBR=cmasso@chromium.org Change-Id: Icb06a2209c4d8f1afaaa0644345906dd027edb67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537996 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#407} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/VERSION diff]

commit 91d815986b8897eedbd94d7b94c56d166494a440 author chrome-release-bot <chrome-release-bot@chromium.org> Mon Mar 25 00:39:12 2019 committer chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Mon Mar 25 00:39:12 2019 Incrementing VERSION to 74.0.3729.35 TBR=mmoss@chromium.org Change-Id: I291d7b7da3153ce45ecbf3d406c8894e065b11d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537288 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#406} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/VERSION diff]

commit 8c6ee088c72d3e90c8069c445f159671c6cf3452 author chrome-release-bot <chrome-release-bot@chromium.org> Sun Mar 24 06:09:59 2019 committer chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Sun Mar 24 06:09:59 2019 Incrementing VERSION to 74.0.3729.34 TBR=govind@chromium.org Change-Id: Ie550fdc6bd69783e197ab2fd4d3c1eec2db8a2ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537284 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#405} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/VERSION diff]

commit 8614fa5172d617bc39f913f1acf5ad8ec942b7a7 author chrome-release-bot <chrome-release-bot@chromium.org> Sun Mar 24 00:39:06 2019 committer chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Sun Mar 24 00:39:06 2019 Incrementing VERSION to 74.0.3729.33 TBR=govind@chromium.org Change-Id: Ia63f124a2c6e5401db0a5ead29062c8112e19169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537278 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#404} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/VERSION diff]

commit 2627df01492a5f0fc2932475baca04cdc3d9a0da author chrome-release-bot <chrome-release-bot@chromium.org> Sat Mar 23 06:10:51 2019 committer chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Sat Mar 23 06:10:51 2019 Incrementing VERSION to 74.0.3729.32 TBR=abdulsyed@chromiue.org Change-Id: I44a72e3c3afe7923407a841ce10740ca844c8e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536743 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#403} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/VERSION diff]

commit 4fa94f446af47624d4e461bcf82937e24af3bb32 author mrefaat <mrefaat@chromium.org> Sat Mar 23 02:06:12 2019 committer Mohammad Refaat <mrefaat@chromium.org> Sat Mar 23 02:06:12 2019 [Merge to M74]Disable WKHTTPSystemCookieStore by default. It had a negative side effects to search suggestions. See http://crbug/941643 for background Bug: 944819 Change-Id: I7a7e7b812a64c035ed9678eab590d0de2a43ec8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535269 Auto-Submit: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#643477}(cherry picked from commit 5f212add13e4cf404e508a21f9fbb275ffe65bb9) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536687 Cr-Commit-Position: refs/branch-heads/3729@{#402} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} ios/web/features.mm diff]

commit b2ea3b14f0b4f2d1afb563a588352706820af1a1 author Xiaohui Chen <xiaohuic@google.com> Sat Mar 23 01:17:07 2019 committer Xiaohui Chen <xiaohuic@chromium.org> Sat Mar 23 01:17:07 2019 assistant: fix crash in OnTtsStarted Some times |OnTtsStarted| will be called multiple times during a single interction session. This break the previous assumption that Tts is always the last response and causes NPE. Bug: 926303 Test: locally build and test, cannot repro crash with change. Change-Id: Ib97f1ca188236af903dde1c6aa7d6e6c7d6f7b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531304 Reviewed-by: Yue Li <updowndota@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642632}(cherry picked from commit bf3a67f7eab8fad7ed32f5b4c50a488eb1f908e6) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536742 Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#401} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} ash/assistant/assistant_interaction_controller.cc diff]

ash/assistant/ui/main_stage/assistant_main_stage.cc diff]

commit 0ff997addb3c09a4e9dbfe8fe399164d7711f866 author chrome-release-bot <chrome-release-bot@chromium.org> Sat Mar 23 00:40:53 2019 committer chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Sat Mar 23 00:40:53 2019 Incrementing VERSION to 74.0.3729.31 TBR=kariah@chromium.org Change-Id: If57b64f60286aedf4bae394aae405f937ab98098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536738 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#400} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/VERSION diff]

commit 414ade1948867e569cea257ce2f667ed1eed5cb8 author Becca Hughes <beccahughes@chromium.org> Fri Mar 22 22:21:09 2019 committer Becca Hughes <beccahughes@chromium.org> Fri Mar 22 22:21:09 2019 Fix Media.HardwareKeyPressed on CrOS This histogram is not working on Chrome OS. Moves the enum out of //content into //ui so both //content and //ash can depend on it without having it duplicated. Also adds a "PlayPause" action for when we do not know the playback state. BUG=942633 Change-Id: I3e8c895a60edd660cbf3c94426db706fa54b7999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526315 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#643051}(cherry picked from commit 48530c07362c60254cbc527b8815500b87ce4cfb) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536599 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#399} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} ash/accelerators/accelerator_controller_unittest.cc diff]

ash/media/media_controller.cc diff]

ash/media/media_controller.h diff]

content/browser/media/hardware_key_media_controller.cc diff]

content/browser/media/hardware_key_media_controller.h diff]

services/media_session/public/cpp/test/test_media_controller.cc diff]

services/media_session/public/cpp/test/test_media_controller.h diff]

tools/metrics/histograms/enums.xml diff]

ui/base/BUILD.gn diff]

ui/base/accelerators/media_keys_util.cc [Added - diff

ui/base/accelerators/media_keys_util.h [Added - diff

commit e9b2c67f425f9f9b954efe939dbbfc7d14fe1445 author Patrick Noland <pnoland@chromium.org> Fri Mar 22 18:18:37 2019 committer Patrick Noland <pnoland@chromium.org> Fri Mar 22 18:18:37 2019 [Chromeshine] Expire events older than 7 days Bug: 943773 Change-Id: I5229d28a9e748c200e29a3c9ff563d637111a45b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531502 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#643063}(cherry picked from commit 942e195e0577e964e6c7bad096b12f80d495bae1) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536296 Reviewed-by: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#398} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/browser/android/usage_stats/usage_stats_database.cc diff]

chrome/browser/android/usage_stats/usage_stats_database.h diff]

chrome/browser/android/usage_stats/usage_stats_database_unittest.cc diff]

commit 27010ef3419aff0a7a7501d8d0f54dcb2fe9161d author Lukasz Anforowicz <lukasza@chromium.org> Fri Mar 22 18:09:37 2019 committer Łukasz Anforowicz <lukasza@chromium.org> Fri Mar 22 18:09:37 2019 [m74] CORB allowlist additions - 2019-03-20. TBR=lukasza@chromium.org (cherry picked from commit 30a0bd7058f5c68cd129cae01c7607c168625984) Bug: 937081 Change-Id: I7ce20c6bd3c14dcec89d1cb48ead14baea717b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532991 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#643049} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536014 Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#397} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} extensions/browser/url_loader_factory_manager.cc diff]

commit 45285b09ecc32659a7bd87998806abff53a4a6f7 author Antoine Labour <piman@chromium.org> Fri Mar 22 18:00:55 2019 committer Antoine Labour <piman@chromium.org> Fri Mar 22 18:00:55 2019 Allow R_8 and RG_88 buffers to use GL_TEXTURE_2D Bug: 939977 Change-Id: I71bf48b14f8a79c857ec28b782f755163114d4f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529343 Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#641978} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536007 Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#396} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} gpu/command_buffer/common/gpu_memory_buffer_support.cc diff]

commit 9640693a4b49dcee925b3333de8722848020946d author Jun Mukai <mukai@chromium.org> Fri Mar 22 17:21:13 2019 committer Jun Mukai <mukai@chromium.org> Fri Mar 22 17:21:13 2019 Fix on drag_offset for detaching a tab normally crrev.com/c/1532539 accidentally removed a line for calculating drag_offset for the basic detaching flow, which causes the reported regression. This simply revives the line. Also added a few more test cases to verify the offset to make sure this type of regression won't happen anymore. Bug: 944304 Test: interactive_ui_tests Change-Id: I02b500d821fe2fff9d5e38ee7da839af8c9eb64f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533470 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Auto-Submit: Jun Mukai <mukai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642969}(cherry picked from commit f7227898b9f76ea0b2dc54bfad17dd6ce91b1815) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534470 Reviewed-by: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#395} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/browser/ui/views/tabs/tab_drag_controller.cc diff]

chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc diff]

commit a42d281bcabc928f2d5c9d8896044415a258c650 author Robert Flack <flackr@chromium.org> Fri Mar 22 17:19:13 2019 committer Robert Flack <flackr@chromium.org> Fri Mar 22 17:19:13 2019 Remove special behavior for setting timing of transitions. As a result of creating transitions as 2-keyframe animations with a start delay they no longer require special case behavior for updating the timing from devtools. Bug: 935027,935802 Change-Id: I2acd486f9e571aef4a39ebe382c437496f18c99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524427 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#641970}(cherry picked from commit 44e2417f29ed03d9bb4cf317f0068d83a0e3fa5e) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535430 Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#394} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} third_party/blink/renderer/core/inspector/inspector_animation_agent.cc diff]

third_party/blink/web_tests/TestExpectations diff]

commit 4a927d0e5174816744084128b22e3c4fe3c0d5cc author Christopher Cameron <ccameron@chromium.org> Fri Mar 22 17:06:21 2019 committer ccameron <ccameron@chromium.org> Fri Mar 22 17:06:21 2019 MacPWAs: Poll for Chrome's AppShimHostManager to be ready Background: Connecting to Chrome will fail until the function AppShimHostManager::InitOnBackgroundThread in the browser process completes. For this purpose, there current exists a ReplyEventHandler class instantiated in the app shim process that will signal the AppShimController when the Chrome process' event loop has started. This doesn't actually do what we want, because the function AppShimHostManager::InitOnBackgroundThread may or may not have actually run when the event loop starts. Fix: Delete the ReplyEventHandler class. Change AppShimController to take as an argument the NSRunningApplication of the Chrome process to which we will want to connect. Make AppShimController poll (at 100 msec intervals), checking to see - if the NSRunningApplication is still running - if the socket path to which we will connect exists Once the socket path exists, go ahead and try to initialize the mojo connection to Chrome. TBR=ccameron@chromium.org (cherry picked from commit 57fc5fd7ceb150db45afe0c144427c1af3880b61) Bug: 943807 Change-Id: I0dac4d5a9af95396231b6472aeea8972fb7d0a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532906 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642833} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536139 Reviewed-by: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#393} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/app_shim/app_shim_controller.h diff]

chrome/app_shim/app_shim_controller.mm diff]

chrome/app_shim/chrome_main_app_mode_mac.mm diff]

chrome/common/mac/app_mode_common.h diff]

commit 4cc8920111c35ec136cb104157c1a6a137d74a3b author Tommy Steimel <steimel@chromium.org> Fri Mar 22 16:58:14 2019 committer Tommy Steimel <steimel@chromium.org> Fri Mar 22 16:58:14 2019 [Media Controls] Properly handle page zoom when checking doubletap This CL updates the doubletap logic in MediaControlsImpl to take page zoom into account when determining whether a tap was on the left or right side. This fixes an issue where doubletaps on the left side of videos on zoomed pages were sometimes being treated as right-side taps. Bug: 942462 Change-Id: I601fef21f73df7028ca1b495b1a7d4f8a770a8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526803 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#641948}(cherry picked from commit ca01301081170211258500518f854f09cec5c88d) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535427 Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#392} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} third_party/blink/renderer/modules/media_controls/media_controls_impl.cc diff]

third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc diff]

commit a74c9b8660a5abbd7da27c25d13c639741c9007a author Mason Freed <masonfreed@chromium.org> Fri Mar 22 16:14:27 2019 committer Mason Freed <masonfreed@chromium.org> Fri Mar 22 16:14:27 2019 Turn off Clip Rect caching for elements under sticky positioned elements For elements inside sticky positioned containers that were scrolled, the cached clip rect did not previously update the scroll position. That meant that the clip rect did not move with the contents, resulting in incorrect overlap checks in some cases. To fix this, we have to turn off caching for elements inside sticky positioned elements, because in that case the scroll is sometimes included and sometimes not, depending on whether the sticky constraint is binding. Bug: 942097, 931853, 935525 Change-Id: Ibd5810c23c8d92b6047709ed06f832acd4770a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526680 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642524}(cherry picked from commit 5a8df75f6a2eb4ae3b97a0ddc31720d1b8f846a3) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535010 Reviewed-by: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#391} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.cc diff]

third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.h diff]

third_party/blink/renderer/core/paint/paint_layer.h diff]

third_party/blink/renderer/core/paint/paint_layer_clipper_test.cc diff]

third_party/blink/web_tests/external/wpt/css/css-position/position-sticky-scroll-with-clip-and-abspos-ref.html [Added - diff

third_party/blink/web_tests/external/wpt/css/css-position/position-sticky-scroll-with-clip-and-abspos.html [Added - diff

commit 87171c88dffcf86f847d3c10544144cb9f4a6690 author Evan Stade <estade@chromium.org> Fri Mar 22 15:25:21 2019 committer Evan Stade <estade@chromium.org> Fri Mar 22 15:25:21 2019 Update task manager icon in shelf when kAppIconLargeKey changes. Bug: 943775 Change-Id: Ic72893c1be5cdc815e14566bb6da942f1a4a1625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532897 Commit-Queue: Evan Stade <estade@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642723}(cherry picked from commit 7443c7ae7c3c71ae22237744f12c0f57a9f71515) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534555 Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#390} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} ash/shelf/shelf_window_watcher.cc diff]

commit 6964f5d2510b9cc4872dbdcd0703134a7232625c author David Roger <droger@chromium.org> Fri Mar 22 14:46:19 2019 committer David Roger <droger@chromium.org> Fri Mar 22 14:46:19 2019 [signin] Dont create AccountConsistencyModeManager for guest sessions This was causing a crash because AccountConsistencyModeManager CHECKS that the account consistency mode doesn't change after initialization. However, the guest session changes the kSigninAllowed preference after startup, which causes the account consistency mode to change. TBR=droger@chromium.org (cherry picked from commit 172253bbbf57074f652b3856b2640f2a66774a34) Bug: 940026 Change-Id: I3e37c4facd70151d03afea1765a288269c3bc8d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526020 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#641595} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535869 Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#389} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/browser/signin/account_consistency_mode_manager.cc diff]

chrome/browser/signin/account_consistency_mode_manager.h diff]

chrome/browser/signin/account_consistency_mode_manager_factory.cc diff]

chrome/browser/signin/account_consistency_mode_manager_unittest.cc diff]

commit 48a2d1551ee7c93e628f875bf00fa23bafb389ce author Yutaka Hirano <yhirano@chromium.org> Fri Mar 22 13:17:02 2019 committer Yutaka Hirano <yhirano@chromium.org> Fri Mar 22 13:17:02 2019 Support sending all request and response headers to webRequest for websockets with network service. Since this incurs a performance overhead of extra process hops, only do it if extraHeaders is specified. TBR=jam@chromium.org (cherry picked from commit f8ee72281ece4c3a3a2d648174bd94600f25a9dd) Bug: 937852 Change-Id: I5db329c5eaf8781bef418b64afc5f0ab1c0c18f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517144 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#641070} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536037 Cr-Commit-Position: refs/branch-heads/3729@{#388} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/browser/chrome_content_browser_client.cc diff]

chrome/browser/chrome_content_browser_client.h diff]

chrome/browser/extensions/api/web_request/web_request_apitest.cc diff]

chrome/test/data/extensions/api_test/webrequest/framework.js diff]

chrome/test/data/extensions/api_test/webrequest/test_extra_headers.js diff]

chrome/test/data/extensions/api_test/webrequest/test_websocket.js diff]

content/browser/frame_host/render_frame_host_impl.cc diff]

content/browser/renderer_interface_binders.cc diff]

content/browser/websockets/websocket_manager.cc diff]

content/browser/websockets/websocket_manager.h diff]

content/browser/websockets/websocket_manager_unittest.cc diff]

content/browser/worker_host/dedicated_worker_host.cc diff]

content/public/browser/content_browser_client.cc diff]

content/public/browser/content_browser_client.h diff]

extensions/browser/api/web_request/web_request_api.cc diff]

extensions/browser/api/web_request/web_request_api.h diff]

extensions/browser/api/web_request/web_request_proxying_websocket.cc diff]

extensions/browser/api/web_request/web_request_proxying_websocket.h diff]

services/network/network_context.cc diff]

services/network/network_context.h diff]

services/network/network_service_network_delegate.cc diff]

services/network/public/mojom/network_context.mojom diff]

services/network/test/test_network_context.h diff]

services/network/websocket.cc diff]

services/network/websocket.h diff]

services/network/websocket_factory.cc diff]

services/network/websocket_factory.h diff]

commit cb50c1e94e7a86003d667f309b6c3cf0bc9c2406 author Jan Krcal <jkrcal@chromium.org> Fri Mar 22 10:05:11 2019 committer Jan Krcal <jkrcal@chromium.org> Fri Mar 22 10:05:11 2019 [AF Profile] Unify model data <-> specifics conversion with Directory This CL removes the additional smartness of the autofill_profile sync bridge and adapts closer to the logic of the syncable service. It is still not cut&paste as this would need more refactoring (to code that is arguably harder to reason about). This CL still leaves around one difference: the syncable service does trim strings as if they were ASCII which may result in incorrect UTF8 strings; the bridge fixes this issue and treats the strings as UTF8. Apart from that, there should be no functional differences. There is a hope that this could reduce inconsistencies in observed autofill_profile sync traffic between USS and Directory. Bug: 904390 Change-Id: Ie5448e0991d56ee435a31c62178c50d2c729d692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520505 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#641182}(cherry picked from commit ededf16bac4fd6a9176c2f3a6f5e3b058e26e2d8) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533953 Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#387} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} components/autofill/core/browser/autofill_profile_sync_util.cc diff]

components/autofill/core/browser/autofill_profile_sync_util_unittest.cc diff]

commit 9c2e0397f1ae0477b0939d0381138ab784ce8c15 author Jan Krcal <jkrcal@chromium.org> Fri Mar 22 10:04:51 2019 committer Jan Krcal <jkrcal@chromium.org> Fri Mar 22 10:04:51 2019 [Sync] Report Sync.ModelTypeRedundantPut in Directory as well This CL adds recording of Sync.ModelTypeRedundantPut to the Directory code path. Even though it changes an existing metric, it does it in a 0/1 way and only for specific buckets (for Directory data types) so it is safe not to rename the metric. Bug: 904390 Change-Id: I8f681d6f48c7c09d5647184cd56bc092dba30303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521347 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#640725}(cherry picked from commit a294d0f5108dd2c40e6871a5171d467e460b8366) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533912 Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#386} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} components/sync/syncable/nigori_util.cc diff]

commit e0e34529f4e9e274def87de0c96044d136e974a4 author Rune Lillesveen <futhark@chromium.org> Fri Mar 22 09:27:01 2019 committer Rune Lillesveen <futhark@chromium.org> Fri Mar 22 09:27:01 2019 Some elements in SVG need LayoutObjects for display:none. Check that we don't create layout objects for ComputedStyle ensured in display:none instead. TEST=fast/css/reattach-ensured-in-display-none-crash.html Bug: 942950 Change-Id: I5b89b9a1fe6a3edcfdd57fa96a426b8db79ded33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532105 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642860}(cherry picked from commit b9a5063b902318396b3ec176c5ee2e105573c636) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533909 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#385} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} third_party/blink/renderer/core/dom/element.cc diff]

commit 951916a34e06c3b3057d2beb0e06f5f538d15d3f author Khushal <khushalsagar@chromium.org> Fri Mar 22 07:11:05 2019 committer Khushal <khushalsagar@chromium.org> Fri Mar 22 07:11:05 2019 android/surface_control: Add usage flag required for use with HwC. Hardware composer requires buffers to have a flag set if they are going to be used as overlays. The framework currently sets it for buffers it creates internally. Make sure to also set it for buffers allocated by Chrome used with the SurfaceControl API. R=​liberato@chromium.org, piman@chromium.org Bug: 943706 Change-Id: I9677c4833cf711ead8e5467e64a395d3c2ae56e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529408 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642839}(cherry picked from commit ce6e4f826db085536ccc424ad314d76b6cdce815) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535736 Reviewed-by: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#384} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} gpu/ipc/common/gpu_memory_buffer_impl_android_hardware_buffer.cc diff]

media/gpu/android/image_reader_gl_owner.cc diff]

ui/gl/android/android_surface_control_compat.cc diff]

ui/gl/android/android_surface_control_compat.h diff]

commit 41d0e1aad77add106f3c8ba1a7e38af34b0c95b0 author chrome-release-bot <chrome-release-bot@chromium.org> Fri Mar 22 06:11:42 2019 committer chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Fri Mar 22 06:11:42 2019 Incrementing VERSION to 74.0.3729.30 TBR=mmoss@chromium.org Change-Id: Ibbdf52e15ce0c1f66ddcefe97d04cada65d11df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534894 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#383} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/VERSION diff]

commit d4936c776bea3353eb30c16abeee50baa953761a author Sammie Quon <sammiequon@google.com> Fri Mar 22 03:16:18 2019 committer Sammie Quon <sammiequon@chromium.org> Fri Mar 22 03:16:18 2019 [merge to 74] overview: Do not animate minimized window behind maximized window. If there is a maximized window on top the minimized windows should just already be there when entering instead of fading in. Uses the same logic as the transforming windows which are behind a maximized window by delaying the opacity setting until that logic is calculated. TBR=sammiequon@google.com (cherry picked from commit 39b4b42200ccb2138388f3c53d7b9f69bbf979f8) Test: manual Bug: 941823 Change-Id: Idc7386bccefe5c0a9aa849e3c2213d628264afc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525051 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642570} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535345 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#382} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} ash/wm/overview/overview_item.cc diff]

ash/wm/overview/scoped_overview_transform_window.cc diff]

ash/wm/overview/scoped_overview_transform_window.h diff]

commit 8c8fb6285e7914294193255fffb510889659bdf6 author Eric Karl <ericrk@chromium.org> Fri Mar 22 02:16:55 2019 committer Eric Karl <ericrk@chromium.org> Fri Mar 22 02:16:55 2019 Allow one undrawn frame in ShouldSendBeginFrame If the renderer ever takes longer than the display deadline to submit a frame, the previous logic would cause us to throttle one renderer frame, leading to additional jank. While this does allow for some "catch-up", we've seen cases where this throttling can happen multiple times in a short period (<1s). In these cases the throttling just adds additional jank. Bug: 935630 Change-Id: I7c2c6d562ee91fbae316185e9e54385a1eebfc08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521967 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by: Saman Sami <samans@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642186}(cherry picked from commit 7e8de286791aebfd73ee3bdaff8178f130354362) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535418 Reviewed-by: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#381} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} components/viz/service/display/display_unittest.cc diff]

components/viz/service/frame_sinks/compositor_frame_sink_support.cc diff]

components/viz/service/frame_sinks/compositor_frame_sink_support.h diff]

components/viz/service/surfaces/surface.cc diff]

components/viz/service/surfaces/surface_client.h diff]

commit 9f2b1e1aa4bd2f23121c051630f42409cd38c6d7 author Eric Karl <ericrk@chromium.org> Fri Mar 22 02:13:41 2019 committer Eric Karl <ericrk@chromium.org> Fri Mar 22 02:13:41 2019 Disable browser latency recovery for Viz on Android We disabled this for the renderer in M73/M74. We missed the browser component. Making these uniform. Bug: 943186, 933846 Change-Id: I5098aca0189a66c3ce05df6c108af39cd2ca3fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528915 Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642187}(cherry picked from commit 75cd895ed4002b08ee94eedb8b31a437503e6455) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535417 Reviewed-by: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#380} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} content/browser/renderer_host/compositor_impl_android.cc diff]

content/renderer/render_widget.cc diff]

commit a3e42dd68df3b9530a76e1bcad26e589c2144ae3 author Jay Harris <harrisjay@chromium.org> Fri Mar 22 01:50:38 2019 committer Jay Harris <harrisjay@chromium.org> Fri Mar 22 01:50:38 2019 Forces URL directionality for custom tab bar location. This is a security UX improvement for RTL domains. Before this change http://مثال.com/ would be displayed as com.مثال instead of مثال.com Bug: 943362, 943366 Change-Id: I967216bb402b12dc437e05274ff8ea63e1544f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529975 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642348}(cherry picked from commit cdf2537f6d90d90c7c9ceff96e94b8fdf6275fa5) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534900 Reviewed-by: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#379} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/browser/ui/views/location_bar/custom_tab_bar_view.cc diff]

ui/views/controls/label.cc diff]

ui/views/controls/label.h diff]

commit 866a63e4343c23feb91b1bc1d3ec5b32d316b9a8 author yoshiki iguchi <yoshiki@chromium.org> Fri Mar 22 01:39:07 2019 committer Yoshiki Iguchi <yoshiki@chromium.org> Fri Mar 22 01:39:07 2019 Disable lock screen notification We have decided not to ship this at least for M74, so this CL disables it by default. I will merge this to the M74 branch as well. R=​​tengs@chromium.org CC=​​tetsui@chromium.org, sarakato@chromium.org TBR=oshima@chromium.org Bug: 943423 Change-Id: Iad61f219b2b4f9b5f2561b68ddeb28a9dadb3266 Test: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530213 Reviewed-by: Tim Song <tengs@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Auto-Submit: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#641818}(cherry picked from commit d824c424bbf0a68d406a938d4ea91c8bf3cf9e93) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534899 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#378} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} ash/public/cpp/ash_features.cc diff]

commit 4b4bf186c3e95d5eaf6298c5da3d1f48e877fc55 author Yue Li <updowndota@chromium.org> Fri Mar 22 01:18:22 2019 committer Yue Li <updowndota@chromium.org> Fri Mar 22 01:18:22 2019 Revert "Allow R_8 and RG_88 buffers to use GL_TEXTURE_2D" This reverts commit ebaf1b2068b8160baee25a3673aed7622492c590. Reason for revert: change contains conflict marker Original change's description: > Allow R_8 and RG_88 buffers to use GL_TEXTURE_2D > > Bug: 939977 > Change-Id: Ica5225b4dc276cb2d45681d4f8eb221804441887 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529343 > Auto-Submit: Antoine Labour <piman@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#641978}(cherry picked from commit 8bbaff7e8f8780c9179415ba72c851d434984ea2) > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534265 > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/branch-heads/3729@{#342} > Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} TBR=piman@chromium.org Change-Id: I93c99372331f52d0704bd3848330b67370623994 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 939977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535340 Reviewed-by: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#377} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} gpu/command_buffer/common/gpu_memory_buffer_support.cc diff]

commit 0b2df9172c42218e4a9a0bb9059b465ac1fba4fe author chrome-release-bot <chrome-release-bot@chromium.org> Fri Mar 22 00:48:48 2019 committer chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Fri Mar 22 00:48:48 2019 Incrementing VERSION to 74.0.3729.29 TBR=benmason@chromium.org Change-Id: I6b0b4d9212b3ec8d9a0787d8178da50c9f510221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535268 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#376} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/VERSION diff]

commit ef4412ebbba4652b4cd78c793c81e896200d3e22 author Meilin Wang <meilinw@google.com> Fri Mar 22 00:42:38 2019 committer Yue Li <updowndota@chromium.org> Fri Mar 22 00:42:38 2019 assistant: fix autotest/tast tests failed due to service disallowed. Tests failed because assistant was disallowed by account type for the following reasons: - Autotest with real gaia login: Caused by a race between chromeos login finished and account info fetch finished. - Tast with fake gaia login: Account info fetch not be faked under fake gaia env. This changes fixes these issues by first retry to initiate assistant when account info updated, and also bypass the account type check in assistant::IsAssistantAllowedForProfile under fake gaia env. Misc: Add IsGaiaServicesDisabled helper function in chromeos_swithes. Bug: 942781, 939146, 940618 Test: local compile and run autotest/tast tests on DUT. Change-Id: I25bdcda9587988426745c2dd036da1b8be6f636a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530119 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#642370}(cherry picked from commit fc5df617da765bb5faafa924628d5a8f7afc4211) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535267 Reviewed-by: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#375} Cr-Branched-From: d4a8972e30b604f090aeda5dfff68386ae656267-refs/heads/master@{#638880} chrome/browser/chromeos/assistant/assistant_util.cc diff]

chrome/browser/ui/ash/assistant/assistant_client.cc diff]

chrome/browser/ui/ash/assistant/assistant_client.h diff]

chromeos/constants/chromeos_switches.cc diff]

chromeos/constants/chromeos_switches.h diff]

commit 9e72219d74b2100eaa11b4706d651a880fcefa48 author Xianzhu Wang <wangxianzhu@chromium.org> Fri Mar 22 00:38:57 2019 committer Xianzhu Wang <wangxianzhu@chromium.org> Fri Mar 22 00:38:57 2019 Revert the latest BlinkGenPropertyTree animation changes in M74 We landed some BGPT animation changes before the M74 branch. Some of them may accidentally affected non-BGPT path, and I suspect that they caused crbug.com/939342. This reverts the following CLs. The first one is the most suspectible, and we have to revert the others because they depend on the first one. - Simplify paint property change during building commit b9c9d1266bcb8acd4d24873105edc12de9721e71. - [BlinkGenPropertyTrees] Create render surface for composited effect animations commit 7ea5df4c9f