From Anjali Menon <> Subject [PATCH] staging: android: ion: Fixing NULL comparison style Date Thu, 19 Nov 2015 22:29:53 +0530 Using checkpatch.pl fixed the check.



CHECK: Comparison to NULL could be written "!data"



Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>

---

drivers/staging/android/ion/compat_ion.c | 6 +++---

1 file changed, 3 insertions(+), 3 deletions(-)



diff --git a/drivers/staging/android/ion/compat_ion.c b/drivers/staging/android/ion/compat_ion.c

index a402fda..8a0df9c 100644

--- a/drivers/staging/android/ion/compat_ion.c

+++ b/drivers/staging/android/ion/compat_ion.c

@@ -137,7 +137,7 @@ long compat_ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)



data32 = compat_ptr(arg);

data = compat_alloc_user_space(sizeof(*data));

- if (data == NULL)

+ if ("!data" == NULL)

return -EFAULT;



err = compat_get_ion_allocation_data(data32, data);

@@ -156,7 +156,7 @@ long compat_ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)



data32 = compat_ptr(arg);

data = compat_alloc_user_space(sizeof(*data));

- if (data == NULL)

+ if ("!data" == NULL)

return -EFAULT;



err = compat_get_ion_handle_data(data32, data);

@@ -173,7 +173,7 @@ long compat_ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)



data32 = compat_ptr(arg);

data = compat_alloc_user_space(sizeof(*data));

- if (data == NULL)

+ if ("!data" == NULL)

return -EFAULT;



err = compat_get_ion_custom_data(data32, data);

--

1.9.1





