commit ce3949892ee5288d802a78ebaa3800ba639501a5 55.0.2883.103 author chrome-cron <chrome-cron@google.com> Sat Dec 17 08:10:37 2016 committer chrome-cron <chrome-cron@google.com> Sat Dec 17 08:10:37 2016 Publish DEPS for Chromium 55.0.2883.103 DEPS diff]

commit 177b2935255c8e5de6c040c4f05e506b8b677921 author chrome-cron <chrome-cron@google.com> Sat Dec 17 08:06:02 2016 committer chrome-cron <chrome-cron@google.com> Sat Dec 17 08:09:54 2016 Incrementing VERSION to 55.0.2883.103 Cr-Commit-Position: refs/branch-heads/2883@{#752} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 91d57fa12796786826fa7830fb3e44ee90203f6f author Evan Stade <estade@chromium.org> Sat Dec 17 06:07:30 2016 committer Evan Stade <estade@chromium.org> Sat Dec 17 06:10:59 2016 Fix bad merge conflict resolution from m55 merge of IME window fix. BUG=664363 Review-Url: https://codereview.chromium.org/2586013002 . Cr-Commit-Position: refs/branch-heads/2883@{#751} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} ui/chromeos/ime/candidate_window_view.cc diff]

commit d8732ebaad292e59df55076a733beb409e82c76d author chrome-cron <chrome-cron@google.com> Sat Dec 17 02:01:15 2016 committer chrome-cron <chrome-cron@google.com> Sat Dec 17 02:04:45 2016 Incrementing VERSION to 55.0.2883.102 Cr-Commit-Position: refs/branch-heads/2883@{#750} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 0b341d07447b54af13dc9f93c7262f0779ebd16e author chrome-cron <chrome-cron@google.com> Sat Dec 17 01:11:11 2016 committer chrome-cron <chrome-cron@google.com> Sat Dec 17 01:17:00 2016 Incrementing VERSION to 55.0.2883.101 Cr-Commit-Position: refs/branch-heads/2883@{#749} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 1272d7976b721df4664bb5a0aa3c1fc0b4a591e2 author Evan Stade <estade@chromium.org> Sat Dec 17 00:13:45 2016 committer Evan Stade <estade@chromium.org> Sat Dec 17 00:17:53 2016 Fix background opacity/color of IME candidate window. BUG=664363 Review-Url: https://codereview.chromium.org/2502023002 Cr-Commit-Position: refs/heads/master@{#432716} (cherry picked from commit 2cb96143d90df932a11e9a21e6983f4631796008) Review-Url: https://codereview.chromium.org/2584013003 . Cr-Commit-Position: refs/branch-heads/2883@{#748} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} ui/chromeos/ime/candidate_window_view.cc diff]

commit 02e6bde1bbe34e43b309d4ef774b1168d25fd024 author chrome-cron <chrome-cron@google.com> Fri Dec 16 02:01:11 2016 committer chrome-cron <chrome-cron@google.com> Fri Dec 16 02:04:42 2016 Incrementing VERSION to 55.0.2883.100 Cr-Commit-Position: refs/branch-heads/2883@{#747} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 0a40516b6c5c551847bd7be2505931a085af82b8 author chrome-cron <chrome-cron@google.com> Thu Dec 15 02:01:15 2016 committer chrome-cron <chrome-cron@google.com> Thu Dec 15 02:04:14 2016 Incrementing VERSION to 55.0.2883.99 Cr-Commit-Position: refs/branch-heads/2883@{#746} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit fce2113643dbabe51ad6825c974c40dbfbaed139 author chrome-cron <chrome-cron@google.com> Wed Dec 14 02:01:25 2016 committer chrome-cron <chrome-cron@google.com> Wed Dec 14 02:04:51 2016 Incrementing VERSION to 55.0.2883.98 Cr-Commit-Position: refs/branch-heads/2883@{#745} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit c218af4c2c5b84b46d11182542fcef32f5c0a578 author chrome-cron <chrome-cron@google.com> Wed Dec 14 01:26:09 2016 committer chrome-cron <chrome-cron@google.com> Wed Dec 14 01:31:20 2016 Incrementing VERSION to 55.0.2883.97 Cr-Commit-Position: refs/branch-heads/2883@{#744} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 3992d8758269d26ad8e40b37ef6702deca3b8e2f author Will Harris <wfh@chromium.org> Tue Dec 13 22:41:02 2016 committer Will Harris <wfh@chromium.org> Tue Dec 13 22:44:54 2016 Merge M55: Revert of Annotate Trusteer Rapport < 3.6 as incompatible with Chrome. (patchset #1 id:1 of https://codereview.chromium.org/2566733003/ ) Reason for revert: These issues have been resolved in the latest update from Trusteer. Original issue's description: > Annotate Trusteer Rapport < 3.6 as incompatible with Chrome. > > BUG=671194 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng > TEST=manual, install Trusteer Rapport, verify dialog appears. > > Committed: https://crrev.com/07a5425d95dc96b3d0a3bd8acad943cf0f4cd2fb > Cr-Commit-Position: refs/heads/master@{#437729} TBR=chrisha@chromium.org,jschuh@chromium.org,finnur@chromium.org,pmonette@chromium.org BUG=671194 Review-Url: https://codereview.chromium.org/2577533002 Cr-Commit-Position: refs/heads/master@{#438293} (cherry picked from commit b17b3a185ede96b5654f5ece8d19ee4f070d96ce) CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review URL: https://codereview.chromium.org/2569353002 . Cr-Commit-Position: refs/branch-heads/2883@{#743} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/browser/win/enumerate_modules_model.cc diff]

chrome/browser/win/enumerate_modules_model.h diff]

commit 5ed517dba15ee92f6c2beb38243821b8ff3101ee author Reilly Grant <reillyg@chromium.org> Tue Dec 13 17:28:38 2016 committer Reilly Grant <reillyg@chromium.org> Tue Dec 13 17:35:12 2016 Fix initial USB enumeration on Linux to return all devices. This patch fixes an issue where the first enumeration of USB devices on Linux would only return a single device and observers would not be notified of additional devices. This was because the logic to determine if enumeration callbacks should be called was checking only that all previously seen devices (of which there was only one at that point) were ready and not that the sysfs tree had been completely walked. BUG=662486 Review-Url: https://codereview.chromium.org/2523403002 Cr-Commit-Position: refs/heads/master@{#434718} (cherry picked from commit 5c30282c70ec5f7f92129589fbbc84fef5738454) Review URL: https://codereview.chromium.org/2534213002 . Cr-Commit-Position: refs/branch-heads/2924@{#166} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} (cherry picked from commit d26a894642fb6aca8c30b25753372d6814fbcb4e) Review-Url: https://codereview.chromium.org/2567253004 . Cr-Commit-Position: refs/branch-heads/2883@{#742} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} device/usb/usb_service_linux.cc diff]

commit 17bc960ab9d9cfbf841a39c37d510b4c464174cc author estade <estade@chromium.org> Tue Dec 13 16:51:12 2016 committer Commit bot <commit-bot@chromium.org> Tue Dec 13 16:55:17 2016 Fix IME tray bubble (and other tray bubble views). This was broken by 17ab8262e8e13c1ace5 which stopped explicitly painting a background for bubble contents views. The symptom I observed is a black background (due to the layer being opaque and painting nothing). This should also fix the subpixel text corruption shown in the bug. BUG=660510 TBR=msw@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2485793002 Cr-Commit-Position: refs/heads/master@{#430500} (cherry picked from commit 03f052fcaf93364ce2136172b91137793e4f3458) Review-Url: https://codereview.chromium.org/2573823002 Cr-Commit-Position: refs/branch-heads/2883@{#741} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} ui/views/bubble/bubble_dialog_delegate.cc diff]

commit 68c6bc8ddf9d89cbd3dd8cec6d76cce047413ac3 author Evan Stade <estade@chromium.org> Tue Dec 13 16:13:10 2016 committer Evan Stade <estade@chromium.org> Tue Dec 13 16:18:09 2016 CrOS - Fix text background of shelf tooltips. BUG=660510 Review-Url: https://codereview.chromium.org/2460103002 Cr-Commit-Position: refs/heads/master@{#428719} (cherry picked from commit 17ab8262e8e13c1ace5b8270dbf71a3c7af6a7aa) Review-Url: https://codereview.chromium.org/2573813002 . Cr-Commit-Position: refs/branch-heads/2883@{#740} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} ash/common/shelf/shelf_tooltip_manager.cc diff]

ui/views/bubble/bubble_dialog_delegate.cc diff]

commit 7f839202f8bd3e941010a77c7e545913aad305f7 author chrome-cron <chrome-cron@google.com> Tue Dec 13 02:01:13 2016 committer chrome-cron <chrome-cron@google.com> Tue Dec 13 02:06:35 2016 Incrementing VERSION to 55.0.2883.96 Cr-Commit-Position: refs/branch-heads/2883@{#739} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit a97b1aab33877677c4734c58ed41246aa40942b7 author chrome-cron <chrome-cron@google.com> Tue Dec 13 01:31:11 2016 committer chrome-cron <chrome-cron@google.com> Tue Dec 13 01:35:39 2016 Incrementing VERSION to 55.0.2883.95 Cr-Commit-Position: refs/branch-heads/2883@{#738} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit ce6d9b1629e62797a0ca87710a57dfeead28a84d author ekaramad <ekaramad@chromium.org> Tue Dec 13 01:06:50 2016 committer Commit bot <commit-bot@chromium.org> Tue Dec 13 01:12:35 2016 Fix renderer crashes due to non-existing RenderFrameImpl or WebFrameWidget during Navigations (Merge to M-55) When navigating the main frame, the RenderViewImpl lingers around with no WebFrameWidget. This yields a WebViewImpl in a call to RenderWidget::GetWebWidget(). When user interactions leads to an IME IPC for FirstRectForCharacterRange, the IPC migth arrive during the navigation and lead to an invalid cast in TextInputClientObserver::GetFocusedFrame(). This CL will avoid those casts by explicitly verifying that the WebWidget returned from GetWebWidget() is a WebFrameWidget. Also, the IPC handling in TextInputClientObserver is modified such that it now considers the possibilities of nullptr outputs from GetFocusedFrame() and GetWebFrameWidget(). BUG=664890 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2526563004 Cr-Commit-Position: refs/heads/master@{#434302} (cherry picked from commit 95df18c257f410cff287f0b402dd50b3014c7784) Review-Url: https://codereview.chromium.org/2568233004 Cr-Commit-Position: refs/branch-heads/2883@{#737} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} content/renderer/text_input_client_observer.cc diff]

commit 2d70a1ec9a61c5a4249ceb093934890e2de11113 author chrome-cron <chrome-cron@google.com> Mon Dec 12 02:02:58 2016 committer chrome-cron <chrome-cron@google.com> Mon Dec 12 02:06:23 2016 Incrementing VERSION to 55.0.2883.94 Cr-Commit-Position: refs/branch-heads/2883@{#736} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit f9b9c11ab3f19b0e5e092774133d347747934bef author chrome-cron <chrome-cron@google.com> Sun Dec 11 02:01:07 2016 committer chrome-cron <chrome-cron@google.com> Sun Dec 11 02:06:03 2016 Incrementing VERSION to 55.0.2883.93 Cr-Commit-Position: refs/branch-heads/2883@{#735} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 80f677bbae431925b07c329adcd36a6fae486dfa author Will Harris <wfh@chromium.org> Sat Dec 10 20:56:56 2016 committer Will Harris <wfh@chromium.org> Sat Dec 10 21:01:14 2016 Merge M55: Annotate Trusteer Rapport < 3.6 as incompatible with Chrome. BUG=671194 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng TEST=manual, install Trusteer Rapport, verify dialog appears. Review-Url: https://codereview.chromium.org/2566733003 Cr-Commit-Position: refs/heads/master@{#437729} (cherry picked from commit 07a5425d95dc96b3d0a3bd8acad943cf0f4cd2fb) Review URL: https://codereview.chromium.org/2564273002 . Cr-Commit-Position: refs/branch-heads/2883@{#734} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/browser/win/enumerate_modules_model.cc diff]

chrome/browser/win/enumerate_modules_model.h diff]

commit 841b9a58130b84a3816d42023b714a2127e1e56f author chrome-cron <chrome-cron@google.com> Sat Dec 10 02:01:09 2016 committer chrome-cron <chrome-cron@google.com> Sat Dec 10 02:08:01 2016 Incrementing VERSION to 55.0.2883.92 Cr-Commit-Position: refs/branch-heads/2883@{#733} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 733808abc67b7fce93430fcb00127707bffe4639 author chrome-cron <chrome-cron@google.com> Fri Dec 09 15:36:01 2016 committer chrome-cron <chrome-cron@google.com> Fri Dec 09 15:41:01 2016 Incrementing VERSION to 55.0.2883.91 Cr-Commit-Position: refs/branch-heads/2883@{#732} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit a38f6d5fb4ca186b9e682cd11e1fc87d2014e00c author Torne (Richard Coles) <torne@chromium.org> Fri Dec 09 12:22:28 2016 committer Torne (Richard Coles) <torne@chromium.org> Fri Dec 09 12:26:26 2016 android: Realign stack pointer on JNI entry. Dalvik JIT generated code doesn't always align the stack to a 16 byte boundary when calling into native, causing crashes in code that expects 16 byte alignment. Force the compiler to realign the stack when entering native from Java, so that other code can assume 16 byte alignment as expected by the ABI. Move the function attributes into a macro so that the generated header file is less repetitive (this also makes the generator less repetitive as a bonus). Also, to stop presubmit complaining about golden_sample_for_tests_jni.h not being correctly clang-formatted, rename it to .golden like the other test files. BUG=655248 Review-Url: https://codereview.chromium.org/2531273002 Cr-Commit-Position: refs/heads/master@{#435632} (cherry picked from commit 7be1137994eecca6c54831e4c3d3d4f934ea8602) R=rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2565723002 . Cr-Commit-Position: refs/branch-heads/2883@{#731} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} base/android/jni_generator/BUILD.gn diff]

base/android/jni_generator/SampleForTests_jni.golden [Renamed from base/android/jni_generator/golden_sample_for_tests_jni.h - diff

base/android/jni_generator/jni_generator.py diff]

base/android/jni_generator/jni_generator_helper.h diff]

base/android/jni_generator/jni_generator_tests.py diff]

base/android/jni_generator/testInnerClassNatives.golden diff]

base/android/jni_generator/testInnerClassNativesBothInnerAndOuter.golden diff]

base/android/jni_generator/testInnerClassNativesMultiple.golden diff]

base/android/jni_generator/testMultipleJNIAdditionalImport.golden diff]

base/android/jni_generator/testNativeExportsOnlyOption.golden diff]

base/android/jni_generator/testNatives.golden diff]

base/android/jni_generator/testNativesLong.golden diff]

base/android/jni_generator/testSingleJNIAdditionalImport.golden diff]

commit 366e9038733510ba1e448b056870d55a1b5d11a5 author Alex Mineer <amineer@chromium.org> Fri Dec 09 05:10:25 2016 committer Alex Mineer <amineer@chromium.org> Fri Dec 09 05:15:38 2016 android: Realign stack pointer on JNI entry. M55 merge Dalvik JIT generated code doesn't always align the stack to a 16 byte boundary when calling into native, causing crashes in code that expects 16 byte alignment. Force the compiler to realign the stack when entering native from Java, so that other code can assume 16 byte alignment as expected by the ABI. Move the function attributes into a macro so that the generated header file is less repetitive (this also makes the generator less repetitive as a bonus). Also, to stop presubmit complaining about golden_sample_for_tests_jni.h not being correctly clang-formatted, rename it to .golden like the other test files. BUG=655248,672670 Review-Url: https://codereview.chromium.org/2531273002 Cr-Commit-Position: refs/heads/master@{#435632} (cherry picked from commit 7be1137994eecca6c54831e4c3d3d4f934ea8602) Review URL: https://codereview.chromium.org/2556723008 . Committed: https://chromium.googlesource.com/chromium/src/+/01a46f06cc1a85d62abd4fd83e13ff3c07c91262 Cr-Commit-Position: refs/branch-heads/2883@{#730} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} base/android/jni_generator/BUILD.gn diff]

base/android/jni_generator/golden_sample_for_tests_jni.h [Renamed from base/android/jni_generator/SampleForTests_jni.golden - diff

base/android/jni_generator/jni_generator.py diff]

base/android/jni_generator/jni_generator_helper.h diff]

base/android/jni_generator/jni_generator_tests.py diff]

base/android/jni_generator/testInnerClassNatives.golden diff]

base/android/jni_generator/testInnerClassNativesBothInnerAndOuter.golden diff]

base/android/jni_generator/testInnerClassNativesMultiple.golden diff]

base/android/jni_generator/testMultipleJNIAdditionalImport.golden diff]

base/android/jni_generator/testNativeExportsOnlyOption.golden diff]

base/android/jni_generator/testNatives.golden diff]

base/android/jni_generator/testNativesLong.golden diff]

base/android/jni_generator/testSingleJNIAdditionalImport.golden diff]

commit 6e8313239c14758359535f0c4a226fcf321197e5 author chrome-cron <chrome-cron@google.com> Fri Dec 09 03:36:14 2016 committer chrome-cron <chrome-cron@google.com> Fri Dec 09 03:41:26 2016 Incrementing VERSION to 55.0.2883.90 Cr-Commit-Position: refs/branch-heads/2883@{#729} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 01a46f06cc1a85d62abd4fd83e13ff3c07c91262 author Alex Mineer <amineer@chromium.org> Fri Dec 09 03:17:50 2016 committer Alex Mineer <amineer@chromium.org> Fri Dec 09 03:22:49 2016 android: Realign stack pointer on JNI entry. M55 merge Dalvik JIT generated code doesn't always align the stack to a 16 byte boundary when calling into native, causing crashes in code that expects 16 byte alignment. Force the compiler to realign the stack when entering native from Java, so that other code can assume 16 byte alignment as expected by the ABI. Move the function attributes into a macro so that the generated header file is less repetitive (this also makes the generator less repetitive as a bonus). Also, to stop presubmit complaining about golden_sample_for_tests_jni.h not being correctly clang-formatted, rename it to .golden like the other test files. BUG=655248,672670 Review-Url: https://codereview.chromium.org/2531273002 Cr-Commit-Position: refs/heads/master@{#435632} (cherry picked from commit 7be1137994eecca6c54831e4c3d3d4f934ea8602) Review URL: https://codereview.chromium.org/2556723008 . Cr-Commit-Position: refs/branch-heads/2883@{#728} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} base/android/jni_generator/BUILD.gn diff]

base/android/jni_generator/SampleForTests_jni.golden [Renamed from base/android/jni_generator/golden_sample_for_tests_jni.h - diff

base/android/jni_generator/jni_generator.py diff]

base/android/jni_generator/jni_generator_helper.h diff]

base/android/jni_generator/jni_generator_tests.py diff]

base/android/jni_generator/testInnerClassNatives.golden diff]

base/android/jni_generator/testInnerClassNativesBothInnerAndOuter.golden diff]

base/android/jni_generator/testInnerClassNativesMultiple.golden diff]

base/android/jni_generator/testMultipleJNIAdditionalImport.golden diff]

base/android/jni_generator/testNativeExportsOnlyOption.golden diff]

base/android/jni_generator/testNatives.golden diff]

base/android/jni_generator/testNativesLong.golden diff]

base/android/jni_generator/testSingleJNIAdditionalImport.golden diff]

commit f12240ae372f1217ed467308385fc3f8233e927e author chrome-cron <chrome-cron@google.com> Fri Dec 09 02:02:51 2016 committer chrome-cron <chrome-cron@google.com> Fri Dec 09 02:07:44 2016 Incrementing VERSION to 55.0.2883.89 Cr-Commit-Position: refs/branch-heads/2883@{#727} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 160e1a8642726ba3f7be71358ced49ec24ef5c31 author Alex Mineer <amineer@chromium.org> Thu Dec 08 19:53:50 2016 committer Alex Mineer <amineer@chromium.org> Thu Dec 08 19:57:00 2016 Revert "Reland "Checks the GMS availability before retrieving accounts on device"" This reverts commit 66c71c956d1efea81b2a302fc2fccb41771d8ee2. Per discussion at linked bug, this patch likely has some issues as well. Reverting to ensure we have a clean branch. BUG=672255 Cr-Commit-Position: refs/branch-heads/2883@{#726} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/android/java/src/org/chromium/chrome/browser/firstrun/AccountFirstRunFragment.java diff]

chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java diff]

chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java diff]

commit 4aae86933936e96ccb5393e0963fba65f1058b33 author chrome-cron <chrome-cron@google.com> Thu Dec 08 18:51:02 2016 committer chrome-cron <chrome-cron@google.com> Thu Dec 08 18:54:32 2016 Incrementing VERSION to 55.0.2883.88 Cr-Commit-Position: refs/branch-heads/2883@{#725} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 66c71c956d1efea81b2a302fc2fccb41771d8ee2 author bauerb <bauerb@chromium.org> Thu Dec 08 18:42:10 2016 committer Commit bot <commit-bot@chromium.org> Thu Dec 08 18:45:17 2016 Reland "Checks the GMS availability before retrieving accounts on device" This reverts commit 67a739208b35595dc1aa520abadd2449095d1a09. Additional crash fix: Initialize |mAccountNames| in AccountSigninView with an empty list. If Google Play Services is out of date, |mAccountNames| will never get updated, so this avoids crashes in that case. The long-term fix should probably be to move the Google Play Services version check further down in updateAccounts(), so we'll update as much as possible. NOTRY=true NOPRESUBMIT=true TBR=amineer@chromium.org BUG=603020,672255 Review-Url: https://codereview.chromium.org/2563693002 Cr-Commit-Position: refs/branch-heads/2883@{#724} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/android/java/src/org/chromium/chrome/browser/firstrun/AccountFirstRunFragment.java diff]

chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java diff]

chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java diff]

commit ad0be09aa3ca814168d079b52825f6f80e22f0e8 author chrome-cron <chrome-cron@google.com> Thu Dec 08 02:01:16 2016 committer chrome-cron <chrome-cron@google.com> Thu Dec 08 02:06:25 2016 Incrementing VERSION to 55.0.2883.87 Cr-Commit-Position: refs/branch-heads/2883@{#723} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit bfeed7e771dec8887eeb500b22e8194f52a44e12 author chrome-cron <chrome-cron@google.com> Thu Dec 08 01:32:47 2016 committer chrome-cron <chrome-cron@google.com> Thu Dec 08 01:37:30 2016 Incrementing VERSION to 55.0.2883.86 Cr-Commit-Position: refs/branch-heads/2883@{#722} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 67a739208b35595dc1aa520abadd2449095d1a09 author Alex Mineer <amineer@chromium.org> Thu Dec 08 01:11:30 2016 committer Alex Mineer <amineer@chromium.org> Thu Dec 08 01:14:28 2016 Revert "Checks the GMS availability before retrieving accounts on device" This reverts commit 8608ba07ed680daa8d418b5decbd421600007e55. Causing crashes BUG=672255,603020 Cr-Commit-Position: refs/branch-heads/2883@{#721} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/android/java/src/org/chromium/chrome/browser/firstrun/AccountFirstRunFragment.java diff]

chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java diff]

chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java diff]

commit 1707000b18468db81dc63536da511d1b2964ce8d author Gleb Lanbin <glebl@chromium.org> Thu Dec 08 00:57:54 2016 committer Gleb Lanbin <glebl@chromium.org> Thu Dec 08 01:01:37 2016 Revert commit# 415577 "Add grid/flex layout support for <fieldset>" This patch partially reverts crrev.com/415577. Reason for revert: Broke real world websites. BUG=670837 NOTRY=true NOPRESUBMIT=true R=ikilpatrick@chromium.org Review URL: https://codereview.chromium.org/2555413002 . Review-Url: https://codereview.chromium.org/2549973003 Cr-Original-Commit-Position: refs/heads/master@{#436992} Cr-Commit-Position: refs/branch-heads/2883@{#720} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} third_party/WebKit/LayoutTests/TestExpectations diff]

third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-flex-expected.html [Deleted - diff

third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-flex.html [Deleted - diff

third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid-expected.html [Deleted - diff

third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid.html [Deleted - diff

third_party/WebKit/Source/core/layout/LayoutBlock.cpp diff]

third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp diff]

third_party/WebKit/Source/core/layout/LayoutFieldset.cpp diff]

third_party/WebKit/Source/core/layout/LayoutFieldset.h diff]

third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp diff]

third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h diff]

third_party/WebKit/Source/core/layout/LayoutObject.cpp diff]

commit 378d64878a6c9d888385ab87797351a3d1612a68 author Adam Langley <agl@chromium.org> Wed Dec 07 21:22:58 2016 committer Adam Langley <agl@chromium.org> Wed Dec 07 21:27:27 2016 Update Google pins. (Merge to 2883, i.e. M55.) This change adds the GlobalSign R2 root to the set of acceptable SPKIs for Google properties. BUG=669560 Review-Url: https://codereview.chromium.org/2539853002 Cr-Commit-Position: refs/heads/master@{#436337} (cherry picked from commit 863fe2c9b4a76f0f0d09a17ce59beba2f001d015) Review URL: https://codereview.chromium.org/2553053004 . Cr-Commit-Position: refs/branch-heads/2883@{#719} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} net/http/http_security_headers_unittest.cc diff]

net/http/transport_security_state_static.h diff]

net/http/transport_security_state_static.json diff]

commit 601f4bf2f83ee90aa58ff1ac188aa69cd05da284 author chrome-cron <chrome-cron@google.com> Wed Dec 07 02:01:09 2016 committer chrome-cron <chrome-cron@google.com> Wed Dec 07 02:04:00 2016 Incrementing VERSION to 55.0.2883.85 Cr-Commit-Position: refs/branch-heads/2883@{#718} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 1abab3b6017f1e75d2cc6734c333238b6cb0c856 author David Tseng <dtseng@chromium.org> Tue Dec 06 22:34:23 2016 committer David Tseng <dtseng@chromium.org> Tue Dec 06 22:41:56 2016 Merge to m55: Geneneralized fix for serialization error/reset issues Whenever we see an AX tree fail to unserialize, request it be reset on the source end. TEST=in hotrod, repeatedly toggle on/off ChromeVox. Verify that we re-populate the tree when we get any events (e.g. focus). BUG=667819 Review-Url: https://codereview.chromium.org/2522033002 Cr-Commit-Position: refs/heads/master@{#433985} (cherry picked from commit 38c63d7344c76d9fa58c84db6112daebbfefd3ab) TBR=dtseng@chromium.org Review URL: https://codereview.chromium.org/2557923002 . Cr-Commit-Position: refs/branch-heads/2883@{#717} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/common/extensions/api/automation_internal.idl diff]

chrome/renderer/extensions/automation_internal_custom_bindings.cc diff]

chrome/renderer/resources/extensions/automation_custom_bindings.js diff]

commit a0c6549c7915f3902f74f5e4524e3fa205e22356 author Lucas Furukawa Gadani <lfg@chromium.org> Tue Dec 06 18:40:12 2016 committer Lucas Furukawa Gadani <lfg@chromium.org> Tue Dec 06 18:45:13 2016 Change Isolate Extensions to be off by default. This CL changes the behavior of Isolate Extensions to be off by default, unless it is explicitly enabled by field trial. BUG=545200 Review-Url: https://codereview.chromium.org/2461693002 Cr-Commit-Position: refs/heads/master@{#428775} (cherry picked from commit 9729c2081fc2daeb1bb487fe329aaf8458fac898) R=nasko@chromium.org TBR=lazyboy@chromium.org Review URL: https://codereview.chromium.org/2554083002 . Cr-Commit-Position: refs/branch-heads/2883@{#716} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/browser/chrome_security_exploit_browsertest.cc diff]

chrome/browser/extensions/process_management_browsertest.cc diff]

chrome/browser/extensions/process_manager_browsertest.cc diff]

chrome/common/extensions/extension_process_policy.cc diff]

extensions/browser/guest_view/web_view/web_view_apitest.cc diff]

commit 29f276b1ed3d8a76a0a1ae59734cca523f0c29c7 author chrome-cron <chrome-cron@google.com> Tue Dec 06 18:31:03 2016 committer chrome-cron <chrome-cron@google.com> Tue Dec 06 18:33:53 2016 Incrementing VERSION to 55.0.2883.84 Cr-Commit-Position: refs/branch-heads/2883@{#715} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 93dfb38a23ad838095e9431d6e6bfe17543b9df0 author Ken Rockot <rockot@chromium.org> Tue Dec 06 17:53:26 2016 committer Ken Rockot <rockot@chromium.org> Tue Dec 06 17:58:51 2016 Add device::mojom::OrientationAbsoluteSensor to renderer spec BUG=671234 Review URL: https://codereview.chromium.org/2558503002 . Cr-Commit-Position: refs/branch-heads/2883@{#714} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} content/public/app/mojo/content_browser_manifest.json diff]

commit 4342dec71d70fc56f82d23520b64f416964a798e author chrome-cron <chrome-cron@google.com> Tue Dec 06 02:01:09 2016 committer chrome-cron <chrome-cron@google.com> Tue Dec 06 02:03:48 2016 Incrementing VERSION to 55.0.2883.83 Cr-Commit-Position: refs/branch-heads/2883@{#713} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 0d9bf10adc492d6aeda4a9d60d41a836ff7c73bb author Eric Willigers <ericwilligers@chromium.org> Tue Dec 06 01:51:42 2016 committer Eric Willigers <ericwilligers@chromium.org> Tue Dec 06 01:56:30 2016 Revert "CSS Motion Path: report use of deprecated motion* properties" This reverts commit c49a0a4cd2d0cbb1a42fdb7d22540139058592ff. We need to wait with the deprecation message until we are shipping offset-rotate. BUG=670390 Review-Url: https://codereview.chromium.org/2540333003 Cr-Commit-Position: refs/heads/master@{#435804} (cherry picked from commit 6e75a0e7f22d36666ac2157c6ffef0aded35d822) Review URL: https://codereview.chromium.org/2553603003 . Cr-Commit-Position: refs/branch-heads/2883@{#712} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt [Deleted - diff

third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated.html [Deleted - diff

third_party/WebKit/LayoutTests/css3/motion-path/motion-shorthand-deprecated-expected.txt [Deleted - diff

third_party/WebKit/LayoutTests/css3/motion-path/motion-shorthand-deprecated.html [Deleted - diff

third_party/WebKit/LayoutTests/fast/writing-mode/orthogonal-writing-modes-floats-crash-2-expected.txt diff]

third_party/WebKit/LayoutTests/fast/writing-mode/orthogonal-writing-modes-floats-crash-2.html diff]

third_party/WebKit/Source/core/frame/Deprecation.cpp diff]

commit 34ca308256952476dbf2519fbe7d70d40a942142 author Alexei Filippov <alph@chromium.org> Mon Dec 05 21:58:38 2016 committer Alexei Filippov <alph@chromium.org> Mon Dec 05 22:01:17 2016 DevTools: allow JS frames under EventDispatch BUG=652332 Review-Url: https://codereview.chromium.org/2528553002 Cr-Commit-Position: refs/heads/master@{#434732} (cherry picked from commit ce6a35209d7ebeb969d372c0bf23c0c403bdd83d) Review URL: https://codereview.chromium.org/2555563002 . Cr-Commit-Position: refs/branch-heads/2883@{#711} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js diff]

commit 040236864a5d7781562b747479c600fce02b99b4 author Luis Hector Chavez <lhchavez@google.com> Mon Dec 05 20:45:51 2016 committer Luis Hector Chavez <lhchavez@google.com> Mon Dec 05 20:50:55 2016 [Merge to M55] Reland "Propagate information about how ARC apps are launched" This change lets ARC know whether an app should be launched in Touch Mode[1] or not. 1: http://android-developers.blogspot.com/2008/12/touch-mode.html BUG=669146 TEST=ARC app starts in touch mode when activated using mouse/trackpad/touch TEST=ARC app starts in focus mode when activated using keyboard. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=stevenjb@chromium.org Committed: https://crrev.com/b5898c35b2415dbf8b5d9aaa19a6b13b0510d1e7 Review-Url: https://codereview.chromium.org/2540433002 Cr-Original-Commit-Position: refs/heads/master@{#435115} Cr-Commit-Position: refs/heads/master@{#435327} (cherry picked from commit fa0327a360d5e676680a4b5337a607958c0512d0) Review URL: https://codereview.chromium.org/2553673003 . Cr-Commit-Position: refs/branch-heads/2883@{#710} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/browser/resources/options/browser_options.js diff]

chrome/browser/ui/app_list/arc/arc_app_item.cc diff]

chrome/browser/ui/app_list/arc/arc_app_unittest.cc diff]

chrome/browser/ui/app_list/arc/arc_app_utils.cc diff]

chrome/browser/ui/app_list/arc/arc_app_utils.h diff]

chrome/browser/ui/app_list/search/arc_app_result.cc diff]

chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc diff]

chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h diff]

chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_item_controller.cc diff]

chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_item_controller.h diff]

chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc diff]

chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc diff]

chrome/browser/ui/ash/launcher/launcher_controller_helper.cc diff]

chrome/browser/ui/webui/options/browser_options_handler.cc diff]

commit 102fd9dc961fc353b517c8c8ff8181f7299034be author Robert Sesek <rsesek@chromium.org> Mon Dec 05 16:08:36 2016 committer Robert Sesek <rsesek@chromium.org> Mon Dec 05 16:13:00 2016 [Mac] Opt browser window controller out of being a touch bar provider Currently, on touch bar Macs, the system retains a reference to every object it finds that conforms to the NSTouchBarProvider protocol, which includes NSWindowController. If the user tries to quit Chrome when it isn't foregrounded (for example, from the Dock icon context menu), these references are never released, which means the browser window never deallocs. Since all browser windows being closed is a precondition of quitting, Chrome never quits. There are a few private mechanisms to force the touch bar to update its providers, but no matter what, the references aren't released until Chrome is foregrounded. This change effectively opts the window controller out of being a touch bar provider which prevents it from being retained by the touch bar mechanism in the first place. BUG=667274 Review-Url: https://codereview.chromium.org/2550463002 Cr-Commit-Position: refs/heads/master@{#435759} (cherry picked from commit 0098a25b70b91b23e87a4644e30722ba151e66e2) Review URL: https://codereview.chromium.org/2553703002 . Cr-Commit-Position: refs/branch-heads/2883@{#709} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/browser/ui/cocoa/browser_window_controller.mm diff]

commit 41a549711025cc75e6ef55cf87beeb48ae5dbeb0 author chrome-cron <chrome-cron@google.com> Mon Dec 05 02:01:09 2016 committer chrome-cron <chrome-cron@google.com> Mon Dec 05 02:04:53 2016 Incrementing VERSION to 55.0.2883.82 Cr-Commit-Position: refs/branch-heads/2883@{#708} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit dfa0791d66fc43d92687de0f441ab214bae80bb7 author chrome-cron <chrome-cron@google.com> Sun Dec 04 02:02:55 2016 committer chrome-cron <chrome-cron@google.com> Sun Dec 04 02:06:42 2016 Incrementing VERSION to 55.0.2883.81 Cr-Commit-Position: refs/branch-heads/2883@{#707} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 1a67d5a74b0615ecc567c58d3927404a87fb5546 author chrome-cron <chrome-cron@google.com> Sat Dec 03 02:03:28 2016 committer chrome-cron <chrome-cron@google.com> Sat Dec 03 02:06:55 2016 Incrementing VERSION to 55.0.2883.80 Cr-Commit-Position: refs/branch-heads/2883@{#706} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 4a24222afe6c048e0a0953fd1e265025ea64f6ab author chrome-cron <chrome-cron@google.com> Fri Dec 02 18:21:03 2016 committer chrome-cron <chrome-cron@google.com> Fri Dec 02 18:23:54 2016 Incrementing VERSION to 55.0.2883.79 Cr-Commit-Position: refs/branch-heads/2883@{#705} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit cee486746e2a772c675a87f947242259fe2563cf author chrome-cron <chrome-cron@google.com> Fri Dec 02 02:02:58 2016 committer chrome-cron <chrome-cron@google.com> Fri Dec 02 02:06:11 2016 Incrementing VERSION to 55.0.2883.78 Cr-Commit-Position: refs/branch-heads/2883@{#704} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 4eeca377f0c99331e0e2e1df1f3b5650bb098df9 author Xiyuan Xia <xiyuan@google.com> Thu Dec 01 17:46:46 2016 committer Xiyuan Xia <xiyuan@google.com> Thu Dec 01 17:50:30 2016 Merge "kiosk: Use ContextMenuContentTypeAppMode when in app mode" > Give ContextMenuContentTypeAppMode higher priority than > ContextMenuContentTypeWebView so that webview in kiosk mode > does not show undesired context menu. > > BUG=656188 > > Review-Url: https://codereview.chromium.org/2545433004 > Cr-Commit-Position: refs/heads/master@{#435429} > (cherry picked from commit 8791e3898c6d8c25fdfc416bb0c427607f223851) Review URL: https://codereview.chromium.org/2533353005 . Cr-Commit-Position: refs/branch-heads/2883@{#703} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/browser/renderer_context_menu/context_menu_content_type_factory.cc diff]

commit bc210cba18e0ab85f57c5bbf8279c7c8b2629024 author chrome-cron <chrome-cron@google.com> Thu Dec 01 05:30:59 2016 committer chrome-cron <chrome-cron@google.com> Thu Dec 01 05:34:43 2016 Incrementing VERSION to 55.0.2883.77 Cr-Commit-Position: refs/branch-heads/2883@{#702} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 2e2a7a54cbbcbb570781ccf9bbb6052a9b8e9b79 author Changwan Ryu <changwan@google.com> Thu Dec 01 05:18:49 2016 committer Changwan Ryu <changwan@google.com> Thu Dec 01 05:24:24 2016 Reuse InputConnectionHandlerThread This can prevent the number of threads from growing when an app creates and destroys webviews. BUG=668692 Review-Url: https://codereview.chromium.org/2543893002 Cr-Commit-Position: refs/heads/master@{#435557} (cherry picked from commit 43fae8979739f1ef5620996a9ac978e100c0ec7c) Review URL: https://codereview.chromium.org/2544753002 . Cr-Commit-Position: refs/branch-heads/2883@{#701} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java diff]

commit 3cb0576de6902976d1b4271e0673aac0caa641fa author rogerm <rogerm@chromium.org> Thu Dec 01 04:21:45 2016 committer Commit bot <commit-bot@chromium.org> Thu Dec 01 04:25:29 2016 [autofill] Merge can select the wrong address. Fixes a bug where, in the case where the the second address should have been retained during merge, the first address is retained, due to a typo in the referenced variable name. BUG=669925 R=mathp@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2535103004 Cr-Commit-Position: refs/branch-heads/2883@{#700} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} components/autofill/core/browser/autofill_profile_comparator.cc diff]

commit de8f4d7ce19e10572811fd290de6aef94191bd25 author chrome-cron <chrome-cron@google.com> Thu Dec 01 02:01:09 2016 committer chrome-cron <chrome-cron@google.com> Thu Dec 01 02:04:23 2016 Incrementing VERSION to 55.0.2883.76 Cr-Commit-Position: refs/branch-heads/2883@{#699} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 451c239c3b0722dc867b0f75839b959f729b756a author chrome-cron <chrome-cron@google.com> Wed Nov 30 20:06:25 2016 committer chrome-cron <chrome-cron@google.com> Wed Nov 30 20:09:59 2016 Incrementing VERSION to 55.0.2883.75 Cr-Commit-Position: refs/branch-heads/2883@{#698} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 5bef377931536f00377731124a2fd6fec1477ae6 author chrome-cron <chrome-cron@google.com> Wed Nov 30 18:56:17 2016 committer chrome-cron <chrome-cron@google.com> Wed Nov 30 19:01:30 2016 Incrementing VERSION to 55.0.2883.74 Cr-Commit-Position: refs/branch-heads/2883@{#697} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 94e8585dbf62dd31236951004ce9ac785c6409b6 author Alex Mineer <amineer@chromium.org> Wed Nov 30 18:42:36 2016 committer Alex Mineer <amineer@chromium.org> Wed Nov 30 18:46:16 2016 Revert "Fix leaks in InputConnectionHandlerThread" This reverts commit c7860ebf0f5005dfe519f5abc0a352ce680144f5. Reverting on M55 branch 2883 due to crash bug. BUG=669886,668692 Cr-Commit-Position: refs/branch-heads/2883@{#696} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java diff]

content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java diff]

content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java diff]

content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java diff]

content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java diff]

content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java diff]

content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionFactoryTest.java diff]

commit 6def8f6d5e10406333ba039b097021168e5e9812 author chrome-cron <chrome-cron@google.com> Wed Nov 30 17:32:44 2016 committer chrome-cron <chrome-cron@google.com> Wed Nov 30 17:36:19 2016 Incrementing VERSION to 55.0.2883.73 Cr-Commit-Position: refs/branch-heads/2883@{#695} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 71a27c52eb0dfe96f1b7724d17d3798f4ccd4755 author sdefresne <sdefresne@chromium.org> Wed Nov 30 17:16:51 2016 committer Commit bot <commit-bot@chromium.org> Wed Nov 30 17:20:19 2016 [iOS/ARC] Fix a violation of ODR in base::BindBlock under ARC. The template function base::BindBlock invoked the constructor of base::mac::ScopedBlock that has two different signature whether ARC (automatic reference counting) is enabled or not. If two different files are compiled with a different ARC setting (one has ARC enabled, the other has it disabled) and both invoke base::BindBlock with the same type of block (i.e. same signature) then the function has two different implementation (which is a violation of the ODR) and one of them is selected at link-time. As the base::BindBlock implementation does retain the block, this can only lead to over-retaining an object (as the implementation leaks if the ARC version of base::mac::ScopedBlock is invoked) not to over-releasing. BUG=666027 Review-Url: https://codereview.chromium.org/2522943003 Cr-Commit-Position: refs/heads/master@{#434182} (cherry picked from commit 3baab423ea642cc0851a482841091fd8ac9f8b3c) Reverted changes to the following files not yet converted to ARC in branch 2883 (M55): ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm ios/chrome/browser/share_extension/share_extension_item_receiver.mm ios/chrome/browser/ssl/ios_ssl_error_handler_unittest.mm TBR=mark@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2546503002 Cr-Commit-Position: refs/branch-heads/2883@{#694} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} base/mac/bind_objc_block.h diff]

base/mac/bind_objc_block_unittest.mm diff]

base/mac/bind_objc_block_unittest_arc.mm diff]

base/mac/scoped_nsobject_unittest.mm diff]

base/mac/scoped_nsobject_unittest_arc.mm diff]

ios/web/net/clients/crw_redirect_network_client.mm diff]

ios/web/net/crw_cert_verification_controller.mm diff]

ios/web/net/request_tracker_impl.mm diff]

ios/web/webui/crw_web_ui_manager.mm diff]

ios/web/webui/mojo_facade.mm diff]

commit de48f484a9767fa6c31be1be78d7030528fc9825 author chrome-cron <chrome-cron@google.com> Wed Nov 30 15:41:08 2016 committer chrome-cron <chrome-cron@google.com> Wed Nov 30 15:46:20 2016 Incrementing VERSION to 55.0.2883.72 Cr-Commit-Position: refs/branch-heads/2883@{#693} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 32ddf24e3b852f14d2fc6d927060e5b9f5b2db31 author clamy <clamy@chromium.org> Wed Nov 30 14:57:50 2016 committer clamy <clamy@chromium.org> Wed Nov 30 15:02:17 2016 Fix issue with location tracking icon disappearing on M55 This CL is a followup to https://codereview.chromium.org/2534563002/ which merged https://codereview.chromium.org/2524053002/ into M55. The CL on trunk fixed the issue on trunk, but was not enough on M55 beacuse at that time we also need to filter out NavigationHandles with IsSynchronousNavigation set to true. On M55, NavigationHandle::IsSamePage was set later in time, so we can't use it as we're doing on trunk. BUG=667256 Publish DEPS for Chromium 55.0.2883.70 R=bauerb@chromium.org, nasko@chromium.org Review URL: https://codereview.chromium.org/2536423003 . Cr-Commit-Position: refs/branch-heads/2883@{#692} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/browser/content_settings/tab_specific_content_settings.cc diff]

commit 21470ff49c2aad3ea7c7c2146df774af1fa9b0c9 author chrome-cron <chrome-cron@google.com> Wed Nov 30 02:11:05 2016 committer chrome-cron <chrome-cron@google.com> Wed Nov 30 02:14:58 2016 Incrementing VERSION to 55.0.2883.71 Cr-Commit-Position: refs/branch-heads/2883@{#691} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit b940d1cb4de0dcdaa11a82ffd9464cf58c6ec301 author Donn Denman <donnd@google.com> Wed Nov 30 01:50:15 2016 committer Donn Denman <donnd@google.com> Wed Nov 30 01:59:56 2016 [TTS] Fix blank and stale bar-text issues. This change seems to fix the cases where a stale Search Term is sometimes displayed. It also seems to fix most of the cases where a blank bar is sometimes shown when the Context should be displayed. We were setting the opacity of the Search Term based on the opacity of the Context, assuming that they are complementary, which is not always the case. Now we honor the Search Term opacity passed in to ContextualSearchLayer::SetProperties. This fixes the stale text from the previous Search Term being shown. When showing the Context we were checking if the panel is showing. Sometimes the panel is not yet actually showing even after the code has called requestPanelShow because the panel is still completely offscreen. Now we no longer check if the panel is showing before setting the Context. This seems to fix most of the remaining cases where a blank panel was seen. The panel will always exist and its components will be lazily created, so this seems safe for now. However we should implement a better way to know if it's been asked to show (crbug.com/669600). This change may not fix all cases -- I occasionally see a blank bar after the first startup. BUG=658771 Review-Url: https://codereview.chromium.org/2535313002 Cr-Commit-Position: refs/heads/master@{#435112} (cherry picked from commit bb3cb5760cc9f1778969dafaa67ee7712b010f5f) Review URL: https://codereview.chromium.org/2535203003 . Cr-Commit-Position: refs/branch-heads/2883@{#690} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java diff]

commit c7860ebf0f5005dfe519f5abc0a352ce680144f5 author Changwan Ryu <changwan@google.com> Wed Nov 30 01:45:37 2016 committer Changwan Ryu <changwan@google.com> Wed Nov 30 01:59:55 2016 Fix leaks in InputConnectionHandlerThread On destruction of ContentViewCore and on view detachment, we reset mHandler, allowing it a chance to be garbage-collected. BUG=668692 (directly cherry-picked from patchset http://crrev.com/2537073002#ps20001 for early QA pass purposes, as requested by TPM) Review URL: https://codereview.chromium.org/2532383003 . Cr-Commit-Position: refs/branch-heads/2883@{#689} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java diff]

content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java diff]

content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java diff]

content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java diff]

content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java diff]

content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java diff]

content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionFactoryTest.java diff]

commit eff4bbc4f842209d17d314f5c2fe7b04bde6c0d4 author Donn Denman <donnd@google.com> Wed Nov 30 01:11:28 2016 committer Donn Denman <donnd@google.com> Wed Nov 30 01:15:52 2016 [TTS] Fix Bar text showing blank after startup. The Bar has main bar text that can either show the Search Term or the Context. When the user taps we show the Context first, and the Search Term is not yet visible, so calculations based on its size are invalid. We now check to see if the Search Term text is visible before using any attribute of it. BUG=658771 Review-Url: https://codereview.chromium.org/2518503004 Cr-Commit-Position: refs/heads/master@{#434723} (cherry picked from commit aa73340fc20421e8a9816de1033f6c553cb28983) Review URL: https://codereview.chromium.org/2532403004 . Cr-Commit-Position: refs/branch-heads/2883@{#688} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchBarControl.java diff]

chrome/browser/android/compositor/layer/contextual_search_layer.cc diff]

commit 9e8d8cf2025d7ad6dc29b81a954a46e7299a9a51 author Maria Khomenko <mariakhomenko@chromium.org> Wed Nov 30 00:43:53 2016 committer Maria Khomenko <mariakhomenko@chromium.org> Wed Nov 30 00:48:55 2016 Instant Apps: Skip checking referrer param on SERP. Note: this is a manual cherry-pick of https://codereview.chromium.org/2539633003/. The referrer param doesn't get set because the web platform doesn't set referrers for intent:// URLs. Since we are checking the referrer via navigation controller, we don't need to do this check anyway. BUG=669698 TBR=tedchoc@chromium.org Review URL: https://codereview.chromium.org/2539543006 . Cr-Commit-Position: refs/branch-heads/2883@{#687} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java diff]

commit 98729734658f98e96eb03d83452e088e9e2d8bd8 author Jian Li <jianli@chromium.org> Wed Nov 30 00:24:11 2016 committer Jian Li <jianli@chromium.org> Wed Nov 30 00:27:21 2016 [Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFragment * Adding a test and fixing the issue BUG=669126 Review-Url: https://codereview.chromium.org/2535023002 Cr-Commit-Position: refs/heads/master@{#434811} (cherry picked from commit 1acc2c4283c64636eb2a120f3e1e51267f74a427) Review URL: https://codereview.chromium.org/2542503002 . Cr-Commit-Position: refs/branch-heads/2883@{#686} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/browser/android/offline_pages/offline_page_utils.cc diff]

chrome/browser/android/offline_pages/offline_page_utils_unittest.cc diff]

chrome/browser/previews/previews_infobar_tab_helper_unittest.cc diff]

commit 8608ba07ed680daa8d418b5decbd421600007e55 author Alex Mineer <amineer@chromium.org> Tue Nov 29 23:02:03 2016 committer Alex Mineer <amineer@chromium.org> Tue Nov 29 23:07:29 2016 Checks the GMS availability before retrieving accounts on device Retrieving accounts on device will fail on Android 6.0+ if GMS is out-of-date. BUG=603020 (cherry picked from commit ef69bb748ac458e33c729ded3db9595278cd65d7) Review-Url: https://codereview.chromium.org/2507843002 Cr-Original-Commit-Position: refs/heads/master@{#432590} Cr-Commit-Position: refs/branch-heads/2883@{#685} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/android/java/src/org/chromium/chrome/browser/firstrun/AccountFirstRunFragment.java diff]

chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java diff]

chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java diff]

commit abc0b9d0d71a25f6210d8a8fe9054223586a2f43 author Maria Khomenko <mariakhomenko@chromium.org> Tue Nov 29 22:26:15 2016 committer Maria Khomenko <mariakhomenko@chromium.org> Tue Nov 29 22:40:18 2016 Instant Apps: Allow custom tab redirects to Instant Apps. Usually custom tabs force-load URLs or redirects to URLs that can be handled by apps inside custom tabs. For instant-apps enabled clients override the default behaviour and launch the instant app, if possible. BUG=659301 Review-Url: https://codereview.chromium.org/2532223002 Cr-Commit-Position: refs/heads/master@{#434714} (cherry picked from commit 0d4f64f504986b0ef87efd1275935c30a9416512) Review URL: https://codereview.chromium.org/2537293002 . Cr-Commit-Position: refs/branch-heads/2883@{#684} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java diff]

chrome/android/java/src/org/chromium/chrome/browser/tab/TabRedirectHandler.java diff]

chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java diff]

commit 6e3e8c3b951986590197b7c364c3041ae54cee52 author timvolodine <timvolodine@chromium.org> Tue Nov 29 19:42:32 2016 committer Commit bot <commit-bot@chromium.org> Tue Nov 29 19:47:17 2016 [Android] Fix NullPointerException crash in SpellCheckerSessionBridge. Merge to M55 (branch 2883) Add a check for potential null results when the spellchecking service returns in onGetSentenceSuggestions. Haven't tested, reproduced or investigated the cause of this (i.e. nulls in results) but seems the right approach to avoid crashes in the first place, see crbug.com/651458 for more details. BUG=651458,583616,629609 TBR=tobiasjs@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2413873003 Cr-Commit-Position: refs/heads/master@{#425004} (cherry picked from commit f16e0045b2dd3e399e14e5a44db1d8b1b18d46e9) Review-Url: https://codereview.chromium.org/2539583003 Cr-Commit-Position: refs/branch-heads/2883@{#683} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} components/spellcheck/browser/android/java/src/org/chromium/components/spellcheck/SpellCheckerSessionBridge.java diff]

commit 95c431363bf4a88a8a24bdfbe545ec80a31d8ff5 author Julia Tuttle <juliatuttle@chromium.org> Tue Nov 29 19:07:13 2016 committer Julia Tuttle <juliatuttle@chromium.org> Tue Nov 29 19:12:42 2016 Make DnsSocketPool copy RandIntCallback DnsSocketPool is created by DnsClient, and passed a reference to the RandIntCallback in DnsClient. It is then stored in DnsSession, which is ref-counted (so running transactions can continue while DnsSession is recreated on config changes). Unfortunately, if the DnsClient itself is destroyed, the DnsSession hangs around, holding on to the DnsSocketPool, which is holding on to a reference to the RandIntCallback in the destroyed DnsClient. Fix this by copying the RandIntCallback into the DnsSocketPool when it is constructed. (Also, rearrange destructor to satisfy the linter.) BUG=664457 Review-Url: https://codereview.chromium.org/2533753003 Cr-Commit-Position: refs/heads/master@{#434752} (cherry picked from commit 2dd66098349196a1048403810c0faadf05072387) Review URL: https://codereview.chromium.org/2538843002 . Cr-Commit-Position: refs/branch-heads/2883@{#682} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} net/dns/dns_socket_pool.cc diff]

net/dns/dns_socket_pool.h diff]

commit fb56bdc5dc35cbd6be29e6f9df80e734eff38ee5 author rohitrao <rohitrao@chromium.org> Tue Nov 29 19:06:24 2016 committer Commit bot <commit-bot@chromium.org> Tue Nov 29 19:09:32 2016 Revert of [iOS/ARC] Fix a violation of ODR in base::BindBlock under ARC for M55 branch. (patchset #1 id:1 of https://codereview.chromium.org/2537653003/ ) Reason for revert: Compile error. Original issue's description: > [iOS/ARC] Fix a violation of ODR in base::BindBlock under ARC for M55 branch. > > This is a variant of https://codereview.chromium.org/2522943003/ for M55 > branch. > > The template function base::BindBlock invoked the constructor of > base::mac::ScopedBlock that has two different signature whether > ARC (automatic reference counting) is enabled or not. > > If two different files are compiled with a different ARC setting > (one has ARC enabled, the other has it disabled) and both invoke > base::BindBlock with the same type of block (i.e. same signature) > then the function has two different implementation (which is a > violation of the ODR) and one of them is selected at link-time. > > As the base::BindBlock implementation does retain the block, this > can only lead to over-retaining an object (as the implementation > leaks if the ARC version of base::mac::ScopedBlock is invoked) not > to over-releasing. > > BUG=666027 > R=rohitrao@chromium.org > TBR=mark@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/a384061d95a769b8cf0c7f6c1f491193aa272ee1 TBR=justincohen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=666027 Review-Url: https://codereview.chromium.org/2535303002 Cr-Commit-Position: refs/branch-heads/2883@{#681} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} base/mac/bind_objc_block.h diff]

base/mac/bind_objc_block_unittest_arc.mm diff]

ios/web/net/clients/crw_redirect_network_client.mm diff]

ios/web/net/crw_cert_verification_controller.mm diff]

ios/web/net/request_tracker_impl.mm diff]

ios/web/webui/crw_web_ui_manager.mm diff]

commit dd35b853b29de548eb08d0ff07f0ccbcc9acc26d author Pavel Feldman <pfeldman@chromium.org> Tue Nov 29 18:55:23 2016 committer Pavel Feldman <pfeldman@chromium.org> Tue Nov 29 19:00:05 2016 DevTools: pick resource with certificate when retrieving cert data. BUG=668072 NOTRY=true Review-Url: https://codereview.chromium.org/2540493002 Cr-Commit-Position: refs/heads/master@{#434792} (cherry picked from commit 922fbf5561c60b6d2239892f73eddcc3a0676aa7) Review URL: https://codereview.chromium.org/2534203002 . Cr-Commit-Position: refs/branch-heads/2883@{#680} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp diff]

commit a384061d95a769b8cf0c7f6c1f491193aa272ee1 author Justin Cohen <justincohen@google.com> Tue Nov 29 18:36:22 2016 committer Justin Cohen <justincohen@google.com> Tue Nov 29 18:39:37 2016 [iOS/ARC] Fix a violation of ODR in base::BindBlock under ARC for M55 branch. This is a variant of https://codereview.chromium.org/2522943003/ for M55 branch. The template function base::BindBlock invoked the constructor of base::mac::ScopedBlock that has two different signature whether ARC (automatic reference counting) is enabled or not. If two different files are compiled with a different ARC setting (one has ARC enabled, the other has it disabled) and both invoke base::BindBlock with the same type of block (i.e. same signature) then the function has two different implementation (which is a violation of the ODR) and one of them is selected at link-time. As the base::BindBlock implementation does retain the block, this can only lead to over-retaining an object (as the implementation leaks if the ARC version of base::mac::ScopedBlock is invoked) not to over-releasing. BUG=666027 R=rohitrao@chromium.org TBR=mark@chromium.org Review URL: https://codereview.chromium.org/2537653003 . Cr-Commit-Position: refs/branch-heads/2883@{#679} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} base/mac/bind_objc_block.h diff]

base/mac/bind_objc_block_unittest_arc.mm diff]

ios/web/net/clients/crw_redirect_network_client.mm diff]

ios/web/net/crw_cert_verification_controller.mm diff]

ios/web/net/request_tracker_impl.mm diff]

ios/web/webui/crw_web_ui_manager.mm diff]

commit f21f84581fafc4c36b97a2b5ab798767b5c025de author Vaclav Brozek <vabr@chromium.org> Tue Nov 29 08:47:02 2016 committer Vaclav Brozek <vabr@chromium.org> Tue Nov 29 08:51:00 2016 Reland of Merge of "Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully" to M55 Merge approval: http://crbug.com/658902#c29 Original merge: https://codereview.chromium.org/2534113002 Reverted in https://codereview.chromium.org/2535183002 for breaking compilation. In this CL, patch set 1 is identical to the original merge, patch set 2 contains the fix for compilation. The CL has been checked locally, it compiles and the test passes (on a GNU/Linux machine). Original description of the merge: " GetSavePasswordDialogTitleTextAndLinkRange currently assumes that localised strings for particular IDs contain placeholders, and attempts to access the vector of offsets corresponding to such placeholders. However, in some situations (http://crbug.com/658902#c18) the localised string may be empty. This led to an out-of-bounds access and crash on Android. This CL is the smallest change to handle such situation gracefully -- it checks the length of the vector with offsets and gives up accessing it if it is empty. This avoids the crash but results in displaying a UI with empty strings. Ideally, the UI would also be supressed on these occasions, but that is left for follow-up CLs. The current situation is already an improvement (password manager is still not very useful, but at least the browser has a chance to continue). The CL also removes the temporary logging put in for the crash investigation. BUG=658902 Review-Url: https://codereview.chromium.org/2526283002 Cr-Commit-Position: refs/heads/master@{#434482} (cherry picked from commit 49ebcf7d64e71c7d3ac71bca66f65d61180bfb8c) " Review URL: https://codereview.chromium.org/2539723002 . Cr-Commit-Position: refs/branch-heads/2883@{#677} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/browser/ui/passwords/manage_passwords_view_utils.cc diff]

chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc diff]

commit 92ff6e0e9439601522bc12ac141533a12cb54b06 author Will Harris <wfh@chromium.org> Tue Nov 29 08:29:15 2016 committer Will Harris <wfh@chromium.org> Tue Nov 29 08:33:05 2016 Merge M55: Update Flash plugin metadata versions to latest version. https://helpx.adobe.com/security/products/flash-player/apsb16-37.html BUG=412078 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=jschuh@chromium.org Review-Url: https://codereview.chromium.org/2534103002 Cr-Commit-Position: refs/heads/master@{#434922} (cherry picked from commit c9bc7f4b6665bc4a48bb22ea93ca1e686aa6b707) Review URL: https://codereview.chromium.org/2538553004 . Cr-Commit-Position: refs/branch-heads/2883@{#676} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/browser/resources/plugin_metadata/plugins_linux.json diff]

chrome/browser/resources/plugin_metadata/plugins_mac.json diff]

chrome/browser/resources/plugin_metadata/plugins_win.json diff]

commit 4848db843fb777547e7410d223e08198c8680252 author vabr <vabr@chromium.org> Tue Nov 29 08:15:11 2016 committer Commit bot <commit-bot@chromium.org> Tue Nov 29 08:19:11 2016 Revert of Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully (patchset #1 id:1 of https://codereview.chromium.org/2534113002/ ) Reason for revert: Compile failure. BUG=669394 Original issue's description: > Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully > > GetSavePasswordDialogTitleTextAndLinkRange currently assumes that localised > strings for particular IDs contain placeholders, and attempts to access the > vector of offsets corresponding to such placeholders. However, in some > situations (http://crbug.com/658902#c18) the localised string may be empty. > This led to an out-of-bounds access and crash on Android. > > This CL is the smallest change to handle such situation gracefully -- it checks > the length of the vector with offsets and gives up accessing it if it is empty. > This avoids the crash but results in displaying a UI with empty strings. > Ideally, the UI would also be supressed on these occasions, but that is left > for follow-up CLs. The current situation is already an improvement (password > manager is still not very useful, but at least the browser has a chance to > continue). > > The CL also removes the temporary logging put in for the crash investigation. > > BUG=658902 > > Review-Url: https://codereview.chromium.org/2526283002 > Cr-Commit-Position: refs/heads/master@{#434482} > (cherry picked from commit 49ebcf7d64e71c7d3ac71bca66f65d61180bfb8c) > > Committed: https://chromium.googlesource.com/chromium/src/+/910f52d5209148d0ad1afa8cbfb9360d65fcb00e TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=658902 Review-Url: https://codereview.chromium.org/2535183002 Cr-Commit-Position: refs/branch-heads/2883@{#675} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/browser/ui/passwords/manage_passwords_view_utils.cc diff]

chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc diff]

commit 910f52d5209148d0ad1afa8cbfb9360d65fcb00e author Vaclav Brozek <vabr@chromium.org> Tue Nov 29 07:15:59 2016 committer Vaclav Brozek <vabr@chromium.org> Tue Nov 29 07:20:09 2016 Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully GetSavePasswordDialogTitleTextAndLinkRange currently assumes that localised strings for particular IDs contain placeholders, and attempts to access the vector of offsets corresponding to such placeholders. However, in some situations (http://crbug.com/658902#c18) the localised string may be empty. This led to an out-of-bounds access and crash on Android. This CL is the smallest change to handle such situation gracefully -- it checks the length of the vector with offsets and gives up accessing it if it is empty. This avoids the crash but results in displaying a UI with empty strings. Ideally, the UI would also be supressed on these occasions, but that is left for follow-up CLs. The current situation is already an improvement (password manager is still not very useful, but at least the browser has a chance to continue). The CL also removes the temporary logging put in for the crash investigation. BUG=658902 Review-Url: https://codereview.chromium.org/2526283002 Cr-Commit-Position: refs/heads/master@{#434482} (cherry picked from commit 49ebcf7d64e71c7d3ac71bca66f65d61180bfb8c) Review URL: https://codereview.chromium.org/2534113002 . Cr-Commit-Position: refs/branch-heads/2883@{#674} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/browser/ui/passwords/manage_passwords_view_utils.cc diff]

chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc diff]

commit fded73b6cae5ca08a2626aaa87a5bf6c8f2293e1 author chrome-cron <chrome-cron@google.com> Tue Nov 29 01:01:04 2016 committer chrome-cron <chrome-cron@google.com> Tue Nov 29 01:05:56 2016 Incrementing VERSION to 55.0.2883.70 Cr-Commit-Position: refs/branch-heads/2883@{#673} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 956718c5d2933fdc7cd6df90339565aa647e3213 author glevin <glevin@chromium.org> Mon Nov 28 23:56:31 2016 committer glevin <glevin@chromium.org> Tue Nov 29 00:00:11 2016 Hide Launcher app search box when empty BUG=661380 TEST=Open launcher, type a search that returns no app results. The horizontal box that usually contains app results should be hidden. Review-Url: https://codereview.chromium.org/2473033002 Cr-Commit-Position: refs/heads/master@{#433686} (cherry picked from commit 32247f5271fd583a683bc8dc2e4c07ce3cf72b85) Review URL: https://codereview.chromium.org/2534043002 . Cr-Commit-Position: refs/branch-heads/2883@{#672} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} ui/app_list/views/search_result_tile_item_list_view.cc diff]

commit 7612918e45624fd23d78d71b8c0107159b6610a0 author Qiang Xu <warx@chromium.org> Mon Nov 28 22:43:16 2016 committer Qiang Xu <warx@chromium.org> Mon Nov 28 22:47:44 2016 [Merge to 2883] Adding experimental flag for enumerating audio devices on ChromeOS, default disabled BUG=651512 TBR=isherman@chromium.org, tommi@chromium.org TEST=tested on device, default state is restoring to m53 behavior; if enabled in chrome://flags, the added feature will be shown. Review-Url: https://codereview.chromium.org/2427493003 Cr-Commit-Position: refs/heads/master@{#426058} (cherry picked from commit e993ec31e3b80b34b2279017db6e6b049d862927) Review URL: https://codereview.chromium.org/2531983003 . Cr-Commit-Position: refs/branch-heads/2883@{#671} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/app/generated_resources.grd diff]

chrome/browser/about_flags.cc diff]

media/audio/BUILD.gn diff]

media/audio/audio_features.cc [Added - diff

media/audio/audio_features.h [Added - diff

media/audio/audio_manager_unittest.cc diff]

media/audio/cras/audio_manager_cras.cc diff]

tools/metrics/histograms/histograms.xml diff]

commit 59c8df38a1f3f087e58f3318233c2f4bc01af0d9 author thomasanderson <thomasanderson@chromium.org> Mon Nov 28 21:40:00 2016 committer Commit bot <commit-bot@chromium.org> Mon Nov 28 21:43:36 2016 Linux Aura: Fix overlay shadows on notifications >Linux Aura got support for translucent windows in CL: >https://chromium.googlesource.com/chromium/src.git/+/62ba78ffcdf525eb9ed640724e640fcf22fbbf87 > >Some Chrome widgets used a TRANSLUCENT_WINDOW opacity for widgets that >fade in or out, but that don't actually have an alpha mask. This was >to support a limitation on MS Windows where windows must be >translucent to fade. > >However, most Linux window managers only draw shadows on opaque >windows: that is, windows that do not have an alpha channel. Windows >that fade in or out may still have shadows since opacity is set as a >property of the toplevel window. > >Therefore, the solution is to use INFER_OPACITY for fading widgets so >it will work across platforms. TRANSLUCENT_WINDOW should only be used >on widgets that have alpha masks. > >BUG=640170 > >R=sky@chromium.org > >patch from issue 2398203002 at patchset 40001 >(http://crrev.com/2398203002#ps40001) > NOTRY=true NOPRESUBMIT=true BUG=640170 TBR=sky@chromium.org Review-Url: https://codereview.chromium.org/2537603002 Cr-Commit-Position: refs/branch-heads/2883@{#670} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} ui/message_center/views/toast_contents_view.cc diff]

ui/views/widget/widget.h diff]

commit b471372e332a57d76d02fd2a0f616372192d60e6 author Andrew R. Whalley <awhalley@chromium.org> Mon Nov 28 20:42:30 2016 committer Andrew R. Whalley <awhalley@chromium.org> Mon Nov 28 20:46:00 2016 [M55 merge] Add icarus and skydiver CT logs They have completed their initial compliance monitoring successfully. BUG=632752,632753 Review-Url: https://codereview.chromium.org/2477563004 Cr-Commit-Position: refs/heads/master@{#429670} (cherry picked from commit 403c8359bdc2b635d480a80329c41be422583c1f) Review URL: https://codereview.chromium.org/2537583002 . Cr-Commit-Position: refs/branch-heads/2883@{#669} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} net/cert/ct_known_logs_static-inc.h diff]

commit b7297ad5f5455249330edc78cbbd9142a227d69f author Andrew R. Whalley <awhalley@chromium.org> Mon Nov 28 18:37:18 2016 committer Andrew R. Whalley <awhalley@chromium.org> Mon Nov 28 18:44:43 2016 [M55 merge] Reference table row via the cell for row background display item client. BUG=666800 Review-Url: https://codereview.chromium.org/2522923003 Cr-Commit-Position: refs/heads/master@{#434110} (cherry picked from commit 91b1dd79c0916b9c329058622919f190958ec626) Review URL: https://codereview.chromium.org/2529273004 . Cr-Commit-Position: refs/branch-heads/2883@{#668} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} third_party/WebKit/LayoutTests/paint/tables/table-cell-changes-to-colgroup-expected.html [Added - diff

third_party/WebKit/LayoutTests/paint/tables/table-cell-changes-to-colgroup.html [Added - diff

third_party/WebKit/Source/core/layout/LayoutTableCell.cpp diff]

third_party/WebKit/Source/core/layout/LayoutTableCell.h diff]

commit 752adc102698ff8d301ecbde0bd53b6268e902b4 author Bo Liu <boliu@chromium.org> Mon Nov 28 16:42:36 2016 committer Bo Liu <boliu@chromium.org> Mon Nov 28 16:46:33 2016 [Merge M55] android: Increase gpu timeout to 20s from 10s. Browser crashes itself if gpu process cannot be "started" in 10 seconds. In trying to reduce the rate of this timeout, give the gpu watchdog, which times out at 15s, a chance to crash the gpu process first. So increase the browser side to slightly longer 20 seconds. BUG=664341 Review-Url: https://codereview.chromium.org/2530653002 Cr-Commit-Position: refs/heads/master@{#434232} (cherry picked from commit 32dabb0f07717054c137f368745d0ffabb71e3e3) Review URL: https://codereview.chromium.org/2536773002 . Cr-Commit-Position: refs/branch-heads/2883@{#667} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} content/browser/renderer_host/context_provider_factory_impl_android.cc diff]

commit d58949b0f26aa857bc24575047f5f458f7afefa5 author chrome-cron <chrome-cron@google.com> Mon Nov 28 01:01:01 2016 committer chrome-cron <chrome-cron@google.com> Mon Nov 28 01:04:40 2016 Incrementing VERSION to 55.0.2883.69 Cr-Commit-Position: refs/branch-heads/2883@{#666} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit 43baf2db43945d9a90291e49a1ac04b814961af1 author chrome-cron <chrome-cron@google.com> Sun Nov 27 01:01:02 2016 committer chrome-cron <chrome-cron@google.com> Sun Nov 27 01:04:41 2016 Incrementing VERSION to 55.0.2883.68 Cr-Commit-Position: refs/branch-heads/2883@{#665} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit fa5de7c5b36eec950eefe2b91503605941e08099 author chrome-cron <chrome-cron@google.com> Sat Nov 26 01:00:59 2016 committer chrome-cron <chrome-cron@google.com> Sat Nov 26 01:04:04 2016 Incrementing VERSION to 55.0.2883.67 Cr-Commit-Position: refs/branch-heads/2883@{#664} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit b51fc4e484f4d46830b40122b04119e0edda708d author Mustaq Ahmed <mustaq@google.com> Fri Nov 25 16:16:17 2016 committer Mustaq Ahmed <mustaq@google.com> Fri Nov 25 16:20:25 2016 Removed resetting of pinch-gesture filter state on pinch end. We used to reset the TouchActionFilter state |drop_pinch_gesture_events_| at a pinch end assuming that there is a single pinch-sequence within a gesture-scroll sequence. This logically correct assumption turned out to be wrong in practice: a pinch-zoom-out-then-zoom-in actually sends two consecutive pinch-begin/end sequences between a gesture-scroll-begin/end sequence. This CL defers the resetting of |drop_pinch_gesture_events_| to bracketing gesture-scroll-end to avoid wrong filtering during the second pinch-begin/end sequence. BUG=662047 Review-Url: https://codereview.chromium.org/2526433003 Cr-Commit-Position: refs/heads/master@{#434248} (cherry picked from commit b8dc459398704fe6df59e1be0655399085454449) Review URL: https://codereview.chromium.org/2530213002 . Cr-Commit-Position: refs/branch-heads/2883@{#663} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} content/browser/renderer_host/input/touch_action_filter.cc diff]

content/browser/renderer_host/input/touch_action_filter_unittest.cc diff]

commit fadbabf762310ae5d44221c37929dbf4807f5fe9 author clamy <clamy@chromium.org> Fri Nov 25 09:55:42 2016 committer clamy <clamy@chromium.org> Fri Nov 25 09:59:12 2016 Don't update TabSpecificContentSettings on same-page navigation This CL ensures that the TabSpecificContentSettings are not updated when navigating same-page. This fixes an issue where the location tracking icon would disappear when accepting to send location info to Google search. This is because Google search would do a fragment navigation when location tracking was accepted, which would fire DidStartNavigation causing the location information to be reset. Previously, DidStartProvisionalLoad would not be called for a fragment navigation, so the icon would not be reset. For the record, TabSpecificContentSettings was made to use DidStartNavigation in https://codereview.chromium.org/2374443003. BUG=667256 Review-Url: https://codereview.chromium.org/2524053002 Cr-Commit-Position: refs/heads/master@{#434208} (cherry picked from commit d796bf464ffe66b896c8def42b1f916f62da9928) Review URL: https://codereview.chromium.org/2534563002 . Cr-Commit-Position: refs/branch-heads/2883@{#662} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/browser/content_settings/tab_specific_content_settings.cc diff]

commit 9558fbab37401a21a2bb8db86b364d8b8ec221bd author yosin <yosin@chromium.org> Fri Nov 25 07:41:59 2016 committer Commit bot <commit-bot@chromium.org> Fri Nov 25 07:45:07 2016 Fix compilation failure in RangeTest.cpp This patch fixes compilation failure in "RangeTest.cpp" introduced by e4df1d54a0ca2d2274b61db80144f6230c56c0b7 which is merged for fixing [1]. [1] http://crbug.com/666246 BUG=668600 TEST=n/a; no behavior change TBR=ranjitkan@chromium.org, NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2533533003 Cr-Commit-Position: refs/branch-heads/2883@{#661} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} third_party/WebKit/Source/core/dom/RangeTest.cpp diff]

commit f924a45a1c9276a2f145ece28b6d645839997981 author Yuki Shiino <yukishiino@chromium.org> Fri Nov 25 06:03:42 2016 committer Yuki Shiino <yukishiino@chromium.org> Fri Nov 25 06:08:22 2016 binding: Makes Dictionary handle a possible exception in [[Get]]. Dictionary retrieves a dictionary member through the [[Get]] internal method of the dictionary object. Since the properties can be accessor properties, arbitrary script may run in [[Get]], so we have to handle a possible exception in [[Get]]. The right fix is to propagate the exception up to the caller, however, there are so many callers and the issue is urgent. So simply swallowing all the exceptions in this CL, and fix it re-throws in a follow-up CL. BUG=644237 Review-Url: https://codereview.chromium.org/2496533002 Cr-Commit-Position: refs/heads/master@{#431848} (cherry picked from commit 5f971b7bafe1c9a8574e66525b593644e4b9d658) Review URL: https://codereview.chromium.org/2529033002 . Cr-Commit-Position: refs/branch-heads/2883@{#660} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} third_party/WebKit/LayoutTests/fast/dom/dictionary-member-get-throws.html [Added - diff

third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt diff]

third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp diff]

third_party/WebKit/Source/bindings/core/v8/DictionaryIterator.cpp diff]

commit e4df1d54a0ca2d2274b61db80144f6230c56c0b7 author Yoshifumi Inoue <yosin@chromium.org> Fri Nov 25 01:41:16 2016 committer Yoshifumi Inoue <yosin@chromium.org> Fri Nov 25 01:45:00 2016 Make Range::createAdjustedToTreeScope() to handle the shadow root at end of document tree correctly. This patch makes |Range::createAdjustedToTreeScope()| to handle the shadow root at end of document tree correctly. Before this patch |createAdjustedToTreeScope()| to return the |Range| object in shadow tree rather than document tree, since it attempts to check tree scope of null-Node which is computed from collapsed |Range| object of the position after shadow root. This patch uses tree scope of anchor node of specified position instead of first node in range, which is |nullptr| if there is no node after specified position, e.g. |BeforeChildren| of the last node without child nodes, |AfterAnchor| or |AfterChildren| of the last node. The tree scope of position can be determined by anchor node rather than first node in the range because tree scope of child nodes of anchor node is same as anchor node, tree scope of before and after anchor node is also same as anchor node since parent of anchor node and anchor node are in same tree scope. BUG=666246 TEST=run_webkit_unit_tests --gtest_filter=RangeTest.createAdjustedToTreeScopeWithPositionInShadowTree Review-Url: https://codereview.chromium.org/2519323002 Cr-Commit-Position: refs/heads/master@{#433851} (cherry picked from commit 794ce12c31a9d697aaca28e24078c5d9f6edfe59) Review URL: https://codereview.chromium.org/2531483003 . Cr-Commit-Position: refs/branch-heads/2883@{#659} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} third_party/WebKit/Source/core/dom/Range.cpp diff]

third_party/WebKit/Source/core/dom/RangeTest.cpp diff]

commit 8d4cd26b22640b4e381d560cc8f2b3d8e913f96f author chrome-cron <chrome-cron@google.com> Fri Nov 25 01:01:00 2016 committer chrome-cron <chrome-cron@google.com> Fri Nov 25 01:04:11 2016 Incrementing VERSION to 55.0.2883.66 Cr-Commit-Position: refs/branch-heads/2883@{#658} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit be95e49eea298239dcc4de185d9dcca6b8ed79dd author Changwan Ryu <changwan@google.com> Fri Nov 25 00:13:22 2016 committer Changwan Ryu <changwan@google.com> Fri Nov 25 00:17:13 2016 Unfreeze Keyboard app's UI thread on orientation change Some keyboards freeze on some webview apps when the orientation changes. This occurs only when WebView app handles orientation change through Activity#onCreate(), and not through onConfigurationChanged(). Although we call WebView#onViewDetachedFromWindow() -> ImeAdapter#resetAndHideKeyboard() expecting that it will unblock IME thread while waiting for state update from renderer for InputConnection methods, restartInput() may not happen when view gets detached from window using ImeThread feature. This unblocking can be ensured by calling restartInput() and then unblockOnUiThread() in a sequence because by the time the current InputConnection method gets unblocked previous InputConnection will be deactivated. BUG=666982 Review-Url: https://codereview.chromium.org/2519323003 Cr-Commit-Position: refs/heads/master@{#434314} (cherry picked from commit 03d090588235f13ee2e6722c7bab3175eb8ef874) Review URL: https://codereview.chromium.org/2535433002 . Cr-Commit-Position: refs/branch-heads/2883@{#657} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java diff]

commit 1083e74bdc57f0cd9467ade2134ba23daaa3b617 author chrome-cron <chrome-cron@google.com> Thu Nov 24 01:01:00 2016 committer chrome-cron <chrome-cron@google.com> Thu Nov 24 01:03:51 2016 Incrementing VERSION to 55.0.2883.65 Cr-Commit-Position: refs/branch-heads/2883@{#656} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} chrome/VERSION diff]

commit e137796c9c66beb31d49b462339e15d14e79f102 author Steven Bennetts <stevenjb@chromium.org> Wed Nov 23 20:14:41 2016 committer Steven Bennetts <stevenjb@chromium.org> Wed Nov 23 20:18:09 2016 Ensure NetworkHandler is initialized in WifiDataProviderChromeOs BUG=661304 Review-Url: https://codereview.chromium.org/2515363003 Cr-Commit-Position: refs/heads/master@{#433943} (cherry picked from commit 9ae7d75c5f2a4239364e79c0fcbbd64c5795a72f) Review URL: https://codereview.chromium.org/2530683002 . Cr-Commit-Position: refs/branch-heads/2883@{#655} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} device/geolocation/wifi_data_provider_chromeos.cc diff]