Pull request feedback

You test your frontend code, right? And you've got a continuous integration system running, right? Right?

Well you should.

Code review is a lot easier when you have a magical system to say All Is Well. At least in principle. There are limits to testing, but that's a whole different bag of worms.

Today I want to share a little nugget that took hours of interneting to find. Thanks to everyone in this and other Stack Overflow threads for originally figuring it out.

First you will need karma-runner. It is the single best JavaScript test runner I have ever used.

Runs in the background when you're working, re-runs tests on file change, and doesn't care whether you're using Jasmine, Mocha, or something else.

And it's so very very fast.

Next you will need Travis.

Any continuous integration service will do really - I've had great success with Circle CI. But this post is about Travis in particular.

You want something that replicates your environment on a server, runs the tests every time you push to a branch, and shows you the result where it matters most. In the pull request.

When you're working Karma runs in the terminal. That's where you see the output. But the tests themselves run in a browser or two.

You point a browser at http://localhost:9678 and Karma handles the rest.

All fine and good. But you can't do that on Travis. Not directly at least.

People usually resort to PhantomJS. A headless browser that's happy without a GUI. But sometimes your JavaScript doesn't run well in PhantomJS.

I'm currently using CanJS, for instance. It uses a thing that doesn't work in current versions of PhantomJS. It's going to work in the future when PhantomJS catches up. But it doesn't yet.

Chrome is the only option.

Luckily, Travis boxes come with Chrome pre-installed. We just have to tweak our configuration to use it.

First we have to use .travis.yml to convince the shell we've got a screen after all.

before_install : - export CHROME_BIN=chromium - browser - export DISPLAY= : 99.0 - sh - e /etc/init.d/xvfb start

We did three things:

set CHROME_BIN as chromium-browser, because that's what's installed

as chromium-browser, because that's what's installed set up a fake DISPLAY

ran xvfb , which is a sort of GUI environment faker thingy. I'm not certain how it works, but it always shows up in these kinds of things.

Then we uuse karma.conf.js to let Karma know, we need a special browser for Travis.

var configuration = { customLaunchers : { Chrome_travis_ci : { base : "Chrome" , flags : [ "--no-sandbox" ] , } , } , } ; if ( process . env . TRAVIS ) { configuration . browsers = [ "Chrome_travis_ci" ] ; } config . set ( configuration ) ;

We created a custom browser launcher that runs Chrome with the --no-sandbox option. And we only use it if the tests are running in Travis.

Simple.

Our tests run both locally and on Travis. Rejoice!

Karma success

Did you enjoy this article? 👎 👍

Published on January 27th, 2015 in Github, JavaScript, karma, Stack Overflow, Technical, testing

Learned something new?

Want to become a high value JavaScript expert? Here's how it works 👇 Leave your email and I'll send you an Interactive Modern JavaScript Cheatsheet 📖right away. After that you'll get thoughtfully written emails every week about React, JavaScript, and your career. Lessons learned over my 20 years in the industry working with companies ranging from tiny startups to Fortune5 behemoths. Start with an interactive cheatsheet 📖 Then get thoughtful letters 💌 on mindsets, tactics, and technical skills for your career. "Man, love your simple writing! Yours is the only email I open from marketers and only blog that I give a fuck to read & scroll till the end. And wow always take away lessons with me. Inspiring! And very relatable. 👌" ~ Ashish Kumar Your Name Your Email Your Address Subscribe & Become an expert 💌 Join over 10,000 engineers just like you already improving their JS careers with my letters, workshops, courses, and talks. ✌️

Have a burning question that you think I can answer? I don't have all of the answers, but I have some! Hit me up on twitter or book a 30min ama for in-depth help.

Ready to Stop copy pasting D3 examples and create data visualizations of your own? Learn how to build scalable dataviz components your whole team can understand with React for Data Visualization

Curious about Serverless and the modern backend? Check out Serverless Handbook, modern backend for the frontend engineer.

Ready to learn how it all fits together and build a modern webapp from scratch? Learn how to launch a webapp and make your first 💰 on the side with ServerlessReact.Dev

Want to brush up on your modern JavaScript syntax? Check out my interactive cheatsheet: es6cheatsheet.com

By the way, just in case no one has told you it yet today: I love and appreciate you for who you are ❤️