Tachikoma



Offline



Activity: 938

Merit: 1000









Hero MemberActivity: 938Merit: 1000

Re: 300 BTC Coding Contest: Distributed Exchange (MasterCoin Developer Thread) November 12, 2013, 04:55:43 PM #471



Quote from: grazcoin on November 12, 2013, 04:04:16 PM Quote from: Tachikoma on November 12, 2013, 12:50:12 PM Guys I need to amend the validation spec a bit. But to do so I need your opinions.



Right now Bitboy and I deal differently with addresses.



When Mastercoin-explorer displays the addresses for a certain currency_id and an address has not received any transactions for the given currency_id it omits the address from the results. As far as my application is concerned the address does not exist so it can't display it.



BitBoy's implementation however returns the address with a zero balance. Which is technically also correct.



Anybody has a reason to pick one over the other?



I think bitboy's approach is better (same behaviour of blockchain.info).

It means that I will have to change my implementation as well.

I think bitboy's approach is better (same behaviour of blockchain.info).It means that I will have to change my implementation as well.

The problem is that I have no clue how I can find something that doesn't exist. I can't supply addresses that I don't know exist. I could query all currencies (there might be a lot in the future) and use data based on that but that would only bloat the verification-api without any real benefit.



I still vote to omit addresses that have no transactions for a certain currency_id.



Quote from: grazcoin on November 12, 2013, 04:04:16 PM Quote from: Tachikoma on November 12, 2013, 12:50:12 PM

The code news however is that this is already proven useful.



Quote Mastercoin explorer has 2617.47620688 for 1AGFxUanxnWnrTiwLsY4NyvNZTv3RWFnfT but Bitboy has 2617.48620688

Mastercoin explorer has 200 for 1MBrNtFBw9QQ1owGsTs6Nd1iL1Err2H4yp but Bitboy has 199.99

Mastercoin explorer has 757.23987298 for 1Q1sFqsi8S5DxV5hz6sWLamGBp9To93iG7 but Bitboy has 752.23987298



Much easier to find which transactions to fix now.

The code news however is that this is already proven useful.Much easier to find which transactions to fix now.

I will join the comparison game whenever my sell offer/accept parsing is done.

That's a great tool.

I will join the comparison game whenever my sell offer/accept parsing is done.That's a great tool.

Once I finished the code I will put the site online. It should display an overview of all transactions that are parsed differently on all sites, we should all be able to use this. BitBoy some of those transactions are wrong at my site as well. You might actually parse them correctly.The problem is that I have no clue how I can find something that doesn't exist. I can't supply addresses that I don't know exist. I could query all currencies (there might be a lot in the future) and use data based on that but that would only bloat the verification-api without any real benefit.I still vote to omit addresses that have no transactions for a certain currency_id.Once I finished the code I will put the site online. It should display an overview of all transactions that are parsed differently on all sites, we should all be able to use this.