Debian Bug report logs - #717451

Backups broken when "ssh_args" are set

Reported by: Jan-Benedict Glaw <jbglaw@lug-owl.de> Date: Sat, 20 Jul 2013 23:21:01 UTC Severity: important Tags: patch Merged with 721043 Found in versions rsnapshot/1.3.1-4, rsnapshot/1.3.1-7 Fixed in version rsnapshot/1.4.0-1 Done: Guillaume Delacour <gui@iroqwa.org> Bug is archived. No further changes may be made.

Toggle useless messages

Report forwarded to debian-bugs-dist@lists.debian.org, Guillaume Delacour <gui@iroqwa.org> :

Bug#717451 ; Package rsnapshot . (Sat, 20 Jul 2013 23:21:06 GMT) (full text, mbox, link).

Acknowledgement sent to Jan-Benedict Glaw <jbglaw@lug-owl.de> :

New Bug report received and forwarded. Copy sent to Guillaume Delacour <gui@iroqwa.org> . (Sat, 20 Jul 2013 23:21:06 GMT) (full text, mbox, link).

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Jan-Benedict Glaw <jbglaw@lug-owl.de> To: submit@bugs.debian.org Cc: rsnapshot-discuss@lists.sourceforge.net Subject: Backups broken when "ssh_args" are set Date: Sun, 21 Jul 2013 01:17:06 +0200

Package: rsnapshot Version: 1.3.1-4 Hi! (NB: Please keep me Cc'ed. Thanks.) I just updated my backup box and basically all of my rsnapshot jobs are failing. As it seems, a revert for a "bad fix" was pulled into the debian package. While the revertion of the fix will probably fix quite a few problems, it also introduces a new problem when ssh_args are set. I'm usually setting ssh_args to something like: ssh_args -p 2345 -i <identify file> -oBatchMode=yes The non-standard SSH port is to access a number of hosts behind a NATing router, the identity file and BatchMode should be self-explanatory. The former behavior (with the "bad fix" still applied results in a long command line containing rsync ... --rsh="/usr/bin/ssh <my args here>" ... which is parsed by a shell, thus the `"' around the --rsh value are eaten away. In the new behavior, the command array is supplied, which in turn *preserves* the double-quotes for the exec call to rsync. Thus, later on, it's not "/usr/bin/ssh" with a number of argument what's being called, but something like "/usr/bin/ssh -i ....", which of course doesn't exist. It is non-obvious how to get ssh_args right and I think you cannot use them at all right now due to wrong quoting while the --rsh=... argument is prepared. A workaround would be to prepare proper entries in user's ~/.ssh/config file, and removing the ssh_args option alltogether. However, I think that a correct fix to this problem is to simply remove the added `"' while preparing the --rsh argument for rsync in case "ssh_args" is set. With the new way of doing the system() call, supplying an _array_ of single options (instead of a string that needs to be parsed), these quotes are actually the root cause of rsync's wrong parsing of the --rsh option: diff --git a/rsnapshot-program.pl b/rsnapshot-program.pl index dfd7ef6..9d98de5 100755 --- a/rsnapshot-program.pl +++ b/rsnapshot-program.pl @@ -3452,7 +3452,7 @@ sub rsync_backup_point { # if we have any args for SSH, add them if ( defined($ssh_args) ) { - push( @rsync_long_args_stack, "--rsh=\"$config_vars{'cmd_ssh'} $ssh_args\"" ); + push( @rsync_long_args_stack, "--rsh=$config_vars{'cmd_ssh'} $ssh_args" ); # no arguments is the default } else { (This patch is on-top of git://anonscm.debian.org/collab-maint/rsnapshot.git and applies with -40 lines offset on-top of upstream rsnapshot, too.) Thanks, Jan-Benedict -- Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481 Signature of: Alles wird gut! ...und heute wirds schon ein bißchen besser. the second :

Information forwarded to debian-bugs-dist@lists.debian.org, Guillaume Delacour <gui@iroqwa.org> :

Bug#717451 ; Package rsnapshot . (Tue, 23 Jul 2013 18:45:09 GMT) (full text, mbox, link).

Acknowledgement sent to Jan-Benedict Glaw <jbglaw@lug-owl.de> :

Extra info received and forwarded to list. Copy sent to Guillaume Delacour <gui@iroqwa.org> . (Tue, 23 Jul 2013 18:45:09 GMT) (full text, mbox, link).

Message #10 received at 717451@bugs.debian.org (full text, mbox, reply):

From: Jan-Benedict Glaw <jbglaw@lug-owl.de> To: 717451@bugs.debian.org Subject: Re: Bug#717451: Acknowledgement (Backups broken when "ssh_args" are set) Date: Tue, 23 Jul 2013 20:33:30 +0200

Control: severity -1 important I'm changing this bug's severity to important: After update, a formerly working rsnapshot.conf may result in a non-working backup. The old stuff is kept intact (and copied by hardlinks every day), but new/changed files won't get fetched from the source host. This situation can be detected through rsnapshot's exit() value, but probably not all system admins will do that, thus the backup will get more and more outdated over time. MfG, JBG -- Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481 Signature of: Gib Dein Bestes. Dann übertriff Dich selbst! the second :

Severity set to 'important' from 'normal' Request was from Jan-Benedict Glaw <jbglaw@lug-owl.de> to 717451-submit@bugs.debian.org . (Tue, 23 Jul 2013 18:45:09 GMT) (full text, mbox, link).

Information forwarded to debian-bugs-dist@lists.debian.org, debbugs.corlav@spamgourmet.com, Guillaume Delacour <gui@iroqwa.org> :

Bug#717451 ; Package rsnapshot . (Thu, 25 Jul 2013 22:15:05 GMT) (full text, mbox, link).

Acknowledgement sent to "Michel L." <debbugs.corlav@spamgourmet.com> :

Extra info received and forwarded to list. Copy sent to debbugs.corlav@spamgourmet.com, Guillaume Delacour <gui@iroqwa.org> . (Thu, 25 Jul 2013 22:15:05 GMT) (full text, mbox, link).

Message #17 received at 717451@bugs.debian.org (full text, mbox, reply):

From: "Michel L." <debbugs.corlav@spamgourmet.com> To: Debian Bug Tracking System <717451@bugs.debian.org> Subject: Re: Backups broken when "ssh_args" are set Date: Thu, 25 Jul 2013 18:12:31 -0400

Package: rsnapshot Version: 1.3.1-4 Followup-For: Bug #717451 Dear Maintainer, Just want to confirm that rsnapshot is failing here as well. When using ssh_args, for example: ssh_args -o BatchMode=yes -p 1234 I downgraded to rsnapshot 1.3.1-3[0], to get my backups working again. [0] http://snapshot.debian.org/package/rsnapshot/1.3.1-3/#rsnapshot_1.3.1-3 Thanks, Michel -- System Information: Debian Release: jessie/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 3.10-1-amd64 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages rsnapshot depends on: ii liblchown-perl 1.01-1+b2 ii logrotate 3.8.5-1 ii perl 5.14.2-21 ii rsync 3.0.9-4 Versions of packages rsnapshot recommends: ii openssh-client [ssh-client] 1:6.2p2-6 rsnapshot suggests no packages. -- no debconf information

Information forwarded to debian-bugs-dist@lists.debian.org :

Bug#717451 ; Package rsnapshot . (Sun, 28 Jul 2013 16:00:04 GMT) (full text, mbox, link).

Acknowledgement sent to Guillaume Delacour <gui@iroqwa.org> :

Extra info received and forwarded to list. (Sun, 28 Jul 2013 16:00:04 GMT) (full text, mbox, link).

Message #22 received at 717451@bugs.debian.org (full text, mbox, reply):

From: Guillaume Delacour <gui@iroqwa.org> To: "Michel L." <debbugs.corlav@spamgourmet.com>, 717451@bugs.debian.org Cc: jbglaw@lug-owl.de Subject: Re: Bug#717451: Backups broken when "ssh_args" are set Date: Sun, 28 Jul 2013 17:47:08 +0200

Le jeudi 25 juillet 2013 à 18:12 -0400, Michel L. a écrit : > Package: rsnapshot > Version: 1.3.1-4 > Followup-For: Bug #717451 > > Dear Maintainer, > > Just want to confirm that rsnapshot is failing here as well. When using > ssh_args, for example: > > ssh_args -o BatchMode=yes -p 1234 > > > I downgraded to rsnapshot 1.3.1-3[0], to get my backups working again. > > [0] http://snapshot.debian.org/package/rsnapshot/1.3.1-3/#rsnapshot_1.3.1-3 > > You're both right, the ssh args are broken since i've applied the patch 10_space_destdir.diff [0]. The last upstream version is also impacted by this changes [1]. The solution proposed is the same as the first reporter of this bug and upstream is now thinking about a way to properly handle rsync "--rsh=" arguments. As rsnapshot remote backup with ssh is now broken, i'll include the proposed workaround as a countermeasure (at least temporarily). [0]: http://rsnapshot.cvs.sourceforge.net/viewvc/rsnapshot/rsnapshot/rsnapshot-program.pl?revision=1.414&view=markup [1]: https://github.com/DrHyde/rsnapshot/pull/1 -- Guillaume Delacour <gui@iroqwa.org>

Merged 717451 721043 Request was from Guillaume Delacour <gui@iroqwa.org> to control@bugs.debian.org . (Wed, 18 Dec 2013 22:03:04 GMT) (full text, mbox, link).

Information forwarded to debian-bugs-dist@lists.debian.org, Guillaume Delacour <gui@iroqwa.org> :

Bug#717451 ; Package rsnapshot . (Tue, 06 May 2014 12:30:04 GMT) (full text, mbox, link).

Acknowledgement sent to Jan-Benedict Glaw <jbglaw@lug-owl.de> :

Extra info received and forwarded to list. Copy sent to Guillaume Delacour <gui@iroqwa.org> . (Tue, 06 May 2014 12:30:04 GMT) (full text, mbox, link).

Message #29 received at 717451@bugs.debian.org (full text, mbox, reply):

From: Jan-Benedict Glaw <jbglaw@lug-owl.de> To: 717451@bugs.debian.org Subject: New "rsnapshot" package? Date: Tue, 6 May 2014 14:18:03 +0200

Hi Guillaume! It's nearly a year since I submitted a patch for this quite real breakage. Since then, I've patched my boxes, but I would have expected that there's a new rsnapshot package. Could you please prepare one containing the fix and upload it? Thanks, JBG -- Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481 Signature of: Warum ist Scheiße braun? ...weil braun schon immer scheiße ist! the second :

Added tag(s) pending. Request was from Guillaume Delacour <gui@iroqwa.org> to control@bugs.debian.org . (Thu, 04 Sep 2014 09:21:05 GMT) (full text, mbox, link).

Information forwarded to debian-bugs-dist@lists.debian.org, Guillaume Delacour <gui@iroqwa.org> :

Bug#717451 ; Package rsnapshot . (Wed, 04 Mar 2015 21:27:08 GMT) (full text, mbox, link).

Acknowledgement sent to Jan-Benedict Glaw <jbglaw@lug-owl.de> :

Extra info received and forwarded to list. Copy sent to Guillaume Delacour <gui@iroqwa.org> . (Wed, 04 Mar 2015 21:27:09 GMT) (full text, mbox, link).

Message #36 received at 717451@bugs.debian.org (full text, mbox, reply):

From: Jan-Benedict Glaw <jbglaw@lug-owl.de> To: 717451@bugs.debian.org Subject: rsnapshot with ssh_args: Still not fixed? Date: Wed, 4 Mar 2015 22:19:08 +0100

Hi! I just updated one (older) box that's running rsnapshot and realized that the simple patch suggested in this bug still isn't applied. Seems you had planned to do so, would be quite nice if, at some time, you'd push a new .deb containing this fix. After all, it'll soonish be a two year old bug breaking remote backups in non-trivial setups... Thanks a lot, Jan-Benedict -- Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481 Signature of: http://perl.plover.com/Questions.html the second :

Information forwarded to debian-bugs-dist@lists.debian.org, Guillaume Delacour <gui@iroqwa.org> :

Bug#717451 ; Package rsnapshot . (Thu, 19 Mar 2015 15:57:08 GMT) (full text, mbox, link).

Acknowledgement sent to Bernhard Schmidt <berni@birkenwald.de> :

Extra info received and forwarded to list. Copy sent to Guillaume Delacour <gui@iroqwa.org> . (Thu, 19 Mar 2015 15:57:08 GMT) (full text, mbox, link).

Message #41 received at 717451@bugs.debian.org (full text, mbox, reply):

From: Bernhard Schmidt <berni@birkenwald.de> To: 717451@bugs.debian.org, 743310@bugs.debian.org Subject: Update for rsnapshot ssh_args problem Date: Thu, 19 Mar 2015 16:54:41 +0100

Control: tags 717451 - pending Control: tags 717451 + patch Control: tags 743310 - patch Hi, okay, this is confusing me, so I'll try to summarize. #717451 / #721043 are specifically about quoting problems with ssh_args containing spaces. A patch had been added to git to fix this for 1.3.1-5 (hence the 'pending' tag on this bug, which I will remove with this update) http://anonscm.debian.org/cgit/collab-maint/rsnapshot.git/commit/?id=f22cb49a8d76c0856f9a6f66ab17fe436b298f2a unfortunately 1.3.1-5 was never uploaded and the patch was disabled in 1.3.1-5.1 because it was never applied upstream http://anonscm.debian.org/cgit/collab-maint/rsnapshot.git/commit/?id=581e311f4b8095b5d40c829bedba9d60b822b2ae Fundamentally the same patch (but from a different author I believe) has just been included into the "new" upstream repository https://github.com/rsnapshot/rsnapshot/pull/15 https://github.com/rsnapshot/rsnapshot/commit/f0b3b27d174257bf2a8ad29b8c36499bb7b2fb79 So the fix would be there ... unfortunately unstable has already advanced to 1.3.1-6 (while jessie is on 1.3.1-4), and even a targeted fix for 1.3.1-4 would not be allowed right now as far as I understand the freeze policy. Unless someone has the balls to raise the severity to RC, which I'm not sure would be warranted. Or talks to the Release Team. I think it should make it for the first Jessie pointrelease though. #743310 was originally about broken quoting for other options. Christoph Egger updated it with the ssh_args issue and I attached the patch to it, but it will not the issue originally reported in #743310. Hence removing the tags. Best Regards, Bernhard

Removed tag(s) pending. Request was from Bernhard Schmidt <berni@birkenwald.de> to 717451-submit@bugs.debian.org . (Thu, 19 Mar 2015 15:57:08 GMT) (full text, mbox, link).

Added tag(s) patch. Request was from Bernhard Schmidt <berni@birkenwald.de> to 717451-submit@bugs.debian.org . (Thu, 19 Mar 2015 15:57:10 GMT) (full text, mbox, link).

Information forwarded to debian-bugs-dist@lists.debian.org, Guillaume Delacour <gui@iroqwa.org> :

Bug#717451 ; Package rsnapshot . (Sun, 29 Mar 2015 09:45:05 GMT) (full text, mbox, link).

Acknowledgement sent to Simon Josefsson <simon@josefsson.org> :

Extra info received and forwarded to list. Copy sent to Guillaume Delacour <gui@iroqwa.org> . (Sun, 29 Mar 2015 09:45:05 GMT) (full text, mbox, link).

Message #50 received at 717451@bugs.debian.org (full text, mbox, reply):

From: Simon Josefsson <simon@josefsson.org> To: 717451@bugs.debian.org Subject: Workaround Date: Sun, 29 Mar 2015 11:42:24 +0200

I have upgraded my backup server to jessie, and was hit by this bug -- all my backups stopped working. My rsnapshot.conf looked like this: ssh_args -F /backup/.ssh/config and I got the following error in the log file: /usr/bin/rsync -av --delete --numeric-ids --relative --delete-excluded \ --exclude /dev --exclude /proc --exclude /run --exclude /sys \ --rsh="/usr/bin/ssh -F /backup/.ssh/config" root@128.199.37.139:/ \ /backup/chat.josefsson.org/.sync/./ rsync: Failed to exec /usr/bin/ssh -F /backup/.ssh/config: No such file or directory (2) rsync error: error in IPC code (code 14) at pipe.c(85) [Receiver=3.1.1] rsync: connection unexpectedly closed (0 bytes received so far) [Receiver] rsync error: error in IPC code (code 14) at io.c(226) [Receiver=3.1.1] I came up with a workaround, create a small script 'my-ssh' that looks like this: #!/bin/sh exec ssh -F /backup/.ssh/config "$@" and then remove the ssh_args from rsnapshot.conf but add: cmd_ssh /backup/my-ssh This works for me, and hopefully can help others if this bug isn't fixed before jessie is released. /Simon

Information forwarded to debian-bugs-dist@lists.debian.org, Guillaume Delacour <gui@iroqwa.org> :

Bug#717451 ; Package rsnapshot . (Mon, 27 Apr 2015 16:09:08 GMT) (full text, mbox, link).

Acknowledgement sent to Xabi Ezpeleta <xezpeleta@gmail.com> :

Extra info received and forwarded to list. Copy sent to Guillaume Delacour <gui@iroqwa.org> . (Mon, 27 Apr 2015 16:09:08 GMT) (full text, mbox, link).

Message #55 received at 717451@bugs.debian.org (full text, mbox, reply):

From: Xabi Ezpeleta <xezpeleta@gmail.com> To: 717451@bugs.debian.org Subject: Re: Backups broken when "ssh_args" are set Date: Mon, 27 Apr 2015 18:05:23 +0200

Hi, I've just upgraded to Jessie and I have the same problem, all my backups failed. The issue remains even with the last rsnapshot package from Sid (1.3.1-6). If you don't want to downgrade to 1.3.1-4, another possibility is to use the Ubuntu stable package (1.3.1-6ubuntu1). Basically it's the Sid's version, but with the patch 14_rsync_rsh_quoting.diff applied: https://launchpad.net/ubuntu/+source/rsnapshot/1.3.1-6ubuntu1 Is there anything we can do to help fixing this issue in Debian? I was thinking about rebuilding the package applying the patch 14_rsync_rsh_quoting.diff, but I guess the mantainer has a good reason to not doing this. Any idea? Thanks

Information forwarded to debian-bugs-dist@lists.debian.org, Guillaume Delacour <gui@iroqwa.org> :

Bug#717451 ; Package rsnapshot . (Tue, 28 Apr 2015 11:36:04 GMT) (full text, mbox, link).

Acknowledgement sent to John Lewis <oflameo2@gmail.com> :

Extra info received and forwarded to list. Copy sent to Guillaume Delacour <gui@iroqwa.org> . (Tue, 28 Apr 2015 11:36:04 GMT) (full text, mbox, link).

Message #60 received at 717451@bugs.debian.org (full text, mbox, reply):

From: John Lewis <oflameo2@gmail.com> To: 717451@bugs.debian.org Subject: Re: Backups broken when "ssh_args" are set Date: Tue, 28 Apr 2015 07:33:29 -0400

I am having this issue too and I will be forced to create a FrankenDebian as well if this isn't patched within the month. On Mon, 27 Apr 2015 18:05:23 +0200 Xabi Ezpeleta <xezpeleta@gmail.com> wrote: > Hi, > > I've just upgraded to Jessie and I have the same problem, all my backups > failed. The issue remains even with the last rsnapshot package from Sid > (1.3.1-6). > > If you don't want to downgrade to 1.3.1-4, another possibility is to use > the Ubuntu stable package (1.3.1-6ubuntu1). Basically it's the Sid's > version, but with the patch 14_rsync_rsh_quoting.diff applied: > > https://launchpad.net/ubuntu/+source/rsnapshot/1.3.1-6ubuntu1 > > Is there anything we can do to help fixing this issue in Debian? I was > thinking about rebuilding the package applying the patch > 14_rsync_rsh_quoting.diff, but I guess the mantainer has a good reason to > not doing this. > > Any idea? > > Thanks

Information forwarded to debian-bugs-dist@lists.debian.org, Guillaume Delacour <gui@iroqwa.org> :

Bug#717451 ; Package rsnapshot . (Tue, 28 Apr 2015 11:45:08 GMT) (full text, mbox, link).

Acknowledgement sent to John Lewis <oflameo2@gmail.com> :

Extra info received and forwarded to list. Copy sent to Guillaume Delacour <gui@iroqwa.org> . (Tue, 28 Apr 2015 11:45:08 GMT) (full text, mbox, link).

Message #65 received at 717451@bugs.debian.org (full text, mbox, reply):

From: John Lewis <oflameo2@gmail.com> To: 717451@bugs.debian.org Subject: Re: Backups broken when "ssh_args" are set Date: Tue, 28 Apr 2015 07:42:41 -0400

I just upgraded my backup machine to jessie and I am having the same problem. I am going to have to find an alternate package now.

Information forwarded to debian-bugs-dist@lists.debian.org, Guillaume Delacour <gui@iroqwa.org> :

Bug#717451 ; Package rsnapshot . (Sun, 03 May 2015 10:09:04 GMT) (full text, mbox, link).

Acknowledgement sent to Bernhard Schmidt <berni@birkenwald.de> :

Extra info received and forwarded to list. Copy sent to Guillaume Delacour <gui@iroqwa.org> . (Sun, 03 May 2015 10:09:04 GMT) (full text, mbox, link).

Message #70 received at 717451@bugs.debian.org (full text, mbox, reply):

From: Bernhard Schmidt <berni@birkenwald.de> To: 717451@bugs.debian.org, Guillaume Delacour <gui@iroqwa.org>, Hans-Christoph Steiner <hans@eds.org> Subject: Re: Bug#717451: rsnapshot Backups broken when "ssh_args" are set Date: Sun, 03 May 2015 12:05:13 +0200

Hi, this bug seems to affect a lot of people and seems to be a good candidate for the next Jessie pointrelease. Unfortunately sid is still affected, and it is often requested to have this fixed in sid first before a spu is submitted. The window for that likely closes within two weeks. The patch was included in by Guillaume Delacour between 1.3.1-4 and 1.3.1-5 (never released) commit f22cb49a8d76c0856f9a6f66ab17fe436b298f2a Author: Guillaume Delacour <gui@iroqwa.org> Date: Wed Jul 31 21:30:48 2013 +0200 Fix rsh ssh quoting issue (#717451) and two other minor bugs (#718189 & #717940) It was disabled again by Hans-Christoph Steiner before 1.3.1-5.1 commit 581e311f4b8095b5d40c829bedba9d60b822b2ae Author: Hans-Christoph Steiner <hans@eds.org> Date: Tue Oct 21 14:25:29 2014 -0400 do not apply 14_rsync_rsh_quoting.diff, it was never included upstream The patch has been merged upstream on March 25th in https://github.com/rsnapshot/rsnapshot/commit/f0b3b27d174257bf2a8ad29b8c36499bb7b2fb79. This is the official git repository, it is linked from http://rsnapshot.org . Also according to the comment to #717451 by Xabi Ezpeleta the patch has been reenabled and shipping with Ubuntu Vivid. https://launchpad.net/ubuntu/+source/rsnapshot/1.3.1-6ubuntu1 So, it would be highly appreciated if someone could push 1.3.1-7 with that patch reenabled to sid and prepare a spu with that patch. Bernhard

Information forwarded to debian-bugs-dist@lists.debian.org, Guillaume Delacour <gui@iroqwa.org> :

Bug#717451 ; Package rsnapshot . (Wed, 06 May 2015 00:15:04 GMT) (full text, mbox, link).

Acknowledgement sent to John Lewis <oflameo2@gmail.com> :

Extra info received and forwarded to list. Copy sent to Guillaume Delacour <gui@iroqwa.org> . (Wed, 06 May 2015 00:15:04 GMT) (full text, mbox, link).

Message #75 received at 717451@bugs.debian.org (full text, mbox, reply):

From: John Lewis <oflameo2@gmail.com> To: 717451@bugs.debian.org Subject: Re: Backups broken when "ssh_args" are set Date: Tue, 05 May 2015 20:12:49 -0400

On 04/28/2015 07:42 AM, John Lewis wrote: > I just upgraded my backup machine to jessie and I am having the same > problem. > > > I am going to have to find an alternate package now. > No alternate package was needed, because the patch was in the source package. Here is how I applied the patch and rebuilt the package. apt-get source rsnapshot cd rsnapshot-* ls debian/patches vim debian/patches/series add 14_rsync_rsh_quoting.diff after 13_print_warn.diff quilt series #check to see if patch is in series quilt pop -a quilt push -a quilt applied #check to see if patch is applied debuild -b -uc -us cd .. sudo dpkg -i rsnapshot.deb

Information forwarded to debian-bugs-dist@lists.debian.org, Guillaume Delacour <gui@iroqwa.org> :

Bug#717451 ; Package rsnapshot . (Thu, 07 May 2015 15:45:04 GMT) (full text, mbox, link).

Acknowledgement sent to Xabi Ezpeleta <xezpeleta@gmail.com> :

Extra info received and forwarded to list. Copy sent to Guillaume Delacour <gui@iroqwa.org> . (Thu, 07 May 2015 15:45:04 GMT) (full text, mbox, link).

Message #80 received at 717451@bugs.debian.org (full text, mbox, reply):

From: Xabi Ezpeleta <xezpeleta@gmail.com> To: 717451@bugs.debian.org Subject: Re: Bug#717451: rsnapshot Backups broken when "ssh_args" are set Date: Thu, 7 May 2015 17:42:02 +0200

Here is the debdiff with the changes

Information forwarded to debian-bugs-dist@lists.debian.org, Guillaume Delacour <gui@iroqwa.org> :

Bug#717451 ; Package rsnapshot . (Sun, 10 May 2015 01:18:05 GMT) (full text, mbox, link).

Acknowledgement sent to John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> :

Extra info received and forwarded to list. Copy sent to Guillaume Delacour <gui@iroqwa.org> . (Sun, 10 May 2015 01:18:05 GMT) (full text, mbox, link).

Message #85 received at 717451@bugs.debian.org (full text, mbox, reply):

From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> To: Xabi Ezpeleta <xezpeleta@gmail.com> Cc: 717451@bugs.debian.org Subject: Re: Bug#717451: rsnapshot Backups broken when "ssh_args" are set Date: Sun, 10 May 2015 03:14:48 +0200

Hello! That debdiff is incomplete. The description in the changelog of the changes is insufficient and the actual patch is missing as well. Has this issue been fixed upstream already? If yes, we could just cherrypick the patch or upload a new upstream version. Cheers, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

Information forwarded to debian-bugs-dist@lists.debian.org :

Bug#717451 ; Package rsnapshot . (Sun, 10 May 2015 16:06:10 GMT) (full text, mbox, link).

Acknowledgement sent to Guillaume Delacour <gui@iroqwa.org> :

Extra info received and forwarded to list. (Sun, 10 May 2015 16:06:10 GMT) (full text, mbox, link).

Message #90 received at 717451@bugs.debian.org (full text, mbox, reply):

From: Guillaume Delacour <gui@iroqwa.org> To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>, 717451@bugs.debian.org Cc: Xabi Ezpeleta <xezpeleta@gmail.com> Subject: Re: Bug#717451: rsnapshot Backups broken when "ssh_args" are set Date: Sun, 10 May 2015 17:56:56 +0200

Le dimanche 10 mai 2015 à 03:14 +0200, John Paul Adrian Glaubitz a écrit : > Hello! Hi, > > That debdiff is incomplete. The description in the changelog of the > changes is insufficient and the actual patch is missing as well. > > Has this issue been fixed upstream already? If yes, we could just > cherrypick the patch or upload a new upstream version. I've asked the release team to include the patch for fixing this issue. I'm waiting for them to propose the fixed package (but i maybe have to include it into unstable before). > > Cheers, > Adrian > -- Guillaume Delacour <gui@iroqwa.org>

Information forwarded to debian-bugs-dist@lists.debian.org, Guillaume Delacour <gui@iroqwa.org> :

Bug#717451 ; Package rsnapshot . (Thu, 21 May 2015 15:15:05 GMT) (full text, mbox, link).

Acknowledgement sent to Jan-Benedict Glaw <jbglaw@lug-owl.de> :

Extra info received and forwarded to list. Copy sent to Guillaume Delacour <gui@iroqwa.org> . (Thu, 21 May 2015 15:15:05 GMT) (full text, mbox, link).

Message #95 received at 717451@bugs.debian.org (full text, mbox, reply):

From: Jan-Benedict Glaw <jbglaw@lug-owl.de> To: 717451@bugs.debian.org Subject: Re: Bug#717451: rsnapshot Backups broken when "ssh_args" are set Date: Thu, 21 May 2015 17:02:20 +0200

Hi! I would HIGHLY appreciate to see this patch in unstable. Actually, I don't even really care about `testing' and `stable', since most of my machines run a constantly updates `unstable' distribution. Actually, I don't even see a reason why this patch wasn't put into unstable about two years ago... It fixed an observeable bug and thus should have been in there, whether or not upstream picked it or not. Over the time, it's just a one package that I need to actually take care of and keep in mind that, if it's updated, I need to inspect it for the fix to be applied (and possibly apply it manually.) With the recent distro update, the problem got imminent since a number of people upgraded to the "broken" version. Thanks god it's biting only those who have a well-thought backup infrastructure, since (I guess) most people will run it locally, or by hand (accepting a password prompt) or with ssh-agent running. So please, just enable that one-liner patch and upload to unstable at least. And then, target the testing/stable distros. Even there, it's for sure a candidate, since it breaks actual installations and I consider a working backup as a quite important thing to have. MfG, JBG -- Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481 Signature of: 17:45 <@Eimann> Hrm, das E90 hat keinen Lebenszeit Call-Time Counter mehr the second : 17:46 <@jbglaw> Eimann: Wofür braucht man das? 17:46 <@jbglaw> Eimann: Für mich ist an 'nem Handy wichtig, daß ich mein Gegeüber hören kann. Und daß mein Gegenüber mich versteht... 17:47 <@KrisK> jbglaw: was du meinst ist wodka. 17:47 <@KrisK> jbglaw: es klingelt und man hört stimmen

Reply sent to Guillaume Delacour <gui@iroqwa.org> :

You have taken responsibility. (Mon, 25 May 2015 21:45:15 GMT) (full text, mbox, link).

Notification sent to Jan-Benedict Glaw <jbglaw@lug-owl.de> :

Bug acknowledged by developer. (Mon, 25 May 2015 21:45:16 GMT) (full text, mbox, link).

Message #100 received at 717451-close@bugs.debian.org (full text, mbox, reply):

From: Guillaume Delacour <gui@iroqwa.org> To: 717451-close@bugs.debian.org Subject: Bug#717451: fixed in rsnapshot 1.3.1-7 Date: Mon, 25 May 2015 21:42:12 +0000

Source: rsnapshot Source-Version: 1.3.1-7 We believe that the bug you reported is fixed in the latest version of rsnapshot, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 717451@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Guillaume Delacour <gui@iroqwa.org> (supplier of updated rsnapshot package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmaster@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Mon, 11 May 2015 22:23:50 +0200 Source: rsnapshot Binary: rsnapshot Architecture: source all Version: 1.3.1-7 Distribution: unstable Urgency: medium Maintainer: Guillaume Delacour <gui@iroqwa.org> Changed-By: Guillaume Delacour <gui@iroqwa.org> Description: rsnapshot - local and remote filesystem snapshot utility Closes: 660372 717451 720509 743310 743777 745963 767124 Changes: rsnapshot (1.3.1-7) unstable; urgency=medium . * Remove obsolete conffiles anacron scripts (Closes: #767124) * debian/patches/14_rsync_rsh_quoting.diff: Don't quote ssh_args arguments (Closes: #717451, #743310, LP: #1332753, #1400283) * debian/patches/16_configtest_manpage.diff: Document configtest option (Closes: #720509) * debian/patches/17_linux_lvm_cmd_lvremove_silenced.diff: lvremove is not silenced when using lvm, thanks Julius Seemayer (Closes: #745963), (LP: #1353972) * debian/rules: Skip compression of .pl examples files (Closes: #743777) * debian/patches/18_rsnapreport_rsync_output.diff: Modify regexp to parse rsync output that changes between 3.0.x and 3.1.x, thanks Dominik George * debian/patches/19_cmd_postexec_umount.diff: Allow unmounting of snapshot root by cmd_postexec config option, thanks Mike Gabriel (Closes: #660372) Checksums-Sha1: a8fd17f8706d0bf740cf1a9d3919b626c087791e 2010 rsnapshot_1.3.1-7.dsc a384484e640581d13d5fbd1331ccc59692a45cbb 17096 rsnapshot_1.3.1-7.debian.tar.xz 69be90b01d75fff7bb1ac81f0981d7b02656ae5a 128388 rsnapshot_1.3.1-7_all.deb Checksums-Sha256: b99e0fa831003746a62ff3343f3e0c3ca00780fe8e01d7630066884c6d18cb5e 2010 rsnapshot_1.3.1-7.dsc f4e6632e0dd87d78144b48e312b0b4f3376504ada28c2f5a7d5b738b2636c977 17096 rsnapshot_1.3.1-7.debian.tar.xz 5552e6ee7ff634fc980519a048a82734ec5dc72ae538cbefae584b4d2039c204 128388 rsnapshot_1.3.1-7_all.deb Files: 4f49caa9e1e584c8f6303aa270959fd9 2010 utils optional rsnapshot_1.3.1-7.dsc 0cd1b1d687a4b5494b14dc82fe22ffff 17096 utils optional rsnapshot_1.3.1-7.debian.tar.xz 1b9650132925c9ac2d13cbbcb69f336b 128388 utils optional rsnapshot_1.3.1-7_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Signed by Ana Guerrero iQIcBAEBCAAGBQJVY4tTAAoJELNGT4lqoVlIMhwP/jZpcBqWsvE3G/QIMAgQ3KoP DhEDOXH3c/eOyoFcUVTXraSXvEqyuCbbCu56QKEqVVOv6VTrS+bEQ16OSuHvd4L5 j+uC8Lp19GuRd1OnLUJ6cYCKN9D6TM4tPY0L3EWxsqQj1eHKDZ9KEDy9ZV5BL/Hp LMWNv/4JinVlH9aCqUaGiZn3TY+3XmnsZ2YDQuw/y46DbPg6FEd0pESl4X0E5MrP s9L01SaVvfI6eh93MbI0JwKy67gMbr7BTuPFLSCTVzbRi29wYsl539poBjkCkb9l 3Dnqi/dPDWQN/2qCK9rzgiZSMsZvUTmMiQGHrHzPkx3XAypSdiQnKZV29u0ckasq p1OISWNaDiNF9UpNS+ot6yXGC2IJp9RPTsSZnHAnHe73oM3MDIKTO+2WLjPeXlBH gGNPQsxf2DOa4rLub8NhKVDok3zxKeMvRMnYp9qiouVU4cIUq0i2cCBBbzypd/Es b3QvpW9NXgIh5m2Rmd2DzK8a4e1anohwgo77Yy3FNE48nJsWGqkE7NxDRNASQLda EHm8fBQRviWhnacjdjW25QZxSEzxgfbIqyutr1zGXUmadv+i72OSE/PZKO+g3q7e Ed3Wx6NJCuaR8K7/3DKWoyCdZwpD4D/JEH3RAM8vr2lZaFepqGBzTKBHQnXJUzuZ ees5sdX8qR2sdZU7Ms7f =oqO4 -----END PGP SIGNATURE-----

Reply sent to Guillaume Delacour <gui@iroqwa.org> :

You have taken responsibility. (Mon, 25 May 2015 21:45:16 GMT) (full text, mbox, link).

Notification sent to Samuel Smith <leon36@gmail.com> :

Bug acknowledged by developer. (Mon, 25 May 2015 21:45:16 GMT) (full text, mbox, link).

Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org . (Sun, 28 Jun 2015 07:28:58 GMT) (full text, mbox, link).

Bug unarchived. Request was from synth17@gmail.com to control@bugs.debian.org . (Wed, 15 Jul 2015 23:30:05 GMT) (full text, mbox, link).

Marked as found in versions rsnapshot/1.3.1-7; no longer marked as fixed in versions rsnapshot/1.3.1-7 and reopened. Request was from synth17@gmail.com to control@bugs.debian.org . (Wed, 15 Jul 2015 23:30:06 GMT) (full text, mbox, link).

Information forwarded to debian-bugs-dist@lists.debian.org, synth17+deb-bugs@gmail.com, Guillaume Delacour <gui@iroqwa.org> :

Bug#717451 ; Package rsnapshot . (Wed, 15 Jul 2015 23:45:04 GMT) (full text, mbox, link).

Acknowledgement sent to Michel <synth17+deb-bugs@gmail.com> :

Extra info received and forwarded to list. Copy sent to synth17+deb-bugs@gmail.com, Guillaume Delacour <gui@iroqwa.org> . (Wed, 15 Jul 2015 23:45:04 GMT) (full text, mbox, link).

Message #115 received at 717451@bugs.debian.org (full text, mbox, reply):

From: Michel <synth17+deb-bugs@gmail.com> To: Debian Bug Tracking System <717451@bugs.debian.org> Subject: Re: Backups broken when "ssh_args" are set Date: Wed, 15 Jul 2015 19:42:21 -0400

Package: rsnapshot Version: 1.3.1-7 Followup-For: Bug #717451 Dear Maintainer, After upgrading rsnapshot to 1.3.1-7, remote backups still fail. Local backups work as expected. The upgrade occurred on 06/24/2015, and every remote backup since then have failed. Have been extremely busy and have not checked local email, until today. To my surprise, have no remote backups since 06/24. # rsnapshot -vvvvc /etc/rsnapshot/x220-rsnapshot.conf hourly Unexpected remote arg: root@x220:/ rsync error: syntax or usage error (code 1) at main.c(1348) [sender=3.1.1] ---------------------------------------------------------------------------- rsnapshot encountered an error! The program was invoked with these options: /usr/bin/rsnapshot -vvvvc /etc/rsnapshot/x220-rsnapshot.conf hourly ---------------------------------------------------------------------------- ERROR: /usr/bin/rsync returned 1 while processing root@x220:/ As before[0], downgrading to rsnapshot 1.3.1-3 and remote backups are working again. [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=717451#17 Perhaps bug #786854 is related to this one? [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=786854 Thank You -- System Information: Debian Release: stretch/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages rsnapshot depends on: ii liblchown-perl 1.01-3 ii logrotate 3.8.7-2 ii perl 5.20.2-6 ii rsync 3.1.1-3 Versions of packages rsnapshot recommends: ii openssh-client [ssh-client] 1:6.7p1-6 rsnapshot suggests no packages. -- no debconf information

Marked as fixed in versions rsnapshot/1.4.0-1. Request was from Guillaume Delacour <gui@iroqwa.org> to control@bugs.debian.org . (Sun, 19 Jul 2015 20:15:03 GMT) (full text, mbox, link).

Information forwarded to debian-bugs-dist@lists.debian.org :

Bug#717451 ; Package rsnapshot . (Sun, 19 Jul 2015 20:21:03 GMT) (full text, mbox, link).

Acknowledgement sent to Guillaume Delacour <gui@iroqwa.org> :

Extra info received and forwarded to list. (Sun, 19 Jul 2015 20:21:03 GMT) (full text, mbox, link).

Message #122 received at 717451@bugs.debian.org (full text, mbox, reply):

From: Guillaume Delacour <gui@iroqwa.org> To: 717451@bugs.debian.org, 717451-done@bugs.debian.org, control@bugs.debian.org Subject: Re: Backups broken when "ssh_args" are set Date: Sun, 19 Jul 2015 22:12:32 +0200

fixed 717451 1.4.0-1 thanks On Wed, 15 Jul 2015 19:42:21 -0400 Michel <synth17+deb-bugs@gmail.com> wrote: > Package: rsnapshot > Version: 1.3.1-7 > Followup-For: Bug #717451 > > > Dear Maintainer, > > After upgrading rsnapshot to 1.3.1-7, remote backups still fail. Local > backups work as expected. The upgrade occurred on 06/24/2015, and every > remote backup since then have failed. Have been extremely busy and have > not checked local email, until today. To my surprise, have no remote > backups since 06/24. > > I've pushed the 1.4.0-1 release that fix that kind of problem. Feel free to reopen if it is not the case. -- Guillaume Delacour

Reply sent to Guillaume Delacour <gui@iroqwa.org> :

You have taken responsibility. (Sun, 19 Jul 2015 20:21:11 GMT) (full text, mbox, link).

Notification sent to Jan-Benedict Glaw <jbglaw@lug-owl.de> :

Bug acknowledged by developer. (Sun, 19 Jul 2015 20:21:11 GMT) (full text, mbox, link).

Reply sent to Guillaume Delacour <gui@iroqwa.org> :

You have taken responsibility. (Sun, 19 Jul 2015 20:21:12 GMT) (full text, mbox, link).

Notification sent to Samuel Smith <leon36@gmail.com> :

Bug acknowledged by developer. (Sun, 19 Jul 2015 20:21:12 GMT) (full text, mbox, link).

Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org . (Sat, 22 Aug 2015 07:32:40 GMT) (full text, mbox, link).

Send a report that this bug log contains spam.