DALLAS—President Trump spoke to a cheering crowd at the National Rifle Association’s annual conference in May, saying gun owners had no stronger ally than the president and the Republican majority in Congress.

For gun makers, it turns out, this is a mixed blessing.

Since Mr. Trump’s 2016 victory, sales have slowed, particularly for the top-selling...