Domain Module Postmortem

Usability Issues

Implicit Behavior

It's possible for a developer to create a new domain and then simply run domain.enter() . Which then acts as a catch-all for any exception in the future that couldn't be observed by the thrower. Allowing a module author to intercept the exceptions of unrelated code in a different module. Preventing the originator of the code from knowing about its own exceptions.

Here's an example of how one indirectly linked modules can affect another:

const b = require ( './b' ) ; const c = require ( './c' ) ; const d = require ( 'domain' ) . create ( ) ; d . on ( 'error' , ( ) => { } ) ; d . enter ( ) ; const dep = require ( 'some-dep' ) ; dep . method ( ) ;

Since module b enters the domain but never exits any uncaught exception will be swallowed. Leaving module c in the dark as to why it didn't run the entire script. Leaving a potentially partially populated module.exports . Doing this is not the same as listening for 'uncaughtException' . As the latter is explicitly meant to globally catch errors. The other issue is that domains are processed prior to any 'uncaughtException' handlers, and prevent them from running.

Another issue is that domains route errors automatically if no 'error' handler was set on the event emitter. There is no opt-in mechanism for this, and automatically propagates across the entire asynchronous chain. This may seem useful at first, but once asynchronous calls are two or more modules deep and one of them doesn't include an error handler the creator of the domain will suddenly be catching unexpected exceptions, and the thrower's exception will go unnoticed by the author.

The following is a simple example of how a missing 'error' handler allows the active domain to hijack the error:

const domain = require ( 'domain' ) ; const net = require ( 'net' ) ; const d = domain . create ( ) ; d . on ( 'error' , ( err ) => console . error ( err . message ) ) ; d . run ( ( ) => net . createServer ( ( c ) => { c . end ( ) ; c . write ( 'bye' ) ; } ) . listen ( 8000 ) ) ;

Even manually removing the connection via d.remove(c) does not prevent the connection's error from being automatically intercepted.

Failures that plagues both error routing and exception handling are the inconsistencies in how errors are bubbled. The following is an example of how nested domains will and won't bubble the exception based on when they happen:

const domain = require ( 'domain' ) ; const net = require ( 'net' ) ; const d = domain . create ( ) ; d . on ( 'error' , ( ) => console . error ( 'd intercepted an error' ) ) ; d . run ( ( ) => { const server = net . createServer ( ( c ) => { const e = domain . create ( ) ; e . run ( ( ) => { setImmediate ( ( ) => { throw new Error ( 'thrown from setImmediate' ) ; } ) ; throw new Error ( 'immediately thrown' ) ; } ) ; } ) . listen ( 8080 ) ; } ) ;

It may be expected that nested domains always remain nested, and will always propagate the exception up the domain stack. Or that exceptions will never automatically bubble. Unfortunately both these situations occur, leading to potentially confusing behavior that may even be prone to difficult to debug timing conflicts.

API Gaps

While APIs based on using EventEmitter can use bind() and errback style callbacks can use intercept() , alternative APIs that implicitly bind to the active domain must be executed inside of run() . Meaning if module authors wanted to support domains using a mechanism alternative to those mentioned they must manually implement domain support themselves. Instead of being able to leverage the implicit mechanisms already in place.

Error Propagation

Propagating errors across nested domains is not straight forward, if even possible. Existing documentation shows a simple example of how to close() an http server if there is an error in the request handler. What it does not explain is how to close the server if the request handler creates another domain instance for another async request. Using the following as a simple example of the failing of error propagation:

const d1 = domain . create ( ) ; d1 . foo = true ; d1 . on ( 'error' , ( er ) => { } ) ; d1 . run ( ( ) => setTimeout ( ( ) => { const d2 = domain . create ( ) ; d2 . bar = 43 ; d2 . on ( 'error' , ( er ) => console . error ( er . message , domain . _stack ) ) ; d2 . run ( ( ) => { setTimeout ( ( ) => { setTimeout ( ( ) => { throw new Error ( 'outer' ) ; } ) ; throw new Error ( 'inner' ) ; } ) ; } ) ; } ) ) ;

Even in the case that the domain instances are being used for local storage so access to resources are made available there is still no way to allow the error to continue propagating from d2 back to d1 . Quick inspection may tell us that simply throwing from d2 's domain 'error' handler would allow d1 to then catch the exception and execute its own error handler. Though that is not the case. Upon inspection of domain._stack you'll see that the stack only contains d2 .

This may be considered a failing of the API, but even if it did operate in this way there is still the issue of transmitting the fact that a branch in the asynchronous execution has failed, and that all further operations in that branch must cease. In the example of the http request handler, if we fire off several asynchronous requests and each one then write() 's data back to the client many more errors will arise from attempting to write() to a closed handle. More on this in Resource Cleanup on Exception.

Resource Cleanup on Exception

The following script contains a more complex example of properly cleaning up in a small resource dependency tree in the case that an exception occurs in a given connection or any of its dependencies. Breaking down the script into its basic operations:

'use strict' ; const domain = require ( 'domain' ) ; const EE = require ( 'events' ) ; const fs = require ( 'fs' ) ; const net = require ( 'net' ) ; const util = require ( 'util' ) ; const print = process . _rawDebug ; const pipeList = [ ] ; const FILENAME = '/tmp/tmp.tmp' ; const PIPENAME = '/tmp/node-domain-example-' ; const FILESIZE = 1024 ; let uid = 0 ; const buf = Buffer . alloc ( FILESIZE ) ; for ( let i = 0 ; i < buf . length ; i ++ ) buf [ i ] = ( ( Math . random ( ) * 1e3 ) % 78 ) + 48 ; fs . writeFileSync ( FILENAME , buf ) ; function ConnectionResource ( c ) { EE . call ( this ) ; this . _connection = c ; this . _alive = true ; this . _domain = domain . create ( ) ; this . _id = Math . random ( ) . toString ( 32 ) . substr ( 2 ) . substr ( 0 , 8 ) + ( ++ uid ) ; this . _domain . add ( c ) ; this . _domain . on ( 'error' , ( ) => { this . _alive = false ; } ) ; } util . inherits ( ConnectionResource , EE ) ; ConnectionResource . prototype . end = function end ( chunk ) { this . _alive = false ; this . _connection . end ( chunk ) ; this . emit ( 'end' ) ; } ; ConnectionResource . prototype . isAlive = function isAlive ( ) { return this . _alive ; } ; ConnectionResource . prototype . id = function id ( ) { return this . _id ; } ; ConnectionResource . prototype . write = function write ( chunk ) { this . emit ( 'data' , chunk ) ; return this . _connection . write ( chunk ) ; } ; net . createServer ( ( c ) => { const cr = new ConnectionResource ( c ) ; const d1 = domain . create ( ) ; fs . open ( FILENAME , 'r' , d1 . intercept ( ( fd ) => { streamInParts ( fd , cr , 0 ) ; } ) ) ; pipeData ( cr ) ; c . on ( 'close' , ( ) => cr . end ( ) ) ; } ) . listen ( 8080 ) ; function streamInParts ( fd , cr , pos ) { const d2 = domain . create ( ) ; const alive = true ; d2 . on ( 'error' , ( er ) => { print ( 'd2 error:' , er . message ) ; cr . end ( ) ; } ) ; fs . read ( fd , Buffer . alloc ( 10 ) , 0 , 10 , pos , d2 . intercept ( ( bRead , buf ) => { if ( ! cr . isAlive ( ) ) { return fs . close ( fd ) ; } if ( cr . _connection . bytesWritten < FILESIZE ) { const goodtogo = cr . write ( buf ) ; if ( goodtogo ) { setTimeout ( ( ) => streamInParts ( fd , cr , pos + bRead ) , 1000 ) ; } else { cr . _connection . once ( 'drain' , ( ) => streamInParts ( fd , cr , pos + bRead ) ) ; } return ; } cr . end ( buf ) ; fs . close ( fd ) ; } ) ) ; } function pipeData ( cr ) { const pname = PIPENAME + cr . id ( ) ; const ps = net . createServer ( ) ; const d3 = domain . create ( ) ; const connectionList = [ ] ; d3 . on ( 'error' , ( er ) => { print ( 'd3 error:' , er . message ) ; cr . end ( ) ; } ) ; d3 . add ( ps ) ; ps . on ( 'connection' , ( conn ) => { connectionList . push ( conn ) ; conn . on ( 'data' , ( ) => { } ) ; conn . on ( 'close' , ( ) => { connectionList . splice ( connectionList . indexOf ( conn ) , 1 ) ; } ) ; } ) ; cr . on ( 'data' , ( chunk ) => { for ( let i = 0 ; i < connectionList . length ; i ++ ) { connectionList [ i ] . write ( chunk ) ; } } ) ; cr . on ( 'end' , ( ) => { for ( let i = 0 ; i < connectionList . length ; i ++ ) { connectionList [ i ] . end ( ) ; } ps . close ( ) ; } ) ; pipeList . push ( pname ) ; ps . listen ( pname ) ; } process . on ( 'SIGINT' , ( ) => process . exit ( ) ) ; process . on ( 'exit' , ( ) => { try { for ( let i = 0 ; i < pipeList . length ; i ++ ) { fs . unlinkSync ( pipeList [ i ] ) ; } fs . unlinkSync ( FILENAME ) ; } catch ( e ) { } } ) ;

When a new connection happens, concurrently: Open a file on the file system Open Pipe to unique socket

Read a chunk of the file asynchronously

Write chunk to both the TCP connection and any listening sockets

If any of these resources error, notify all other attached resources that they need to clean up and shutdown

As we can see from this example a lot more must be done to properly clean up resources when something fails than what can be done strictly through the domain API. All that domains offer is an exception aggregation mechanism. Even the potentially useful ability to propagate data with the domain is easily countered, in this example, by passing the needed resources as a function argument.

One problem domains perpetuated was the supposed simplicity of being able to continue execution, contrary to what the documentation stated, of the application despite an unexpected exception. This example demonstrates the fallacy behind that idea.

Attempting proper resource cleanup on unexpected exception becomes more complex as the application itself grows in complexity. This example only has 3 basic resources in play, and all of them with a clear dependency path. If an application uses something like shared resources or resource reuse the ability to cleanup, and properly test that cleanup has been done, grows greatly.

In the end, in terms of handling errors, domains aren't much more than a glorified 'uncaughtException' handler. Except with more implicit and unobservable behavior by third-parties.

Resource Propagation

Another use case for domains was to use it to propagate data along asynchronous data paths. One problematic point is the ambiguity of when to expect the correct domain when there are multiple in the stack (which must be assumed if the async stack works with other modules). Also the conflict between being able to depend on a domain for error handling while also having it available to retrieve the necessary data.

The following is a involved example demonstrating the failing using domains to propagate data along asynchronous stacks:

const domain = require ( 'domain' ) ; const net = require ( 'net' ) ; const server = net . createServer ( ( c ) => { const d = domain . create ( ) ; d . data = { connection : c } ; d . add ( c ) ; const ds = new DataStream ( dataTransformed ) ; c . on ( 'data' , ( chunk ) => ds . data ( chunk ) ) ; } ) . listen ( 8080 , ( ) => console . log ( 'listening on 8080' ) ) ; function dataTransformed ( chunk ) { domain . active . data . connection . write ( chunk ) ; } function DataStream ( cb ) { this . cb = cb ; this . domain = domain . create ( ) ; this . domain . data = { inst : this } ; } DataStream . prototype . data = function data ( chunk ) { this . domain . run ( ( ) => { setImmediate ( ( ) => { for ( let i = 0 ; i < chunk . length ; i ++ ) chunk [ i ] = ( ( chunk [ i ] + Math . random ( ) * 100 ) % 96 ) + 33 ; const self = domain . active . data . inst ; self . cb ( chunk ) ; } ) ; } ) ; } ;

The above shows that it is difficult to have more than one asynchronous API attempt to use domains to propagate data. This example could possibly be fixed by assigning parent: domain.active in the DataStream constructor. Then restoring it via domain.active = domain.active.data.parent just before the user's callback is called. Also the instantiation of DataStream in the 'connection' callback must be run inside d.run() , instead of simply using d.add(c) , otherwise there will be no active domain.

In short, for this to have a prayer of a chance usage would need to strictly adhere to a set of guidelines that would be difficult to enforce or test.

Performance Issues

A significant deterrent from using domains is the overhead. Using node's built-in http benchmark, http_simple.js , without domains it can handle over 22,000 requests/second. Whereas if it's run with NODE_USE_DOMAINS=1 that number drops down to under 17,000 requests/second. In this case there is only a single global domain. If we edit the benchmark so the http request callback creates a new domain instance performance drops further to 15,000 requests/second.

While this probably wouldn't affect a server only serving a few hundred or even a thousand requests per second, the amount of overhead is directly proportional to the number of asynchronous requests made. So if a single connection needs to connect to several other services all of those will contribute to the overall latency of delivering the final product to the client.

Using AsyncWrap and tracking the number of times init / pre / post / destroy are called in the mentioned benchmark we find that the sum of all events called is over 170,000 times per second. This means even adding 1 microsecond overhead per call for any type of setup or tear down will result in a 17% performance loss. Granted, this is for the optimized scenario of the benchmark, but I believe this demonstrates the necessity for a mechanism such as domain to be as cheap to run as possible.

Looking Ahead