zathras



Offline



Activity: 266

Merit: 250









Sr. MemberActivity: 266Merit: 250 Masterchest Wallet Alpha Testing Thread February 24, 2014, 02:48:45 AM

Last edit: May 12, 2014, 01:34:44 AM by zathras #1



I'd like some help testing the first proper alpha of the Windows Masterchest Wallet for the Master Protocol & Mastercoin.



The source & binary will be posted up here later tonight are below. For starters you'll need to get your transaction index re-enabled in bitcoind/qt. Please see the instructions for further information.



I'd suggest the very first testers have perhaps done sends via the advisor script & are technically minded.



If possible I also suggest creating a new bitcoin wallet.dat (back up the old one of course - several times ), grabbing the new address and sending a small amount of BTC and/or MSC (via the advisor script) to this new address. Then test the wallet with this new bitcoin wallet.dat. Remember this is alpha software - it would be foolish to test it on a wallet containing significant sums of any currency.



This initial alpha will focus on getting the wallet up and running along with simple sends. Distributed Exchange functionality is disabled in this build. I'll then release a build with DEx around the end of the week and the focus will switch to testing DEx.



EDIT: Alpha 0.2 is up for initial testing of the DEx functionality. Instructions have been briefly updated. Thanks!

EDIT: Alpha 0.3 is up for initial testing of the DEx functionality, including real MSC. Thanks

EDIT: Alpha 0.3c is up for initial testing of the DEx functionality, including real MSC. Thanks

EDIT: Alpha 0.4a is up for smart property support (display/send). Thanks



Remember this is alpha software and still contains a lot of bugs - it would be incredibly foolish to test this on a bitcoin wallet holding any significant amount of funds.







Source:

Binary:

Instructions:



Requirements: .NET Framework 4, bitcoind/qt with transaction index enabled



Thanks

Zathras

Hey guys,I'd like some help testing the first proper alpha of the Windows Masterchest Wallet for the Master Protocol & Mastercoin.The source & binaryare below. For starters you'll need to get your transaction index re-enabled in bitcoind/qt. Please see the instructions for further information.I'd suggest the very first testers have perhaps done sends via the advisor script & are technically minded.If possible I also suggest creating a new bitcoin wallet.dat (back up the old one of course - several times), grabbing the new address and sending a small amount of BTC and/or MSC (via the advisor script) to this new address. Then test the wallet with this new bitcoin wallet.dat. Remember this is- it would be foolish to test it on a wallet containing significant sums of any currency.This initial alpha will focus on getting the wallet up and running along with simple sends. Distributed Exchange functionality is disabled in this build. I'll then release a build with DEx around the end of the week and the focus will switch to testing DEx.EDIT: Alpha 0.2 is up for initial testing of the DEx functionality. Instructions have been briefly updated. Thanks!EDIT: Alpha 0.3 is up for initial testing of the DEx functionality, including real MSC. ThanksEDIT: Alpha 0.3c is up for initial testing of the DEx functionality, including real MSC. ThanksSource: Github Binary: Github Instructions: here Requirements: .NET Framework 4, bitcoind/qt with transaction index enabledThanksZathras Smart Property & Distributed Exchange: Master Protocol for Bitcoin

dexX7



Offline



Activity: 1106

Merit: 1005









LegendaryActivity: 1106Merit: 1005 Re: Masterchest Wallet Alpha Testing Thread February 24, 2014, 10:19:35 PM #10



very nice to see this update. Looks very, very good!



Didn't try sending, but wallets are identified, balances are correct, transaction history is there also!



Here are two problems I found so far:





1. RPC usernames and passwords are case sensitive



After reading the wallet.cfg the username and password are currently parsed and casted to lower case. This shouldn't happen.



This affects:



https://github.com/zathras-crypto/masterchest-wallet/blob/master/source/Form1.vb#L95

https://github.com/zathras-crypto/masterchest-wallet/blob/master/source/Form1.vb#L138

https://github.com/zathras-crypto/masterchest-wallet/blob/master/source/Form1.vb#L141



Fix: remove .ToLower.







2. This was a nasty one! In some regions the decimal mark is a comma and somewhere else a point, e.g. "16058.671616199374" vs. "16058,671616199374".



Using a comma results in faulty SQL queries like this one:



Code: insert into balances (address, cbalance, cbalancet) VALUES ('1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P', 1605867161619,94,0)

Which is invalid, because "1605867161619,94" is interpreted as two different values.



So far, I identified this line:



https://github.com/zathras-crypto/masterchest-wallet/blob/master/source/Form1.vb#L564



Code: cmd.CommandText = "insert into balances (address, cbalance, cbalancet) VALUES ('1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P', " & (devmsc * 100000000) & ",0)"

Fix for this one:



Code: cmd.CommandText = "insert into balances (address, cbalance, cbalancet) VALUES ('1EXoDusjGwvnjZUyKkxZ4UHEf77z6A5S4P', " & (devmsc * 100000000).ToString(Globalization.CultureInfo.InvariantCulture) & ",0)"

It's probably a better solution to globally define the culture though. Hey,very nice to see this update. Looks very, very good!Didn't try sending, but wallets are identified, balances are correct, transaction history is there also!Here are two problems I found so far:1. RPC usernames and passwords are case sensitiveAfter reading the wallet.cfg the username and password are currently parsed and casted to lower case. This shouldn't happen.This affects:Fix: remove .ToLower.2. This was a nasty one! In some regions the decimal mark is a comma and somewhere else a point, e.g. "16058.671616199374" vs. "16058,671616199374".Using a comma results in faulty SQL queries like this one:Which is invalid, because "1605867161619,94" is interpreted as two different values.So far, I identified this line:Fix for this one:It's probably a better solution to globally define the culture though. The Mastercoin faucet | Redeem unspent multisig outputs

prophetx



Offline



Activity: 1624

Merit: 1002





he who has the gold makes the rules







LegendaryActivity: 1624Merit: 1002he who has the gold makes the rules Re: Masterchest Wallet Alpha Testing Thread February 24, 2014, 10:37:42 PM #11



https://github.com/zathras-crypto/masterchest-wallet/issues/3 i am not able to get it to connect on win 8, i know bitcoin daemon is running b/c i can connect other apps to it

zathras



Offline



Activity: 266

Merit: 250









Sr. MemberActivity: 266Merit: 250 Re: Masterchest Wallet Alpha Testing Thread February 24, 2014, 10:44:11 PM #12



Already straight into it OK - dexX7 great thanks!



1) have already committed a bugfix for the tolower on RPC details which got missed

2) Ouch yeah I'll take a look at that now

2) this was actually a problem with my dev MSC calculation having too many decimals - that query should have only ever been sending a whole number to the db - committed a fix



Prophetx - could you try the latest binary - this way we can see if it's win8 or the rpc case issue.



Thanks

Zathras Wow thanks guysAlready straight into itOK - dexX7 great thanks!1) have already committed a bugfix for the tolower on RPC details which got missed2) this was actually a problem with my dev MSC calculation having too many decimals - that query should have only ever been sending a whole number to the db - committed a fixProphetx - could you try the latest binary - this way we can see if it's win8 or the rpc case issue.ThanksZathras Smart Property & Distributed Exchange: Master Protocol for Bitcoin